Re: [PATCH 6.19 000/844] 6.19.6-rc1 review

["Barry K. Nathan" <barryn@pobox.com>]

On 2/28/26 14:13, Woody Suwalski wrote:
> Ronald Warsow wrote:
>> On 28.02.26 18:18, Sasha Levin wrote:
>>>
>>> This is the start of the stable review cycle for the 6.19.6 release.
>>> There are 844 patches in this series, all will be posted as a response
>>> to this one.  If anyone has any issues with these being applied, please
>>> let me know.
>>>
>>> Responses should be made by Mon Mar  2 05:32:25 PM UTC 2026.
>>> Anything received after that time might be too late.
>>>
>>> The whole patch series can be found in one patch at:
>>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable- 
>>> rc.git/patch/?id=linux-6.19.y&id2=v6.19.5
>>> or in the git tree and branch at:
>>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable- 
>>> rc.git linux-6.19.y
>>> and the diffstat can be found below.
>>>
>>
>> It would be nice to have a download link to an patch-*.gz what Greg 
>> usually provides.
>>
>> ron
>>
> I second this request. Trying to setup a build for  5.10.252-rc1 was 
> tricky...
> We need something similar to
> 
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/ 
> patch-5.10.251-rc1.gz
> 
> Thanks, Woody

I didn't find things particularly difficult for 5.10.252-rc1 through
6.12.75-rc1 (the "hardest" part was renaming the file after each
download), but I get this while trying to apply the patches for
6.18.16-rc1/6.19.6-rc1:


patching file arch/powerpc/platforms/pseries/msi.c
patching file arch/x86/kvm/x86.c
(Patch is indented 2 spaces.)
can't find file to patch at input line 41896
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--
|cgit 1.2.3-korg
|
|
|From 1d0d76474aeadb174d9fbd27b9f2e9b5cfc124c6 Mon Sep 17 00:00:00 2001
|From: Sean Christopherson <seanjc@google.com>
|Date: Tue, 16 Dec 2025 08:17:54 -0800
|Subject: KVM: nSVM: Remove a user-triggerable WARN on nested_svm_load_cr3()
| succeeding
|
|[ Upstream commit fc3ba56385d03501eb582e4b86691ba378e556f9 ]
|
|Drop the WARN in svm_set_nested_state() on nested_svm_load_cr3() failing
|as it is trivially easy to trigger from userspace by modifying CPUID after
|loading CR3.  E.g. modifying the state restoration selftest like so:
|
|  --- tools/testing/selftests/kvm/x86/state_test.c
|  +++ tools/testing/selftests/kvm/x86/state_test.c
--------------------------
File to patch:


As it turns out, GNU patch (v2.7.6 on Debian 12 bookworm, or v2.8 on
Debian 13 trixie, I tested both) is misinterpreting part of the commit
comment for vm-nsvm-remove-a-user-triggerable-warn-on-nested_sv.patch
and trying to apply that part of the commit description as a patch.

Pressing Enter twice at this prompt causes patch to skip this
incorrectly detected hunk, and all of the actual patches end up being
applied correctly, but it's still an unexpected surprise and I had to
stop and figure out what was going on.

With the way the stable rc patches are usually posted on kernel.org,
the patch file would've omitted the commit comments, thus avoiding
this problem.

-- 
-Barry K. Nathan  <barryn@pobox.com>