From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24FC8525E for ; Wed, 30 Aug 2023 16:01:58 +0000 (UTC) Received: from [192.168.1.103] (178.176.75.182) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.986.14; Wed, 30 Aug 2023 19:01:56 +0300 Subject: Re: [PATCH 4.19 042/129] mmc: sunxi: fix deferred probing To: Greg Kroah-Hartman , CC: , Jernej Skrabec , Ulf Hansson , Sasha Levin References: <20230828101153.030066927@linuxfoundation.org> <20230828101154.735161155@linuxfoundation.org> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: <406bdada-fbd1-c23b-2c86-384e21b46e37@omp.ru> Date: Wed, 30 Aug 2023 19:01:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20230828101154.735161155@linuxfoundation.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [178.176.75.182] X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 5.9.59, Database issued on: 08/30/2023 15:30:03 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 179545 [Aug 30 2023] X-KSE-AntiSpam-Info: Version: 5.9.59.0 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 529 529 a773548e495283fecef97c3e587259fde2135fef X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_uf_ne_domains} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 178.176.75.182 in (user) dbl.spamhaus.org} X-KSE-AntiSpam-Info: lore.kernel.org:7.1.1;178.176.75.182:7.1.2,7.7.3;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;omp.ru:7.1.1;127.0.0.199:7.1.2 X-KSE-AntiSpam-Info: FromAlignment: s X-KSE-AntiSpam-Info: {rdns complete} X-KSE-AntiSpam-Info: {fromrtbl complete} X-KSE-AntiSpam-Info: ApMailHostAddress: 178.176.75.182 X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=none header.from=omp.ru;spf=none smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 08/30/2023 15:35:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 8/30/2023 2:00:00 PM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit On 8/28/23 1:12 PM, Greg Kroah-Hartman wrote: > 4.19-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Sergey Shtylyov > > [ Upstream commit c2df53c5806cfd746dae08e07bc8c4ad247c3b70 ] > > The driver overrides the error codes and IRQ0 returned by platform_get_irq() > to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe > permanently instead of the deferred probing. Switch to propagating the error > codes upstream. Since commit ce753ad1549c ("platform: finally disallow IRQ0 > in platform_get_irq() and its ilk") IRQ0 is no longer returned by those APIs, > so we now can safely ignore it... > > Fixes: 2408a08583d2 ("mmc: sunxi-mmc: Handle return value of platform_get_irq") > Cc: stable@vger.kernel.org # v5.19+ After a glance at the driver, the patch too seems safe to be applied to 4.19.y, despite I tried to limit it to 5.19.y and newer... > Signed-off-by: Sergey Shtylyov > Reviewed-by: Jernej Skrabec > Link: https://lore.kernel.org/r/20230617203622.6812-12-s.shtylyov@omp.ru > Signed-off-by: Ulf Hansson > Signed-off-by: Sasha Levin [...] MBR, Sergey