From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4F4430CE0 for ; Fri, 15 Sep 2023 14:47:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694789255; x=1726325255; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=RSdffzo1Ydfr8wTOPsJoUEWKUqgBQtx4q1XDTHhuglM=; b=gr2BqvAhnzs1sKFPuJolVLPoSBz5iV+PsWpNX3mkHmOBgEd7+ChD4UfG v6SMaWMobfHOvL4GR3L4oEwil+Lr1SxBTWoPQIeGEtjdp3adVmIGwKwHc APixYkkEwGcKxDW1hkepFURLVdfMxZ4XnU55y2bfluJfd9mba5IqrguOj dFMUODdUe1sp5Fqo5pxnbyb2UDCruAbYEFDNKc+LZOleTpTi+mV+o9GMI Rsmwj9pqItikf3EHl5vjiNRbSTg0R/q5g2pxd/Z9SLXpAoa0OYOUwk9FU Xy5RAJZvN7iEGTtWtWLdJUchqT7HhoIlZEW8iIJ8kx2URTkoE90eu2B7X Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10834"; a="410202248" X-IronPort-AV: E=Sophos;i="6.02,149,1688454000"; d="scan'208";a="410202248" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2023 07:45:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10834"; a="774340718" X-IronPort-AV: E=Sophos;i="6.02,149,1688454000"; d="scan'208";a="774340718" Received: from srdoo-mobl1.ger.corp.intel.com ([10.252.38.99]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2023 07:45:44 -0700 Date: Fri, 15 Sep 2023 17:45:42 +0300 (EEST) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Stephen Boyd cc: Mika Westerberg , Hans de Goede , Mark Gross , LKML , patches@lists.linux.dev, platform-driver-x86@vger.kernel.org, Andy Shevchenko , Kuppuswamy Sathyanarayanan , Prashant Malani Subject: Re: [PATCH v4 3/4] platform/x86: intel_scu_ipc: Don't override scu in intel_scu_ipc_dev_simple_command() In-Reply-To: <20230913212723.3055315-4-swboyd@chromium.org> Message-ID: <58e817b0-1872-6ff1-58bb-1aeeb572361@linux.intel.com> References: <20230913212723.3055315-1-swboyd@chromium.org> <20230913212723.3055315-4-swboyd@chromium.org> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-769386324-1694789146=:2347" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-769386324-1694789146=:2347 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT On Wed, 13 Sep 2023, Stephen Boyd wrote: > Andy discovered this bug during patch review. The 'scu' argument to this > function shouldn't be overridden by the function itself. It doesn't make > any sense. Looking at the commit history, we see that commit > f57fa18583f5 ("platform/x86: intel_scu_ipc: Introduce new SCU IPC API") > removed the setting of the scu to ipcdev in other functions, but not > this one. That was an oversight. Remove this line so that we stop > overriding the scu instance that is used by this function. > > Reported-by: Andy Shevchenko > Closes: https://lore.kernel.org/r/ZPjdZ3xNmBEBvNiS@smile.fi.intel.com This looks somewhat unusual way to tag it. I'd just drop the Closes tag as the email list is not a bug tracter. Other than that, Reviewed-by: Ilpo Järvinen -- i. > Cc: Prashant Malani > Reviewed-by: Andy Shevchenko > Reviewed-by: Mika Westerberg > Fixes: f57fa18583f5 ("platform/x86: intel_scu_ipc: Introduce new SCU IPC API") > Signed-off-by: Stephen Boyd > --- > drivers/platform/x86/intel_scu_ipc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/platform/x86/intel_scu_ipc.c b/drivers/platform/x86/intel_scu_ipc.c > index 299c15312acb..3271f81a9c00 100644 > --- a/drivers/platform/x86/intel_scu_ipc.c > +++ b/drivers/platform/x86/intel_scu_ipc.c > @@ -443,7 +443,6 @@ int intel_scu_ipc_dev_simple_command(struct intel_scu_ipc_dev *scu, int cmd, > mutex_unlock(&ipclock); > return -ENODEV; > } > - scu = ipcdev; > cmdval = sub << 12 | cmd; > ipc_command(scu, cmdval); > err = intel_scu_ipc_check_status(scu); > --8323329-769386324-1694789146=:2347--