From: Stefan Haberland <sth@linux.ibm.com>
To: Nathan Chancellor <nathan@kernel.org>,
akpm@linux-foundation.org, hca@linux.ibm.com, gor@linux.ibm.com,
agordeev@linux.ibm.com
Cc: borntraeger@linux.ibm.com, svens@linux.ibm.com,
linux-s390@vger.kernel.org, patches@lists.linux.dev,
hoeppner@linux.ibm.com
Subject: Re: [PATCH 1/2] s390/dasd: Remove dasd_stats_generic_show()
Date: Mon, 4 Dec 2023 14:13:15 +0100 [thread overview]
Message-ID: <5e21338a-b55a-4b3d-900f-55c4397baca9@linux.ibm.com> (raw)
In-Reply-To: <20231130-s390-missing-prototypes-v1-1-799d3cf07fb7@kernel.org>
Am 01.12.23 um 01:22 schrieb Nathan Chancellor:
> With CONFIG_DASD_PROFILE=n, there is a warning that
> dasd_stats_generic_show() is missing a prototype:
>
> drivers/s390/block/dasd.c:1109:5: warning: no previous prototype for 'dasd_stats_generic_show' [-Wmissing-prototypes]
> 1109 | int dasd_stats_generic_show(struct seq_file *m, void *v)
> | ^~~~~~~~~~~~~~~~~~~~~~~
>
> This function has been unused since its introduction in
> commit 4fa52aa7a82f ("[S390] dasd: add enhanced DASD statistics
> interface"), remove it to clear up the warning.
>
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
Acked-by: Stefan Haberland<sth@linux.ibm.com>
next prev parent reply other threads:[~2023-12-04 13:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 0:22 [PATCH 0/2] s390: A couple of fixes for -Wmissing-prototypes Nathan Chancellor
2023-12-01 0:22 ` [PATCH 1/2] s390/dasd: Remove dasd_stats_generic_show() Nathan Chancellor
2023-12-04 7:41 ` Alexander Gordeev
2023-12-04 13:13 ` Stefan Haberland [this message]
2023-12-01 0:22 ` [PATCH 2/2] s390/traps: Only define is_valid_bugaddr() under CONFIG_GENERIC_BUG Nathan Chancellor
2023-12-04 9:06 ` Alexander Gordeev
2023-12-04 16:38 ` Nathan Chancellor
2023-12-05 12:59 ` Alexander Gordeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e21338a-b55a-4b3d-900f-55c4397baca9@linux.ibm.com \
--to=sth@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hoeppner@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=patches@lists.linux.dev \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox