[PATCH] arm64: dts: qcom: sc7180: Remove ipa_fw_mem node on trogdor

[PATCH] arm64: dts: qcom: sc7180: Remove ipa_fw_mem node on trogdor

[Stephen Boyd]

We don't use this carveout on trogdor boards, and having it defined in
the sc7180 SoC file causes an overlap message to be printed at boot.

 OF: reserved mem: OVERLAP DETECTED!
 memory@86000000 (0x0000000086000000--0x000000008ec00000) overlaps with memory@8b700000 (0x000000008b700000--0x000000008b710000)

Delete the node in the trogdor dtsi file to fix the overlap problem and
remove the error message.

Cc: Alex Elder <elder@linaro.org>
Cc: Matthias Kaehlcke <mka@chromium.org>
Fixes: 310b266655a3 ("arm64: dts: qcom: sc7180: define ipa_fw_mem node")
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
 arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index 732e1181af48..262224504921 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -42,6 +42,7 @@ charger-crit {
  */
 
 /delete-node/ &hyp_mem;
+/delete-node/ &ipa_fw_mem;
 /delete-node/ &xbl_mem;
 /delete-node/ &aop_mem;
 /delete-node/ &sec_apps_mem;

base-commit: 42226c989789d8da4af1de0c31070c96726d990c
-- 
https://chromeos.dev

Re: [PATCH] arm64: dts: qcom: sc7180: Remove ipa_fw_mem node on trogdor

[Alex Elder]

On 5/17/22 2:33 PM, Stephen Boyd wrote:
> We don't use this carveout on trogdor boards, and having it defined in
> the sc7180 SoC file causes an overlap message to be printed at boot.
> 
>   OF: reserved mem: OVERLAP DETECTED!
>   memory@86000000 (0x0000000086000000--0x000000008ec00000) overlaps with memory@8b700000 (0x000000008b700000--0x000000008b710000)
> 
> Delete the node in the trogdor dtsi file to fix the overlap problem and
> remove the error message.'

Is the mpss_mem node (which defines 0x86000000-0x8ec00000) correct?

You're right, we don't use that memory on Chrome OS, but I just
wondered whether the other node might also have a problem.

I don't actually know...  Bjorn, do you?

					-Alex

> Cc: Alex Elder <elder@linaro.org>
> Cc: Matthias Kaehlcke <mka@chromium.org>
> Fixes: 310b266655a3 ("arm64: dts: qcom: sc7180: define ipa_fw_mem node")
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
>   arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> index 732e1181af48..262224504921 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> @@ -42,6 +42,7 @@ charger-crit {
>    */
>   
>   /delete-node/ &hyp_mem;
> +/delete-node/ &ipa_fw_mem;
>   /delete-node/ &xbl_mem;
>   /delete-node/ &aop_mem;
>   /delete-node/ &sec_apps_mem;
> 
> base-commit: 42226c989789d8da4af1de0c31070c96726d990c

Re: [PATCH] arm64: dts: qcom: sc7180: Remove ipa_fw_mem node on trogdor

[Stephen Boyd]

Quoting Alex Elder (2022-05-17 12:51:34)
> On 5/17/22 2:33 PM, Stephen Boyd wrote:
> > We don't use this carveout on trogdor boards, and having it defined in
> > the sc7180 SoC file causes an overlap message to be printed at boot.
> >
> >   OF: reserved mem: OVERLAP DETECTED!
> >   memory@86000000 (0x0000000086000000--0x000000008ec00000) overlaps with memory@8b700000 (0x000000008b700000--0x000000008b710000)
> >
> > Delete the node in the trogdor dtsi file to fix the overlap problem and
> > remove the error message.'
>
> Is the mpss_mem node (which defines 0x86000000-0x8ec00000) correct?

I think it is. Modem is working for me.

>
> You're right, we don't use that memory on Chrome OS, but I just
> wondered whether the other node might also have a problem.

What sort of problem are you thinking about?

>
> I don't actually know...  Bjorn, do you?
>

Re: [PATCH] arm64: dts: qcom: sc7180: Remove ipa_fw_mem node on trogdor

[Alex Elder]

On 5/17/22 3:06 PM, Stephen Boyd wrote:
> Quoting Alex Elder (2022-05-17 12:51:34)
>> On 5/17/22 2:33 PM, Stephen Boyd wrote:
>>> We don't use this carveout on trogdor boards, and having it defined in
>>> the sc7180 SoC file causes an overlap message to be printed at boot.
>>>
>>>    OF: reserved mem: OVERLAP DETECTED!
>>>    memory@86000000 (0x0000000086000000--0x000000008ec00000) overlaps with memory@8b700000 (0x000000008b700000--0x000000008b710000)
>>>
>>> Delete the node in the trogdor dtsi file to fix the overlap problem and
>>> remove the error message.'
>>
>> Is the mpss_mem node (which defines 0x86000000-0x8ec00000) correct?
> 
> I think it is. Modem is working for me.
> 
>>
>> You're right, we don't use that memory on Chrome OS, but I just
>> wondered whether the other node might also have a problem.
> 
> What sort of problem are you thinking about?

At some point in the past I think some of these carved out
areas got updated (perhaps on sdm845?).  I.e. they were
wrong, and got corrected later.  Some things worked despite
that.  So the problem, for example, might be that the
mpss region is bigger than it needs to be.

I don't *assume* there's a problem, I was just asking,
and maybe Bjorn or someone else can verify what's right.

I'm done for the day right now; otherwise I'd spend a
little more time trying to track the information down
myself...

					-Alex


>>
>> I don't actually know...  Bjorn, do you?
>>

Re: [PATCH] arm64: dts: qcom: sc7180: Remove ipa_fw_mem node on trogdor

[Stephen Boyd]

Quoting Alex Elder (2022-05-17 13:56:06)
> On 5/17/22 3:06 PM, Stephen Boyd wrote:
> > Quoting Alex Elder (2022-05-17 12:51:34)
> >> On 5/17/22 2:33 PM, Stephen Boyd wrote:
> >>> We don't use this carveout on trogdor boards, and having it defined in
> >>> the sc7180 SoC file causes an overlap message to be printed at boot.
> >>>
> >>>    OF: reserved mem: OVERLAP DETECTED!
> >>>    memory@86000000 (0x0000000086000000--0x000000008ec00000) overlaps with memory@8b700000 (0x000000008b700000--0x000000008b710000)
> >>>
> >>> Delete the node in the trogdor dtsi file to fix the overlap problem and
> >>> remove the error message.'
> >>
> >> Is the mpss_mem node (which defines 0x86000000-0x8ec00000) correct?
> >
> > I think it is. Modem is working for me.
> >
> >>
> >> You're right, we don't use that memory on Chrome OS, but I just
> >> wondered whether the other node might also have a problem.
> >
> > What sort of problem are you thinking about?
>
> At some point in the past I think some of these carved out
> areas got updated (perhaps on sdm845?).  I.e. they were
> wrong, and got corrected later.  Some things worked despite
> that.  So the problem, for example, might be that the
> mpss region is bigger than it needs to be.
>
> I don't *assume* there's a problem, I was just asking,
> and maybe Bjorn or someone else can verify what's right.
>
> I'm done for the day right now; otherwise I'd spend a
> little more time trying to track the information down
> myself...

Did you find anything? Otherwise, can you provide a Reviewed-by tag?

Re: [PATCH] arm64: dts: qcom: sc7180: Remove ipa_fw_mem node on trogdor

[Alex Elder]

On 5/17/22 2:33 PM, Stephen Boyd wrote:
> We don't use this carveout on trogdor boards, and having it defined in
> the sc7180 SoC file causes an overlap message to be printed at boot.
> 
>   OF: reserved mem: OVERLAP DETECTED!
>   memory@86000000 (0x0000000086000000--0x000000008ec00000) overlaps with memory@8b700000 (0x000000008b700000--0x000000008b710000)
> 
> Delete the node in the trogdor dtsi file to fix the overlap problem and
> remove the error message.
> 
> Cc: Alex Elder <elder@linaro.org>
> Cc: Matthias Kaehlcke <mka@chromium.org>
> Fixes: 310b266655a3 ("arm64: dts: qcom: sc7180: define ipa_fw_mem node")
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
>   arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> index 732e1181af48..262224504921 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> @@ -42,6 +42,7 @@ charger-crit {
>    */
>   
>   /delete-node/ &hyp_mem;
> +/delete-node/ &ipa_fw_mem;
>   /delete-node/ &xbl_mem;
>   /delete-node/ &aop_mem;
>   /delete-node/ &sec_apps_mem;
> 
> base-commit: 42226c989789d8da4af1de0c31070c96726d990c

This is on Trogdor, which as far as I know only runs Chrome OS,
which doesn't use the IPA firmware memory carveout.  The problem
reported comes from the definition of the mpss_mem reserved-memory
region in "sc7180-trogdor.dtsi", so deleting the "ipa_fw_mem" node
in that file sounds like the right fix.

Reviewed-by: Alex Elder <elder@linaro.org>

Re: (subset) [PATCH] arm64: dts: qcom: sc7180: Remove ipa_fw_mem node on trogdor

[Bjorn Andersson]

On Tue, 17 May 2022 12:33:07 -0700, Stephen Boyd wrote:
> We don't use this carveout on trogdor boards, and having it defined in
> the sc7180 SoC file causes an overlap message to be printed at boot.
> 
>  OF: reserved mem: OVERLAP DETECTED!
>  memory@86000000 (0x0000000086000000--0x000000008ec00000) overlaps with memory@8b700000 (0x000000008b700000--0x000000008b710000)
> 
> Delete the node in the trogdor dtsi file to fix the overlap problem and
> remove the error message.
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: sc7180: Remove ipa_fw_mem node on trogdor
      commit: e60414644cf3a703e10ed4429c15263095945ffe

Best regards,
-- 
Bjorn Andersson <bjorn.andersson@linaro.org>