From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9116C4989D for ; Mon, 18 Dec 2023 18:45:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kOENMXAR" Received: by mail-oi1-f169.google.com with SMTP id 5614622812f47-3ba1be5ad0aso2312753b6e.0 for ; Mon, 18 Dec 2023 10:45:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702925145; x=1703529945; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Vop2uFv4rXB3gLGa/IM62jEvSbype2QIt8DlInO6Kyg=; b=kOENMXARM8dapocxg9iKoRFydwcEnjwzS7tKq3V9yNhTLpJyapItZvia/jdDKl9Ix9 gA/8pKmWzr9pZZxd/F0Ea2JSLdL7RZqwcrA/jQBP0Ya5STYQDkNAcs4MuicQtOQR5IfE ISu68ay02N4Qd6AIaAaPaQaK2qxnv2GlYxrRoJ2C6tpk/I4OT6iLKyCtmwD8KouVw/2Y DSrgOgaUjs42kBAf3AfQJ/YuTEk2T3Kxkbt1L/VgEtwZ2cyiTYGo6+dU/nzxDlApSLpc 5jhGMO7SNorc9d92Sm4//sjNGbkxcqfae3hFGN/TyiXoPbQOfkQQU1rMIKZuySA0+q85 v11A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702925145; x=1703529945; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Vop2uFv4rXB3gLGa/IM62jEvSbype2QIt8DlInO6Kyg=; b=KTEa5wo4AmxoD1nL1Ognq3vsy56adV1SUUsERQRmfqWmD10TX9usVVR2NuiK5spmEN K3Qcvgn+KpTYb6xkDVfDHzROWdwcuRcDAExtAz/3i1q/DR4xmzabXPD08LrG6rK0PToR avALxAs6o2t0drtYWxgS9Iabq8u1pGc/Xg8/toFlsXd071uUaumr2I6deD7waw7KZTzU uLSiacxGte4xl6Lq04UNkvjTpnEEIwQfuYnCg6q6JfT+16GCWP+w8bhsDKW+OW76Sskb xTfa8cCgaVvXf8xfT09Zf30q9/0mT10b5kDthBMeFBu7ExK2vooF/bVdLs1+3whrezPa Ne1g== X-Gm-Message-State: AOJu0Ywnf0lqRs0IfSUkE9exwL+oRz+a2dRqmquC4pVbc9jH4z2CbLmo HKGyqeVfhCaDmsqJhh23ziPuZw== X-Google-Smtp-Source: AGHT+IHAkZlV51+wTttl7nrvpCpK2nk37v5GU9SmEXlt8T4CP4cNDlbfxTER3tnl4vbwVHc/mNtIFA== X-Received: by 2002:a05:6808:4487:b0:3b9:e607:515c with SMTP id eq7-20020a056808448700b003b9e607515cmr23269565oib.93.1702925145614; Mon, 18 Dec 2023 10:45:45 -0800 (PST) Received: from [192.168.17.16] ([138.84.62.99]) by smtp.gmail.com with ESMTPSA id f17-20020a05680807d100b003ba3249652csm1783274oij.1.2023.12.18.10.45.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Dec 2023 10:45:45 -0800 (PST) Message-ID: <6299a661-5ae5-4f7c-9fa7-96c4e7ae39eb@linaro.org> Date: Mon, 18 Dec 2023 12:45:42 -0600 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4.19 13/36] net: stmmac: use dev_err_probe() for reporting mdio bus registration failure To: Greg Kroah-Hartman , stable@vger.kernel.org Cc: patches@lists.linux.dev, Rasmus Villemoes , Jakub Kicinski , Sasha Levin References: <20231218135041.876499958@linuxfoundation.org> <20231218135042.347406314@linuxfoundation.org> Content-Language: en-US From: =?UTF-8?Q?Daniel_D=C3=ADaz?= In-Reply-To: <20231218135042.347406314@linuxfoundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hello! On 18/12/23 7:51 a. m., Greg Kroah-Hartman wrote: > 4.19-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Rasmus Villemoes > > [ Upstream commit 839612d23ffd933174db911ce56dc3f3ca883ec5 ] > > I have a board where these two lines are always printed during boot: > > imx-dwmac 30bf0000.ethernet: Cannot register the MDIO bus > imx-dwmac 30bf0000.ethernet: stmmac_dvr_probe: MDIO bus (id: 1) registration failed > > It's perfectly fine, and the device is successfully (and silently, as > far as the console goes) probed later. > > Use dev_err_probe() instead, which will demote these messages to debug > level (thus removing the alarming messages from the console) when the > error is -EPROBE_DEFER, and also has the advantage of including the > error code if/when it happens to be something other than -EPROBE_DEFER. > > While here, add the missing \n to one of the format strings. > > Signed-off-by: Rasmus Villemoes > Link: https://lore.kernel.org/r/20220602074840.1143360-1-linux@rasmusvillemoes.dk > Signed-off-by: Jakub Kicinski > Stable-dep-of: e23c0d21ce92 ("net: stmmac: Handle disabled MDIO busses from devicetree") > Signed-off-by: Sasha Levin > Signed-off-by: Greg Kroah-Hartman > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -4428,7 +4428,7 @@ int stmmac_dvr_probe(struct device *devi > ret = stmmac_mdio_register(ndev); > if (ret < 0) { > dev_err(priv->device, > - "%s: MDIO bus (id: %d) registration failed", > + "%s: MDIO bus (id: %d) registration failed\n", > __func__, priv->plat->bus_id); > goto error_mdio_register; > } This patch doesn't do what it says it does. Greetings! Daniel Díaz