From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1887615AC for ; Fri, 25 Nov 2022 10:33:10 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 08DFF5C00F5; Fri, 25 Nov 2022 05:33:10 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute3.internal (MEProxy); Fri, 25 Nov 2022 05:33:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1669372390; x=1669458790; bh=JROol/irmv N5MEhKuBHYiHbWYmYWc16fBXOgVLqfN3w=; b=nc6+evhM3PIDQl6BIqrif/Xc90 fnSj7VcZ+bdORPHuauNy1fBgw/kKBaDBy2vc39GQNCgHzf2LuWLVwUTZy04QZKlS j8lzQVSTLtKHYmGS23rlmJ57G97jCKDfr9zjbVgAscon8MgkqyF7lgo4OTtwHR9/ Q3mBYW5S9NpoDlPcqoDvQyK5t4IEOGMjR6ABWAxYj7r/ML0UhmYbXIaPa8rWy9Sd /tMIYfwHfZkg+uBurm11rFWrCNrhfMjq09kVNyKYfTz4pOCgI+iMrc6DiBid9z/M HtJPe9AoWNDCs8PolW70SXGNXsAmnB9g/Uu6MY9bsYhHMnOSkAfKH85BcMmA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1669372390; x=1669458790; bh=JROol/irmvN5MEhKuBHYiHbWYmYW c16fBXOgVLqfN3w=; b=U1hY0Cudj6B4TKUpU+tp2asHfGqBdJUcRkwh/m9AvweJ 1skw5vkkHJiupRKLu7OC+A4BhA9V0mURms+o/zGEw2Vz0nWcsB89Jrfz8/ioPOP6 ccrGqXDEC8Ef7q1ny1WS3dEG84csgp/39vf49Y4gYeVOUwbJIKuFcM/3cZVo1SNp g3xnD2Uz4k/s7jLtpyIDOTO7cqeSvN89nbcy5+nxN8gT3J1VMGmTJLrCKbbZjcvl Z69J6+e7+Baf7WAiP+dvzqACH33mbbajKakUiyb5kX3zsmcPNwxXARdEtTCiX2vT gyZ/FWJ2mRnqnPimFL4yxRy29jqMc9XN7D4q9lZfsw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrieehgddujecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedtkeet ffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrh hnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 5B292B60086; Fri, 25 Nov 2022 05:33:09 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1115-g8b801eadce-fm-20221102.001-g8b801ead Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Message-Id: <78fc17ac-bdce-4835-953d-d50d0a467146@app.fastmail.com> In-Reply-To: <23b0fa9c-d041-8c56-ec4b-04991fa340d4@huawei.com> References: <20221123084557.945845710@linuxfoundation.org> <23b0fa9c-d041-8c56-ec4b-04991fa340d4@huawei.com> Date: Fri, 25 Nov 2022 11:32:49 +0100 From: "Arnd Bergmann" To: YueHaibing , "Naresh Kamboju" , "Greg Kroah-Hartman" Cc: stable@vger.kernel.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, "Linus Torvalds" , "Andrew Morton" , "Guenter Roeck" , shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, "Pavel Machek" , "Jon Hunter" , "Florian Fainelli" , "Sudip Mukherjee" , srw@sladewatkins.net, rwarsow@gmx.de, Netdev , "David S . Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , =?UTF-8?Q?Daniel_D=C3=ADaz?= Subject: Re: [PATCH 5.10 000/149] 5.10.156-rc1 review Content-Type: text/plain On Fri, Nov 25, 2022, at 11:25, YueHaibing wrote: > On 2022/11/25 18:02, Arnd Bergmann wrote: >> On Fri, Nov 25, 2022, at 09:05, Naresh Kamboju wrote: >>> On Fri, 25 Nov 2022 at 12:57, Greg Kroah-Hartman wrote: >>>> On Thu, Nov 24, 2022 at 09:17:36PM +0530, Naresh Kamboju wrote: >>>>> >>>>> Daniel bisected this reported problem and found the first bad commit, >>>>> >>>>> YueHaibing >>>>> net: broadcom: Fix BCMGENET Kconfig >>>> >>>> But that is in 5.10.155, 5.15.79, 6.0.9, and 6.1-rc5. It is not new to >>>> this -rc release. >>> >>> It started from 5.10.155 and this is only seen on 5.10 and other >>> branches 5.15, 6.0 and mainline are looking good. >> >> I think the original patch is wrong and should be fixed upstream. >> The backported patch in question is a one-line Kconfig change doing > > It seems lts 5.10 do not contain commit e5f31552674e ("ethernet: fix > PTP_1588_CLOCK dependencies"), > there is not PTP_1588_CLOCK_OPTIONAL option. Ok, so there is a second problem then. Greg, please just revert fbb4e8e6dc7b ("net: broadcom: Fix BCMGENET Kconfig") in stable/linux-5.10.y: it depends on e5f31552674e ("ethernet: fix PTP_1588_CLOCK dependencies"), which we probably don't want backported from 5.15 to 5.10. YueHaibing, do you agree with my suggestion for improving the upstream 8d820bc9d12b ("net: broadcom: Fix BCMGENET Kconfig") commit? Can you send a follow-up fix, or should I? Arnd