From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2ED14213E77; Wed, 9 Apr 2025 07:06:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744182407; cv=none; b=TpjsZcDVJNZsrFPLiXJ4jemDGI7Xb1QxHK2v4qNYu2bDLjHuGuVi+b1a8qpA2ck7mAAlKP1F8bmbrvXy4DQiFAWuKvFGNoL1gWspb0iacj0p+V3gxQWlKNBYLHRxj211lply5EQh5AL/46E/jZ2iBAvzRdfhOf4voAgmhRqYRFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744182407; c=relaxed/simple; bh=mflL95AIRj3e4w7SQ0uU7taA2tfZwI5QH+IQZ+DDW50=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZtWUQ0oDZYUEHTPlcax4oK1hxiMBlkTA11Pf6PbreabUKnL5btT2CTKY/Bp+uHkoj6OJHkgb/RpVNkkDzbs8hTDGMJyD/Vw9u+QW03KnYIW8BeaIjoz8bDtUo1ONffj9xZh5dzVnUcoYTsVRNxmnt1KCzdF9/e+f1kHXz7XAY+A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=P/DyPGz+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="P/DyPGz+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CB2FC4CEE3; Wed, 9 Apr 2025 07:06:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744182407; bh=mflL95AIRj3e4w7SQ0uU7taA2tfZwI5QH+IQZ+DDW50=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=P/DyPGz+VX9zmLTnuWls0TglQXFP2Tpq/RdjpONNWVnG/ojez6zxRQNAALx/8LNIl rweU3th8j6GhuVTbkZ0k2W9Sv/2BBgiaK03wAZ8FlwLhwnlSxH8pM/7GMLYvIVrmha bcZ+QUCUKWSV+HPBDINywuL2qZCJZKabkuZig3z11S1p5PspR/AKRjqNDjo8OSgjOn EIEBZCxsUohT5JsgYYw6j1TjdncKjnRtEBtjSP4wIVOgrC/G2HM856RTtwiCHpDKTk 0GcMISyethBgyNlCsnj1wj0nuXfS3GC7jopOM57tuCQUIfY3npKB1SOAF5QvihV6fH GQx0l+LdTz97g== Message-ID: <78fdcb36-fac7-4894-923b-b88268568e7b@kernel.org> Date: Wed, 9 Apr 2025 09:06:43 +0200 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6.14 708/731] tracing: Ensure module defining synth event cannot be unloaded while tracing To: Greg Kroah-Hartman , stable@vger.kernel.org Cc: patches@lists.linux.dev, Mathieu Desnoyers , Douglas Raillard , "Masami Hiramatsu (Google)" , "Steven Rostedt (Google)" References: <20250408104914.247897328@linuxfoundation.org> <20250408104930.740570814@linuxfoundation.org> Content-Language: en-US From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: <20250408104930.740570814@linuxfoundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08. 04. 25, 12:50, Greg Kroah-Hartman wrote: > 6.14-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Douglas Raillard > > commit 21581dd4e7ff6c07d0ab577e3c32b13a74b31522 upstream. > > Currently, using synth_event_delete() will fail if the event is being > used (tracing in progress), but that is normally done in the module exit > function. At that stage, failing is problematic as returning a non-zero > status means the module will become locked (impossible to unload or > reload again). > > Instead, ensure the module exit function does not get called in the > first place by increasing the module refcnt when the event is enabled. > > Cc: stable@vger.kernel.org > Cc: Mathieu Desnoyers > Fixes: 35ca5207c2d11 ("tracing: Add synthetic event command generation functions") > Link: https://lore.kernel.org/20250318180906.226841-1-douglas.raillard@arm.com > Signed-off-by: Douglas Raillard > Acked-by: Masami Hiramatsu (Google) > Signed-off-by: Steven Rostedt (Google) > Signed-off-by: Greg Kroah-Hartman > --- > kernel/trace/trace_events_synth.c | 30 +++++++++++++++++++++++++++++- > 1 file changed, 29 insertions(+), 1 deletion(-) > > --- a/kernel/trace/trace_events_synth.c > +++ b/kernel/trace/trace_events_synth.c > @@ -852,6 +852,34 @@ static struct trace_event_fields synth_e > {} > }; > > +static int synth_event_reg(struct trace_event_call *call, > + enum trace_reg type, void *data) > +{ > + struct synth_event *event = container_of(call, struct synth_event, call); > + > + switch (type) { > + case TRACE_REG_REGISTER: > + case TRACE_REG_PERF_REGISTER: Breaks build and needs: 8eb151864273 tracing: Do not use PERF enums when perf is not defined thanks, -- js suse labs