From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Douglas Anderson <dianders@chromium.org>,
Rob Herring <robh+dt@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Matthias Kaehlcke <mka@chromium.org>,
Alexandru M Stan <amstan@chromium.org>,
patches@lists.linux.dev, linux-arm-msm@vger.kernel.org,
Julius Werner <jwerner@chromium.org>,
Andy Gross <agross@kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rajendra Nayak <quic_rjendra@quicinc.com>,
"Joseph S . Barrera III" <joebar@chromium.org>,
devicetree@vger.kernel.org, Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/5] dt-bindings: arm: qcom: Add sc7180 Chromebook board bindings
Date: Sun, 22 May 2022 09:57:18 +0200 [thread overview]
Message-ID: <7c1598a9-476d-0115-ab13-11dfa0d89436@linaro.org> (raw)
In-Reply-To: <20220520143502.v4.3.I9804fcd5d6c8552ab25f598dd7a3ea71b15b55f0@changeid>
On 20/05/2022 23:38, Douglas Anderson wrote:
> This copy-pastes compatibles from sc7180-based boards from the device
> trees to the yaml file so that `make dtbs_check` will be happy.
>
> NOTES:
> - I make no attempt to try to share an "item" for all sc7180 based
> Chromebooks. Because of the revision matching scheme used by the
> Chromebook bootloader, at times we need a different number of
> revisions listed.
> - Some of the odd entries in here (like google,homestar-rev23 or the
> fact that "Google Lazor Limozeen without Touchscreen" changed from
> sku5 to sku6) are not typos but simply reflect reality.
> - Many revisions of boards here never actually went to consumers, but
> they are still in use within various companies that were involved in
> Chromebook development. Since Chromebooks are developed with an
> "upstream first" methodology, having these revisions supported with
> upstream Linux is important. Making it easy for Chromebooks to be
> developed with an "upstream first" methodology is valuable to the
> upstream community because it improves the quality of upstream and
> gets Chromebooks supported with vanilla upstream faster.
>
> One other note here is that, though the bootloader effectively treats
> the list of compatibles in a given device tree as unordered, some
> people would prefer future boards to list higher-numbered revisions
> first in the list. Chromebooks here are not changing and typically
> list lower revisions first just to avoid churn.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> ---
>
> (no changes since v3)
>
> Changes in v3:
> - Split link to Chromebook boot doc into a separate patch.
> - Added a note to desc about revision ordering within a device tree.
>
> Changes in v2:
> - Add link to doc about how Chromebook devicetrees work.
> - Use a "description" instead of a comment for each item.
> - Use the marketing name instead of the code name where possible.
>
> .../devicetree/bindings/arm/qcom.yaml | 182 +++++++++++++++++-
> 1 file changed, 181 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 5ac28e11ea7b..01e40ea40724 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -219,11 +219,191 @@ properties:
> - qcom,ipq8074-hk10-c2
> - const: qcom,ipq8074
>
> - - items:
> + - description: Qualcomm Technologies, Inc. SC7180 IDP
> + items:
> - enum:
> - qcom,sc7180-idp
> - const: qcom,sc7180
>
> + - description: HP Chromebook x2 11c (rev1 - 2)
> + items:
> + - const: google,coachz-rev1
> + - const: google,coachz-rev2
> + - const: qcom,sc7180
> +
> + - description: HP Chromebook x2 11c (newest rev)
> + items:
> + - const: google,coachz
> + - const: qcom,sc7180
> +
> + - description: HP Chromebook x2 11c with LTE (rev1 - 2)
> + items:
> + - const: google,coachz-rev1-sku0
> + - const: google,coachz-rev2-sku0
> + - const: qcom,sc7180
> +
> + - description: HP Chromebook x2 11c with LTE (newest rev)
> + items:
> + - const: google,coachz-sku0
> + - const: qcom,sc7180
> +
> + - description: Lenovo Chromebook Duet 5 13 (rev2)
> + items:
> + - const: google,homestar-rev2
> + - const: google,homestar-rev23
> + - const: qcom,sc7180
> +
> + - description: Lenovo Chromebook Duet 5 13 (rev3)
> + items:
> + - const: google,homestar-rev3
> + - const: qcom,sc7180
> +
> + - description: Lenovo Chromebook Duet 5 13 (newest rev)
> + items:
> + - const: google,homestar
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook Spin 513 (rev0)
> + items:
> + - const: google,lazor-rev0
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook Spin 513 (rev1 - 2)
> + items:
> + - const: google,lazor-rev1
> + - const: google,lazor-rev2
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook Spin 513 (rev3 - 8)
> + items:
> + - const: google,lazor-rev3
> + - const: google,lazor-rev4
> + - const: google,lazor-rev5
> + - const: google,lazor-rev6
> + - const: google,lazor-rev7
> + - const: google,lazor-rev8
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook Spin 513 (newest rev)
> + items:
> + - const: google,lazor
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook Spin 513 with KB Backlight (rev1 - 2)
> + items:
> + - const: google,lazor-rev1-sku2
> + - const: google,lazor-rev2-sku2
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook Spin 513 with KB Backlight (rev3 - 8)
> + items:
> + - const: google,lazor-rev3-sku2
> + - const: google,lazor-rev4-sku2
> + - const: google,lazor-rev5-sku2
> + - const: google,lazor-rev6-sku2
> + - const: google,lazor-rev7-sku2
> + - const: google,lazor-rev8-sku2
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook Spin 513 with KB Backlight (newest rev)
> + items:
> + - const: google,lazor-sku2
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook Spin 513 with LTE (rev1 - 2)
> + items:
> + - const: google,lazor-rev1-sku0
> + - const: google,lazor-rev2-sku0
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook Spin 513 with LTE (rev3 - 8)
> + items:
> + - const: google,lazor-rev3-sku0
> + - const: google,lazor-rev4-sku0
> + - const: google,lazor-rev5-sku0
> + - const: google,lazor-rev6-sku0
> + - const: google,lazor-rev7-sku0
> + - const: google,lazor-rev8-sku0
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook Spin 513 with LTE (newest rev)
> + items:
> + - const: google,lazor-sku0
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook 511 (rev4 - rev8)
> + items:
> + - const: google,lazor-rev4-sku4
> + - const: google,lazor-rev5-sku4
> + - const: google,lazor-rev6-sku4
> + - const: google,lazor-rev7-sku4
> + - const: google,lazor-rev8-sku4
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook 511 (newest rev)
> + items:
> + - const: google,lazor-sku4
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook 511 without Touchscreen (rev4)
> + items:
> + - const: google,lazor-rev4-sku5
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook 511 without Touchscreen (rev5 - rev8)
> + items:
> + - const: google,lazor-rev5-sku5
> + - const: google,lazor-rev5-sku6
> + - const: google,lazor-rev6-sku6
> + - const: google,lazor-rev7-sku6
> + - const: google,lazor-rev8-sku6
> + - const: qcom,sc7180
> +
> + - description: Acer Chromebook 511 without Touchscreen (newest rev)
> + items:
> + - const: google,lazor-sku6
> + - const: qcom,sc7180
> +
> + - description: Sharp Dynabook Chromebook C1 (rev1)
> + items:
> + - const: google,pompom-rev1
> + - const: qcom,sc7180
> +
> + - description: Sharp Dynabook Chromebook C1 (rev2)
> + items:
> + - const: google,pompom-rev2
I understand why you do not share "item" (your first notes) for some of
boards, but I don't get why "google,pompom-rev1" cannot be combined with
"google,pompom-rev2". Do you see any chances to alter the bindings for
these two boards?
The same for other such cases (not newest revision).
> + - const: qcom,sc7180
> +
> + - description: Sharp Dynabook Chromebook C1 (newest rev)
> + items:
> + - const: google,pompom
> + - const: qcom,sc7180
> +
> + - description: Sharp Dynabook Chromebook C1 with LTE (rev1)
> + items:
> + - const: google,pompom-rev1-sku0
> + - const: qcom,sc7180
> +
> + - description: Sharp Dynabook Chromebook C1 with LTE (rev2)
> + items:
> + - const: google,pompom-rev2-sku0
> + - const: qcom,sc7180
> +
> + - description: Sharp Dynabook Chromebook C1 with LTE (newest rev)
> + items:
> + - const: google,pompom-sku0
> + - const: qcom,sc7180
> +
> + - description: Google Trogdor (newest rev)
> + items:
> + - const: google,trogdor
> + - const: qcom,sc7180
> +
> + - description: Google Trogdor with LTE (newest rev)
> + items:
> + - const: google,trogdor-sku0
> + - const: qcom,sc7180
> +
> - items:
> - enum:
> - qcom,sc7280-crd
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-05-22 7:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 21:38 [PATCH v4 1/5] dt-bindings: Document how Chromebooks with depthcharge boot Douglas Anderson
2022-05-20 21:38 ` [PATCH v4 2/5] dt-bindings: arm: qcom: Mention that Chromebooks use a different scheme Douglas Anderson
2022-05-22 7:54 ` Krzysztof Kozlowski
2022-05-20 21:38 ` [PATCH v4 3/5] dt-bindings: arm: qcom: Add sc7180 Chromebook board bindings Douglas Anderson
2022-05-22 7:57 ` Krzysztof Kozlowski [this message]
2022-05-23 16:16 ` Doug Anderson
2022-05-24 9:34 ` Krzysztof Kozlowski
2022-05-24 23:00 ` Doug Anderson
2022-05-20 21:38 ` [PATCH v4 4/5] dt-bindings: arm: qcom: Add / fix sc7280 " Douglas Anderson
2022-06-22 8:27 ` Krzysztof Kozlowski
2022-06-22 13:51 ` Doug Anderson
2022-05-20 21:38 ` [PATCH v4 5/5] dt-bindings: arm: qcom: Add more sc7180 Chromebook " Douglas Anderson
2022-05-22 8:01 ` Krzysztof Kozlowski
2022-05-23 16:19 ` Doug Anderson
2022-06-01 23:26 ` Rob Herring
2022-06-27 20:02 ` [PATCH v4 1/5] dt-bindings: Document how Chromebooks with depthcharge boot Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c1598a9-476d-0115-ab13-11dfa0d89436@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=amstan@chromium.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=joebar@chromium.org \
--cc=jwerner@chromium.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=patches@lists.linux.dev \
--cc=quic_rjendra@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).