Re: [PATCH] powerpc/pseries/svm: Make mem_encrypt.h self contained

[Christophe Leroy <christophe.leroy@csgroup.eu>]

Le 20/11/2025 à 16:06, Jason Gunthorpe a écrit :
> Add the missing forward declarations and includes so it does not have
> implicit dependencies. mem_encrypt.h is a public header imported by
> drivers. Users should not have to guess what include files are needed.
> 
> Resolves a kbuild splat:
> 
>     In file included from drivers/iommu/generic_pt/fmt/iommu_amdv1.c:15:
>     In file included from drivers/iommu/generic_pt/fmt/iommu_template.h:36:
>     In file included from drivers/iommu/generic_pt/fmt/amdv1.h:23:
>     In file included from include/linux/mem_encrypt.h:17:
>>> arch/powerpc/include/asm/mem_encrypt.h:13:49: warning: declaration of 'struct device' will not be visible outside of this function [-Wvisibility]
>        13 | static inline bool force_dma_unencrypted(struct device *dev)
> 
> Fixes: 879ced2bab1b ("iommupt: Add the AMD IOMMU v1 page table format")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202511161358.rS5pSb3U-lkp@intel.com/
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>

Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>

> ---
>   arch/powerpc/include/asm/mem_encrypt.h | 3 +++
>   1 file changed, 3 insertions(+)
> 
> Joerg, can you pick this up too please?
> 
> diff --git a/arch/powerpc/include/asm/mem_encrypt.h b/arch/powerpc/include/asm/mem_encrypt.h
> index 2f26b8fc8d297c..e355ca46fad933 100644
> --- a/arch/powerpc/include/asm/mem_encrypt.h
> +++ b/arch/powerpc/include/asm/mem_encrypt.h
> @@ -9,6 +9,9 @@
>   #define _ASM_POWERPC_MEM_ENCRYPT_H
>   
>   #include <asm/svm.h>
> +#include <linux/types.h>
> +
> +struct device;
>   
>   static inline bool force_dma_unencrypted(struct device *dev)
>   {
> 
> base-commit: 7e06063a43d317c1ca9278b6662555f687f43f03