From: Baolu Lu <baolu.lu@linux.intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>,
iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>,
Robin Murphy <robin.murphy@arm.com>,
Will Deacon <will@kernel.org>
Cc: baolu.lu@linux.intel.com, patches@lists.linux.dev
Subject: Re: [PATCH] iommu: Remove useless flush from iommu_create_device_direct_mappings()
Date: Mon, 21 Oct 2024 13:19:02 +0800 [thread overview]
Message-ID: <9892d0e6-554b-4c15-b012-813edc3e0427@linux.intel.com> (raw)
In-Reply-To: <0-v1-bb6c694e1b07+a29e1-iommu_no_flush_all_jgg@nvidia.com>
On 2024/10/19 1:01, Jason Gunthorpe wrote:
> These days iommu_map() does not require external flushing, it always
> internally handles any required flushes. Since
> iommu_create_device_direct_mappings() only calls iommu_map(), remove
> the extra call.
>
> Since this is the last call site for iommu_flush_iotlb_all() remove it
> too.
>
> Signed-off-by: Jason Gunthorpe<jgg@nvidia.com>
> ---
> drivers/iommu/iommu.c | 4 ----
> include/linux/iommu.h | 10 ----------
> 2 files changed, 14 deletions(-)
It's fine for the intel driver, so
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
Thanks,
baolu
next prev parent reply other threads:[~2024-10-21 5:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 17:01 [PATCH] iommu: Remove useless flush from iommu_create_device_direct_mappings() Jason Gunthorpe
2024-10-21 5:19 ` Baolu Lu [this message]
2024-10-29 8:52 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9892d0e6-554b-4c15-b012-813edc3e0427@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=patches@lists.linux.dev \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox