From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8F43389DEF; Tue, 10 Mar 2026 11:29:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773142169; cv=none; b=BRC49ImL55gnJqIAgNDHiOFlHcC0oCSCcCp/847jtDoKwDNkGZyis5rjJcNgOuV29YQfApVw3LpqjVSnWkVRg8XQCQ87OTYIlQdMdcxZIZS30Ra8cW+6+2EZKHr8H+oAuWspmaI93ibvQFLo8mznc9Y96Q2FwAEjwsoJMTjSa2Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773142169; c=relaxed/simple; bh=rtfGrCfs+MnENY0aRTRF2wfF6nliyrn8/nswJqUofi4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HN7/fRMqJtdoWJV7+ZtgFE5yHgyOPRr+dK381X+T/gFPSgZ9yF7wvALKT/8z1JCxN+etd1wqUtmFCJNdEak6MgpcHuI8ads59AcXlxreUcpYU3M/KeySJST0Ff/NovyXcyI9W7Wh4L21YxSd0r20QvKCSsbYJm0dxfU/g6fseJ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CJ/eJGuF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CJ/eJGuF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B86BC2BC86; Tue, 10 Mar 2026 11:29:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773142168; bh=rtfGrCfs+MnENY0aRTRF2wfF6nliyrn8/nswJqUofi4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CJ/eJGuFW4SdQR//5iB78RA5rcwNsaiStcLcubj2MiZP+tESTXYhcfMZU/sG2oP/G iudCupsdgHMpnScZOZmyvQosgF883LCnVulOyX051utCGRZ1kNBWsl/ljE/Xk/9DRS u/2mZQDsgJUTardk/7d7fhmZlRBVVfXRIvQ/Svm3s0VUTNMGaNBzbkmbbHDoPtnaBN jkrlJBsxCs8yreDjI6E0K2Vk/77XMXqJBWKCGrbBMtkowdoDoVOWNOIKw5d2N/qHnG I4vzK2P5nrzfSed32hB+0X7G4K2r8qGyDk1Kfxx7Zv6CUYYJ+Esb22NBvW84P5tAGk TARddLVgkJDsg== From: Sasha Levin To: patches@lists.linux.dev, stable@vger.kernel.org Cc: Lorenzo Bianconi , Johannes Berg , Sasha Levin Subject: [PATCH 6.18 257/314] wifi: mt76: Fix possible oob access in mt76_connac2_mac_write_txwi_80211() Date: Tue, 10 Mar 2026 07:18:36 -0400 Message-ID: <99457eba1385c2fb2fdfb7613f4e56cc00f4f564.1773141555.git.sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Lorenzo Bianconi [ Upstream commit 4e10a730d1b511ff49723371ed6d694dd1b2c785 ] Check frame length before accessing the mgmt fields in mt76_connac2_mac_write_txwi_80211 in order to avoid a possible oob access. Fixes: 577dbc6c656d ("mt76: mt7915: enable offloading of sequence number assignment") Signed-off-by: Lorenzo Bianconi Link: https://patch.msgid.link/20260226-mt76-addba-req-oob-access-v1-3-b0f6d1ad4850@kernel.org [fix check to also cover mgmt->u.action.u.addba_req.capab, correct Fixes tag] Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c b/drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c index 0db00efe88b0b..837bd0f136fa1 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c @@ -411,6 +411,7 @@ mt76_connac2_mac_write_txwi_80211(struct mt76_dev *dev, __le32 *txwi, u32 val; if (ieee80211_is_action(fc) && + skb->len >= IEEE80211_MIN_ACTION_SIZE + 1 + 1 + 2 && mgmt->u.action.category == WLAN_CATEGORY_BACK && mgmt->u.action.u.addba_req.action_code == WLAN_ACTION_ADDBA_REQ) { u16 capab = le16_to_cpu(mgmt->u.action.u.addba_req.capab); -- 2.51.0