From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 116143D54F for ; Sat, 10 Feb 2024 11:53:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707566009; cv=none; b=PyWYmOckRpS05xZFWTOVdl3HmxSOyhz0BxxRuVJ6blzEYUnf4pAHJprHCi069wwqwa5PUHgxQz1Mw9buUiTN2D3wZbF7gWHr1HbHI2dxA0e4zGR42vfbIjyLC67hPy6+tAQiPrTH0/sg9dzigAUSQgKrx768AoCDygQXuVpR2go= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707566009; c=relaxed/simple; bh=9bQZqD23DARa5dmQXwWYHcnI+MX2yoHshObqALvEMWE=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=bdTIAHEUYWS56XT/eVIWNjUTz+WIqsRRallNHz/hD3JTQqZ+9v4Q94mHAo5rKyTHpUJXEtY9t564Yn2OeKs97AjLoaoMvmcYoha11jh3oCHeZVdZHmbM/NMzW+LbBkcWCxl14N2LLLy7Mc8UeIuTuS+miL77SCd1vCF0EnhblJw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yQHK7Kd8; arc=none smtp.client-ip=209.85.219.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yQHK7Kd8" Received: by mail-yb1-f178.google.com with SMTP id 3f1490d57ef6-dc6c0dc50dcso1514967276.2 for ; Sat, 10 Feb 2024 03:53:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707566007; x=1708170807; darn=lists.linux.dev; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=XWXgSyVP+N1LKifAWR9rUMalj+Xn0R6HoByIzflb0PQ=; b=yQHK7Kd8f9BiMtbW5We6o057++DlSHtpY0Hty1uyyTi+kMhbWIIczB2UDweDM7uPaY kWqRf4FVHTzveF/zSjIxzpAdL1YnLRS5JnwJAHs72gdnKPuX5MhTmoKfP3w++1EPQlFi 09Y0pPbqMUjlQpfYL7fYIBQYD1twKCAhkcelhbQC2hxE02HKPANMLkcZ8h5MDXvph1XL NMutEPjwOxpwiZLduDi7wYONCNUYszn4yzX2G+vzR/H+MyYV/5bcKLYzXdR3NUnmQjUU ksvU4QR3Jsg1IgVStL6h4qQR7vha30wsf8TsIjv0NocL7zJ30AwcBrZ+cU3vtZgF7XJ9 kM0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707566007; x=1708170807; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XWXgSyVP+N1LKifAWR9rUMalj+Xn0R6HoByIzflb0PQ=; b=DyXNUfmuAAIj+KvFPRkOI+ZygfCDYUsjoLSpbjPjpw68PWqUvcecpcmVtUOK51LlPN IlVP7Ti2t8inyGDiAA1DiimoXDYtm4F7+vnHj+zLfHQYExMvpcZhdSQoYGfhNFZ167cS VpHTyOrJk/Lr9FJVXMcBCNE/bQlKBunYclKNOKdisXQ06it8k5ahrOOQ0aozBnLzM966 aIi9H97L8yfOX/zgIjam043tFLOcfR30KUJuSi1QdrKdpViO4slMm+HyBJjl8/hIgEVY S081vYfhycMHFyRkqPcxoLuDIre/KNtLhPwhGhl/fkA5OQml0JeOrdAxDwDQUFvDXJdD IrfQ== X-Gm-Message-State: AOJu0YzRHA67LbonNhd50smTzQxF/HmjQKj+JxsBpf+FEKE6cMbCzOZv ndJxmPELfem/eVxEDnOG2ryMUfUcKzr3MCe6nlRofP9CXAyVKsihSkhVQPG77QjFWLoxaMz7EjY CcD+YGUVHTJgZ9Fvpv13UZkDyQ5v1Q5uJsKtUIQ== X-Google-Smtp-Source: AGHT+IFMW08q299IizgKGdLgUOVbSLepSnMhrSOl8xiICHLdby/JMn0zC+h9YOLRZctZ72Bz13hmpDHWTJ95DQfia/Y= X-Received: by 2002:a25:8686:0:b0:dc7:47b7:6d69 with SMTP id z6-20020a258686000000b00dc747b76d69mr1199763ybk.60.1707566006887; Sat, 10 Feb 2024 03:53:26 -0800 (PST) Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240210070934.2549994-1-swboyd@chromium.org> <20240210070934.2549994-22-swboyd@chromium.org> In-Reply-To: <20240210070934.2549994-22-swboyd@chromium.org> From: Dmitry Baryshkov Date: Sat, 10 Feb 2024 13:53:16 +0200 Message-ID: Subject: Re: [PATCH 21/22] arm64: dts: qcom: sc7180-trogdor: Make clamshell/detachable fragments To: Stephen Boyd Cc: chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, patches@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Douglas Anderson , Pin-yen Lin , cros-qcom-dts-watchers@chromium.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Content-Type: text/plain; charset="UTF-8" On Sat, 10 Feb 2024 at 09:17, Stephen Boyd wrote: > > At a high-level, detachable Trogdors (sometimes known as Strongbads) > don't have a cros_ec keyboard, while all clamshell Trogdors (only known > as Trogdors) always have a cros_ec keyboard. Looking closer though, all > clamshells have a USB type-A connector and a hardwired USB camera. And > all detachables replace the USB camera with a MIPI based one and swap > the USB type-a connector for the detachable keyboard pogo pins. > > Split the detachable and clamshell bits into different files so we can > describe these differences in one place instead of in each board that > includes sc7180-trogdor.dtsi. For now this is just the keyboard part, > but eventually this will include the type-a port and the pogo pins. > > Cc: > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: Konrad Dybcio > Cc: Rob Herring > Cc: Krzysztof Kozlowski > Cc: Conor Dooley > Cc: > Cc: > Cc: Pin-yen Lin > Signed-off-by: Stephen Boyd > --- > .../boot/dts/qcom/sc7180-trogdor-clamshell.dtsi | 9 +++++++++ > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 5 +---- > .../boot/dts/qcom/sc7180-trogdor-detachable.dtsi | 12 ++++++++++++ > .../arm64/boot/dts/qcom/sc7180-trogdor-homestar.dtsi | 7 +------ > .../boot/dts/qcom/sc7180-trogdor-kingoftown.dts | 2 +- > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi | 3 +-- > arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom.dtsi | 2 +- > .../boot/dts/qcom/sc7180-trogdor-quackingstick.dtsi | 7 +------ > arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 2 +- > .../boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi | 5 +---- > 11 files changed, 30 insertions(+), 26 deletions(-) > create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-clamshell.dtsi > create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-detachable.dtsi > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry