From: Stephen Boyd <swboyd@chromium.org>
To: Hans de Goede <hdegoede@redhat.com>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Mark Gross <markgross@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev,
platform-driver-x86@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Prashant Malani <pmalani@chromium.org>
Subject: Re: [PATCH 0/3] platform/x86: intel_scu_ipc: Timeout fixes
Date: Tue, 5 Sep 2023 17:55:28 -0500 [thread overview]
Message-ID: <CAE-0n51phfrK2iMSisCb2zz+ETWx9nZ+zZ4ZS+3sPx8r3B+0RA@mail.gmail.com> (raw)
In-Reply-To: <934250db-b05f-4d48-8138-06986a14b3fb@linux.intel.com>
Quoting Kuppuswamy Sathyanarayanan (2023-08-30 20:28:57)
>
>
> On 8/30/2023 6:14 PM, Stephen Boyd wrote:
> > I recently looked at some crash reports on ChromeOS devices that call
> > into this intel_scu_ipc driver. They were hitting timeouts, and it
> > certainly looks possible for those timeouts to be triggering because of
> > scheduling issues. Once things started going south, the timeouts kept
>
> Are you talking about timeouts during IPC command?
Yes? I see messages like this
intel_scu_ipc intel_scu_ipc: IPC command 0x200a7 failed with -110
which led me to this driver and I wrote these patches based on that
failure message. I was trying to figure out how that could happen, and
it seems that it could simply be scheduling delays while nothing is
really timing out.
>
> > coming. Maybe that's because the other side got seriously confused? I
> > don't know. I'll poke at it some more by injecting timeouts on the
> > kernel side.
>
> Do you think it is possible due to a firmware issue?
I have no idea. Is there some way to figure that out? I'm not able to
reproduce the problem locally.
prev parent reply other threads:[~2023-09-05 22:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 1:14 [PATCH 0/3] platform/x86: intel_scu_ipc: Timeout fixes Stephen Boyd
2023-08-31 1:14 ` [PATCH 1/3] platform/x86: intel_scu_ipc: Check status after timeouts in busy_loop() Stephen Boyd
2023-08-31 13:53 ` Andy Shevchenko
2023-09-05 22:24 ` Stephen Boyd
2023-09-06 13:58 ` Andy Shevchenko
2023-08-31 14:15 ` Kuppuswamy Sathyanarayanan
2023-09-01 5:50 ` Mika Westerberg
2023-09-05 22:27 ` Stephen Boyd
2023-09-06 13:46 ` Andy Shevchenko
2023-09-06 14:31 ` Mika Westerberg
2023-08-31 1:14 ` [PATCH 2/3] platform/x86: intel_scu_ipc: Check status upon timeout in ipc_wait_for_interrupt() Stephen Boyd
2023-08-31 13:58 ` Andy Shevchenko
2023-09-05 22:36 ` Stephen Boyd
2023-08-31 14:27 ` Kuppuswamy Sathyanarayanan
2023-09-05 22:56 ` Stephen Boyd
2023-09-01 6:04 ` Mika Westerberg
2023-08-31 1:14 ` [PATCH 3/3] platform/x86: intel_scu_ipc: Fail IPC send if still busy Stephen Boyd
2023-08-31 14:07 ` Andy Shevchenko
2023-09-01 6:06 ` Mika Westerberg
2023-09-05 22:42 ` Stephen Boyd
2023-08-31 3:28 ` [PATCH 0/3] platform/x86: intel_scu_ipc: Timeout fixes Kuppuswamy Sathyanarayanan
2023-09-05 22:55 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE-0n51phfrK2iMSisCb2zz+ETWx9nZ+zZ4ZS+3sPx8r3B+0RA@mail.gmail.com \
--to=swboyd@chromium.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=patches@lists.linux.dev \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pmalani@chromium.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).