From: Stephen Boyd <swboyd@chromium.org>
To: Guenter Roeck <groeck@google.com>
Cc: Benson Leung <bleung@chromium.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
patches@lists.linux.dev, Guenter Roeck <groeck@chromium.org>,
chrome-platform@lists.linux.dev,
Evan Green <evgreen@chromium.org>,
Rajat Jain <rajatja@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
Hsin-Yi Wang <hsinyi@chromium.org>
Subject: Re: [PATCH] platform/chrome: cros_ec: Always expose last resume result
Date: Fri, 10 Jun 2022 23:17:41 -0700 [thread overview]
Message-ID: <CAE-0n53HdS+tQJXQ303kofKBeCbj1K8hf9RTSnguLJbPY7FtxA@mail.gmail.com> (raw)
In-Reply-To: <CABXOdTfvuHLf=ahN4+iOewyLCNnOZMXS-S+4a_RUtLCC=9t_HA@mail.gmail.com>
Quoting Guenter Roeck (2022-06-10 18:40:33)
> On Fri, Jun 10, 2022 at 3:37 PM Stephen Boyd <swboyd@chromium.org> wrote:
> > diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c
> > index b3e94cdf7d1a..881d3ad09be0 100644
> > --- a/drivers/platform/chrome/cros_ec.c
> > +++ b/drivers/platform/chrome/cros_ec.c
> > @@ -135,10 +135,10 @@ static int cros_ec_sleep_event(struct cros_ec_device *ec_dev, u8 sleep_event)
> > buf.msg.command = EC_CMD_HOST_SLEEP_EVENT;
> >
> > ret = cros_ec_cmd_xfer_status(ec_dev, &buf.msg);
> > -
> > - /* For now, report failure to transition to S0ix with a warning. */
> > + /* Report failure to transition to system wide suspend with a warning. */
> > if (ret >= 0 && ec_dev->host_sleep_v1 &&
> > - (sleep_event == HOST_SLEEP_EVENT_S0IX_RESUME)) {
> > + (sleep_event == HOST_SLEEP_EVENT_S0IX_SUSPEND ||
> > + sleep_event == HOST_SLEEP_EVENT_S3_RESUME)) {
>
> I am sure I am missing something, but the description doesn't explain
> (to me) the switch from HOST_SLEEP_EVENT_S0IX_RESUME to
> HOST_SLEEP_EVENT_S0IX_SUSPEND.
You didn't miss anything.
prev parent reply other threads:[~2022-06-11 6:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 22:37 [PATCH] platform/chrome: cros_ec: Always expose last resume result Stephen Boyd
2022-06-11 1:40 ` Guenter Roeck
2022-06-11 6:17 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE-0n53HdS+tQJXQ303kofKBeCbj1K8hf9RTSnguLJbPY7FtxA@mail.gmail.com \
--to=swboyd@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=evgreen@chromium.org \
--cc=groeck@chromium.org \
--cc=groeck@google.com \
--cc=hsinyi@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=patches@lists.linux.dev \
--cc=rajatja@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).