From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03EF67E3 for ; Sat, 11 Jun 2022 06:17:42 +0000 (UTC) Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-f2a4c51c45so1836834fac.9 for ; Fri, 10 Jun 2022 23:17:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=za02L3YGkMaQDDqUxwbazqy5dmLqsmTNruFmOVnXHLs=; b=ZhUYo+ec7/hRaGq7h5hPPUEOc8eNxo/1WQo+0mOKo2xGedoXSmfYbZXJUkz/QAf2y0 SOKzhXharIFEs6ZHKTsX8zADjjUXfSGIWOBLzcpDzmFYryj0jOnQvGMnTMIg7YkWDH99 gvu6xhUppNiQ9j1FX8G+hmOtzD/DekoTETyTY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=za02L3YGkMaQDDqUxwbazqy5dmLqsmTNruFmOVnXHLs=; b=BaXZ1onAIsbsZQAHp231j5JVS4ZoLEHIS2hziunj7hdrOw5zgQO7RIq5tQwn6dRzE1 uCzeWWsVXRDmZNJsOmpB5y2dg/eifZUzWPVux7T3xuA5dAdSDrT0SCbqhcIUUA41k34C 6awGHJmEjPga3TPkPhWkDm9zsO8VSuasUmEEp3zEcMs8p/JPA1MNeYBxiiWEpd/Ka/Hu Ab+JKq4EtFq+SxxK9Svi1siZdoNcj30uNBivfik2TTTUCDgHgn4MPn0uBWtO75b9PJNE AU1yMjZezVs+NDLAYxfBrAlYdAvWhLlAd4LO4N5o+cRvmlTAFpgHZZ9EU9mOPx4JVIPz CWWg== X-Gm-Message-State: AOAM530qZNkOgddtXVdJf2cAIQgUiIxqOe4R9oJ1ZJkKVTGAOczgZ4P+ Vze/fCvZCsAj+SM8JD/Xuczx14yijk/wUhIW/XUWAw== X-Google-Smtp-Source: ABdhPJwP+GegoajQ2DsSTYfMWKmwk/n7FeyvsXDY8wjEV6aAE58scWTyKz/7+YfwZzIqWA8nVvUVOaFqHBibIaaaBHA= X-Received: by 2002:a05:6870:b381:b0:fe:2004:b3b5 with SMTP id w1-20020a056870b38100b000fe2004b3b5mr1885317oap.63.1654928262086; Fri, 10 Jun 2022 23:17:42 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 10 Jun 2022 23:17:41 -0700 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: References: <20220610223703.3387691-1-swboyd@chromium.org> From: Stephen Boyd User-Agent: alot/0.10 Date: Fri, 10 Jun 2022 23:17:41 -0700 Message-ID: Subject: Re: [PATCH] platform/chrome: cros_ec: Always expose last resume result To: Guenter Roeck Cc: Benson Leung , linux-kernel , patches@lists.linux.dev, Guenter Roeck , chrome-platform@lists.linux.dev, Evan Green , Rajat Jain , Matthias Kaehlcke , Hsin-Yi Wang Content-Type: text/plain; charset="UTF-8" Quoting Guenter Roeck (2022-06-10 18:40:33) > On Fri, Jun 10, 2022 at 3:37 PM Stephen Boyd wrote: > > diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c > > index b3e94cdf7d1a..881d3ad09be0 100644 > > --- a/drivers/platform/chrome/cros_ec.c > > +++ b/drivers/platform/chrome/cros_ec.c > > @@ -135,10 +135,10 @@ static int cros_ec_sleep_event(struct cros_ec_device *ec_dev, u8 sleep_event) > > buf.msg.command = EC_CMD_HOST_SLEEP_EVENT; > > > > ret = cros_ec_cmd_xfer_status(ec_dev, &buf.msg); > > - > > - /* For now, report failure to transition to S0ix with a warning. */ > > + /* Report failure to transition to system wide suspend with a warning. */ > > if (ret >= 0 && ec_dev->host_sleep_v1 && > > - (sleep_event == HOST_SLEEP_EVENT_S0IX_RESUME)) { > > + (sleep_event == HOST_SLEEP_EVENT_S0IX_SUSPEND || > > + sleep_event == HOST_SLEEP_EVENT_S3_RESUME)) { > > I am sure I am missing something, but the description doesn't explain > (to me) the switch from HOST_SLEEP_EVENT_S0IX_RESUME to > HOST_SLEEP_EVENT_S0IX_SUSPEND. You didn't miss anything.