From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2F001946AA for ; Thu, 5 Sep 2024 08:10:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725523857; cv=none; b=Cu/brym8HBOCnYJARDPfnARFBkIhTfaispCx8tOcaOlo2lGAcwHBEXCmRsbs8g165k/n8HfJxrGjMF6GCFNES2iDdgbGPDb/Vi4MLrDLijb4pH5rrjTH6QE88qz3V6mMh7cSu5lbxgcuridoPRkJqI5ElW9w4KQNtdMXNGSFVa4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725523857; c=relaxed/simple; bh=qvUtuea05V6qpDBt2oe0KDZfHbwdwIfCyNjizCTTsKY=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=bPoxVgcPCbfNjkVYsPSlQ0mkZmPWLDmT2UxkXRp2nZlCDX4/tK95mB8K0pjM3ZKU4u1bYTOZ+5PGSAt7uSk1S26f2k5tmg3Y65Nn+D+pbzsl4ANrpPUg5imXhIQAuzNABILfpaYUIwv2YqwHjJCIORFxAWuWKailx4RQkeQSdEA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=0Xo0xvrL; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="0Xo0xvrL" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3787f30d892so254377f8f.0 for ; Thu, 05 Sep 2024 01:10:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1725523854; x=1726128654; darn=lists.linux.dev; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qvUtuea05V6qpDBt2oe0KDZfHbwdwIfCyNjizCTTsKY=; b=0Xo0xvrLjlCGotKi67nYb4J2wViyLHRSPAAi5bD02jWa9jL8QmL1VAJtic+pnqf3du sJQO7bX8DUGsUTQMhgwGdAhkoBOQVOTnhL62XiFOFpbyMAfSL9qTmpTZ2UQhyKpBmkid oT4FG3mslm+OqYjJKcB/7pJcExodDtmO/4ROvhKZqzyKpcV/aIlQaozDeKUiAgvBrOYj ckcVJRX/lXnOlDLLigIsEgqDuss0ReY0OPtEXXJLkDzRf9WL0axZMxe5YyNcOhcpAI/M aSsOz/aEd5+9ka9spiJ0eVeJ9zW3OtwFtRup9wSq+NLyPrwS4ZXmOztvIBVxVeLCC940 7S1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725523854; x=1726128654; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qvUtuea05V6qpDBt2oe0KDZfHbwdwIfCyNjizCTTsKY=; b=gM4yJgvzYEy0kQPsaORO6ftX1r7Fmba1SFLV3Qyl5UVq3DJkPJydgtXKZ8zw+0jcts TLPEiqPyRPY94M1AmYKXUYatjCl1EgvJbwLyC/8J3/Fx+wyAl/M+2PvKjFPf3STVM/kI RZd0b+IFy6b1NjIlGPKFlrBrdrW6We4gxU+6tEpi3BNjuJYx4tzLQgOBz04SMwYx1hQI vt6pCUuWFAcjb/blZzKBt4bpbuDFQi8wV5FnNpX1N8xILXr40HWGp8jqFOD5sb1+bT1X L6YczYEovmRdzJiz09MkTrqn/aT5Z/HcerZu4RpOX7O1zx3ZmIsSifNFZJkIInoWRGDS Y4Tg== X-Forwarded-Encrypted: i=1; AJvYcCVvzHkhKN+rZn7dyMEcKXl1eUmWrobuCEnRzbI80DF2YFzxN7UJjXpWGcbeV5AlI/M8DwlqQU18@lists.linux.dev X-Gm-Message-State: AOJu0Yybe03l8KBK+AASV1Bp7T0HfM/f6zemGwsCWRP4gOG7a/xW2Jft zugAknWQMfP8IPw16MfuarUiLEC7uq7S9fT8TEEbd9SQj2fy0wmSpQmFfQgUZQ1gvhGGw0AAuVa iI57+ewKfJ8p7ynLIVqvwE8OXk+q9hT+eWDxq X-Google-Smtp-Source: AGHT+IGfQnv/7eMNeNLrFaPjeyN14SUVsxlIgWd7D4uZKrPENQ9PlDRsjJlnUzvNYsFrUT1h9gvgun7V/HGRHxTT+m8= X-Received: by 2002:a05:6000:178d:b0:374:af19:7992 with SMTP id ffacd0b85a97d-374bef397c9mr14232382f8f.7.1725523853771; Thu, 05 Sep 2024 01:10:53 -0700 (PDT) Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240904204347.168520-1-ojeda@kernel.org> <20240904204347.168520-11-ojeda@kernel.org> In-Reply-To: <20240904204347.168520-11-ojeda@kernel.org> From: Alice Ryhl Date: Thu, 5 Sep 2024 10:10:40 +0200 Message-ID: Subject: Re: [PATCH 10/19] rust: sync: remove unneeded `#[allow(clippy::non_send_fields_in_send_ty)]` To: Miguel Ojeda Cc: Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Sep 4, 2024 at 10:45=E2=80=AFPM Miguel Ojeda wro= te: > > Rust 1.58.0 (before Rust was merged into the kernel) made Clippy's > `non_send_fields_in_send_ty` lint part of the `suspicious` lint group for > a brief window of time [1] until the minor version 1.58.1 got released > a week after, where the lint was moved back to `nursery`. > > By that time, we had already upgraded to that Rust version, and thus we > had `allow`ed the lint here for `CondVar`. > > Nowadays, Clippy's `non_send_fields_in_send_ty` would still trigger here > if it were enabled. > > Moreover, if enabled, `Lock` and `Task` would also require an > `allow`. Therefore, it does not seem like someone is actually enabling it > (in, e.g., a custom flags build). > > Finally, the lint does not appear to have had major improvements since > then [2]. > > Thus remove the `allow` since it is unneeded. > > Link: https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1= 581-2022-01-20 [1] > Link: https://github.com/rust-lang/rust-clippy/issues/8045 [2] > Signed-off-by: Miguel Ojeda Reviewed-by: Alice Ryhl