From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4D763D86 for ; Thu, 2 Jun 2022 21:11:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39D20C341C4 for ; Thu, 2 Jun 2022 21:11:02 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="J3QEqc4/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1654204258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tUmPQIJUL4+NtOzBFIJo7+QbnFFXVwwaSJN2qOuZG+s=; b=J3QEqc4/7f/oCewQMUXIA7sGO4TxpQpUWqpatExzE7amuYnSgqxHDmbatojLvKJxulbS9H q0lAQ4JaKCIoH0h8XH4LFSQgcm8Mn5rm8/9PeikipA3+3Nu4h7K5tU3U7FH2PoHRA44x5B ILr5afDyrDPj9COwCq088KMmNT+y2KM= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 7b857f47 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for ; Thu, 2 Jun 2022 21:10:58 +0000 (UTC) Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-30fdbe7467cso29202307b3.1 for ; Thu, 02 Jun 2022 14:10:57 -0700 (PDT) X-Gm-Message-State: AOAM5306tKPbSsV0f11AyLfYoiOTKPFcxNiJ5ZWaIM/oMkXyqyftXskE CnV4/8kAw+PDr0TIF0fAKo3bjIYYAk8aHrO3s5g= X-Google-Smtp-Source: ABdhPJz4aD5dVJBqZ1Vb7U2MlE3y+pqqnB+n0yW1keIUBWEPiO6NL2LyPnAEVK8FLPA5ZsxQE2sPyJvRTPY1zWHo2bI= X-Received: by 2002:a0d:ef03:0:b0:2fa:245:adf3 with SMTP id y3-20020a0def03000000b002fa0245adf3mr8030036ywe.100.1654204256504; Thu, 02 Jun 2022 14:10:56 -0700 (PDT) Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20220602022109.780348-1-swboyd@chromium.org> <165419885870.2681883.10934677413962491141.b4-ty@arm.com> In-Reply-To: From: "Jason A. Donenfeld" Date: Thu, 2 Jun 2022 23:10:45 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arm64: Initialize jump labels before setup_machine_fdt() To: Catalin Marinas Cc: Stephen Boyd , Will Deacon , Dominik Brodowski , Ard Biesheuvel , linux-arm-kernel , LKML , Douglas Anderson , Hsin-Yi Wang , Steven Rostedt , patches@lists.linux.dev, Greg Kroah-Hartman Content-Type: text/plain; charset="UTF-8" +Greg Hi Catalin, On Thu, Jun 2, 2022 at 11:08 PM Catalin Marinas wrote: > > On Thu, Jun 02, 2022 at 10:18:04PM +0200, Jason A. Donenfeld wrote: > > On Thu, Jun 2, 2022 at 9:46 PM Catalin Marinas wrote: > > > On Thu, Jun 02, 2022 at 09:42:49PM +0200, Jason A. Donenfeld wrote: > > > > On Thu, Jun 2, 2022 at 9:41 PM Catalin Marinas wrote: > > > > > On Wed, 1 Jun 2022 19:21:09 -0700, Stephen Boyd wrote: > > > > > > A static key warning splat appears during early boot on arm64 systems > > > > > > that credit randomness from devicetrees that contain an "rng-seed" > > > > > > property. This is because setup_machine_fdt() is called before > > > > > > jump_label_init() during setup_arch(). Let's swap the order of these two > > > > > > calls so that jump labels are initialized before the devicetree is > > > > > > unflattened and the rng seed is credited. > > > > > > > > > > > > [...] > > > > > > > > > > Applied to arm64 (for-next/core), thanks! > > > > > > > > > > [1/1] arm64: Initialize jump labels before setup_machine_fdt() > > > > > https://git.kernel.org/arm64/c/73e2d827a501 > > > > > > > > I'm not sure precisely what your for-next tag corresponds to, but just > > > > FYI, this should probably go into 5.19 asap and be marked for stable@. > > > > > > The for-next/core branch should go in 5.19-rc1 (I'll send a pull request > > > tomorrow). There's no need to cc stable since the fixed commit just went > > > in (unless you mean something else by "marked for stable"). > > > > It is actually in stable, so please do CC. Otherwise I'll just forward manually. > > Ah, I didn't know this (the fixed commit doesn't have a cc stable > either). So please forward it manually once Linus pulls it. Will do. Jason