From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 436357C
	for <patches@lists.linux.dev>; Wed, 15 Feb 2023 11:41:58 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6EEC5C433EF;
	Wed, 15 Feb 2023 11:41:57 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1676461317;
	bh=SWJlG8P6p6sS5hqYjQmZBGBDQEFTQITPRH6dSryBgpw=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=YScuwj+rpZ+NvsZH0JsuUlQ+5HNXT5EBVkV4j80X9GAFlSMZqMEtQPElrt6fLkWh7
	 K7J3u6WZAB/y8WGYiEoY8YfsHWvA4GTG+OfAnOgygs6t6MCJ4/Pc7xlkV7CBiUnZDh
	 OBe1ejWe0KJp/SaiLKWO0kw7d0o0IDl5UI0XTGpY=
Date: Wed, 15 Feb 2023 12:41:55 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: heyuqiang <heyuqiang1@huawei.com>
Cc: anshuman.khandual@arm.com, catalin.marinas@arm.com, james.morse@arm.com,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	patches@lists.linux.dev, stable@vger.kernel.org, will@kernel.org,
	yuzenghui@huawei.com, nixiaoming@huawei.com, lijiahuan5@huawei.com
Subject: Re: [PATCH 5.10 88/91] arm64/kexec: Test page size support with new
 TGRAN range values
Message-ID: <Y+zFA1JuAcjhAogm@kroah.com>
References: <e1daca8f-46d5-d5b0-8152-23b172d5e63a@huawei.com>
Precedence: bulk
X-Mailing-List: patches@lists.linux.dev
List-Id: <patches.lists.linux.dev>
List-Subscribe: <mailto:patches+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:patches+unsubscribe@lists.linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <e1daca8f-46d5-d5b0-8152-23b172d5e63a@huawei.com>

On Wed, Feb 15, 2023 at 06:58:13PM +0800, heyuqiang wrote:
> There is an error
> 
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
> master
> head: c911f03f8d444e623724fddd82b07a7e1af42338
> commit: d5924531dd8ad012ad13eb4d6a5e120c3dadfc05 arm64/kexec: Test page size
> support with new TGRAN range values
> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d5924531dd8ad012ad13eb4d6a5e120c3dadfc05
> 
> When I compile the ko file, I add [-Werror=type-limits] compilation options,
> an error is reported during compilation.

Why add that option?  Is that a valid option for the 5.10.y kernel?  Is
this something new?

And note, you are responding to a commit from last November, with no
context at all.  Is this an issue in Linus's tree too?

> 
> The log is as follows:
> 
> ./arch/arm64/include/asm/cpufeature.h: In function
> ‘system_supports_4kb_granule’:
> ./arch/arm64/include/asm/cpufeature.h:653:14: error:
> comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
> return (val >= ID_AA64MMFR0_TGRAN4_SUPPORTED_MIN) &&
> ^~
> ./arch/arm64/include/asm/cpufeature.h: In function
> ‘system_supports_64kb_granule’:
> ./arch/arm64/include/asm/cpufeature.h:666:14: error:
> comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
> return (val >= ID_AA64MMFR0_TGRAN64_SUPPORTED_MIN) &&
> ^~
> 
> "val" variable type is "u32"
> "#define ID_AA64MMFR0_TGRAN4_SUPPORTED_MIN 0x0"
> "#define ID_AA64MMFR0_TGRAN64_SUPPORTED_MIN 0x0"
> comparison of val >= 0 is always true.
> 
> If you fix the issue, kindly add following tag where applicable
> Reported-by: heyuqiang <heyuqiang1@huawei.com>

Please provide a valid fix for this if you wish for it to be resolved.

thanks,

greg k-h