From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 083B963CC for ; Sat, 12 Nov 2022 19:28:21 +0000 (UTC) Received: from zn.tnic (p200300ea9733e71c329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e71c:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 151301EC054C; Sat, 12 Nov 2022 20:28:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1668281300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tpzQEeIzmJRMT71EzOyuzjEYJH59V57qil9eRYR5was=; b=gpJ1QdlsFW7DzD9zpQqhGQMdTgtqK1zVwI61F9UNacHLRApDLrjNJdzq3bhI3gP6+SMTDC nSUY3guIJ6IAINhmmZL0EhQnQ2YhIri1xq1OOdCQIbfbTqczHZZ5QqEmYDKUV8f+PPkt56 cxTM1MTW8zFS52smAuSy7QLnxN7ktEg= Date: Sat, 12 Nov 2022 20:28:19 +0100 From: Borislav Petkov To: "Luck, Tony" Cc: "Joseph, Jithu" , "hdegoede@redhat.com" , "markgross@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "gregkh@linuxfoundation.org" , "Raj, Ashok" , "linux-kernel@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , "patches@lists.linux.dev" , "Shankar, Ravi V" , "Macieira, Thiago" , "Jimenez Gonzalez, Athenas" , "Mehta, Sohil" Subject: Re: [PATCH v2 12/14] platform/x86/intel/ifs: Add current_batch sysfs entry Message-ID: References: <20221021203413.1220137-1-jithu.joseph@intel.com> <20221107225323.2733518-1-jithu.joseph@intel.com> <20221107225323.2733518-13-jithu.joseph@intel.com> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sat, Nov 12, 2022 at 06:33:58PM +0000, Luck, Tony wrote: > We tried the full file name in an earlier version. GregKH was > unimpressed. But that was when we were trying to overload the meaning > of the “reload” file. I'm guessing the background of his lack of "impressiveness" was something along the lines of: "Attributes should be ASCII text files, preferably with only one value per file. It is noted that it may not be efficient to contain only one value per file, so it is socially acceptable to express an array of values of the same type." Question is, is a filename string one value per file or strings don't count? Suspend allows it: # echo "shutdown" > /sys/power/disk # echo "disk" > /sys/power/state Btw, do you guys really want to run this in production? As in, are you really that confident that all those test sequence executions really do not affect other CPU execution at all? Because if this is going to be run during downtime, as Thiago says, then you can just as well use debugfs for this. And then there's no need to cast any API in stone and so on. Hmmm. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette