From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"patches@lists.linux.dev" <patches@lists.linux.dev>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
Carlos O'Donell <carlos@redhat.com>
Subject: Re: [PATCH v4 2/3] random: introduce generic vDSO getrandom() implementation
Date: Sat, 19 Nov 2022 13:12:08 +0100 [thread overview]
Message-ID: <Y3jIGFRiMMsd/ZDI@zx2c4.com> (raw)
In-Reply-To: <Y3jBY4p2hEKDaUm+@zx2c4.com>
On Sat, Nov 19, 2022 at 12:43:31PM +0100, Jason A. Donenfeld wrote:
> On Sat, Nov 19, 2022 at 07:51:21AM +0000, Christophe Leroy wrote:
> >
> >
> > Le 19/11/2022 à 01:04, Jason A. Donenfeld a écrit :
> > > On Sat, Nov 19, 2022 at 12:55:02AM +0100, Jason A. Donenfeld wrote:
> > >> Sorry if I'm a bit slow here to grok what's up.
> >
> > Maybe I should also have mentionned commit ce7d8056e38b ("powerpc/vdso:
> > Prepare for switching VDSO to generic C implementation.") for you to
> > have a complete picture.
> >
> > >
> > > Okay, I think I see it now. That's a complicated patch for a simple idea
> > > because gettime is more complicated than getrandom. I suspect what you
> > > want is something like the below, correct? Seems easy enough.
> >
> > Yes it is exactly that, powerpc will then call __cvdso_getrandom_data()
> > directly and pass rng_info pointer.
>
> Okay, I'll do that and send out a v+1.
Alright, new series posted here, with those changes. Let me know if that
is workable for you. Since a lot of the vDSO is tied up (currently) with
timekeeping stuff, it's a bit tricky adding things to it like this. I've
done the best I can to keep it clean and such, but if you want to play
around with wiring up powerpc, that might prove to be an interesting
exercise in shaking out inconsistencies. New series is here:
https://lore.kernel.org/lkml/20221119120929.2963813-1-Jason@zx2c4.com/T
Jason
next prev parent reply other threads:[~2022-11-19 12:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 17:28 [PATCH v4 0/3] implement getrandom() in vDSO Jason A. Donenfeld
2022-11-18 17:28 ` [PATCH v4 1/3] random: add vgetrandom_alloc() syscall Jason A. Donenfeld
2022-11-19 0:20 ` Jason A. Donenfeld
2022-11-18 17:28 ` [PATCH v4 2/3] random: introduce generic vDSO getrandom() implementation Jason A. Donenfeld
2022-11-18 19:34 ` Christophe Leroy
2022-11-18 23:55 ` Jason A. Donenfeld
2022-11-19 0:04 ` Jason A. Donenfeld
2022-11-19 7:51 ` Christophe Leroy
2022-11-19 11:43 ` Jason A. Donenfeld
2022-11-19 12:12 ` Jason A. Donenfeld [this message]
2022-11-18 17:28 ` [PATCH v4 3/3] x86: vdso: Wire up getrandom() vDSO implementation Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3jIGFRiMMsd/ZDI@zx2c4.com \
--to=jason@zx2c4.com \
--cc=adhemerval.zanella@linaro.org \
--cc=carlos@redhat.com \
--cc=christophe.leroy@csgroup.eu \
--cc=gregkh@linuxfoundation.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox