From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 604747B for ; Fri, 2 Dec 2022 11:49:18 +0000 (UTC) Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id CFD5F1C09FE; Fri, 2 Dec 2022 12:49:09 +0100 (CET) Date: Fri, 2 Dec 2022 12:49:09 +0100 From: Pavel Machek To: Greg Kroah-Hartman , mlevitsk@redhat.com, samuel.thibault@ens-lyon.org, pawell@cadence.com Cc: stable@vger.kernel.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com, f.fainelli@gmail.com, sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de Subject: Re: [PATCH 5.10 000/162] 5.10.157-rc1 review Message-ID: References: <20221130180528.466039523@linuxfoundation.org> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bpIs/ozp+cN40TDf" Content-Disposition: inline In-Reply-To: <20221130180528.466039523@linuxfoundation.org> --bpIs/ozp+cN40TDf Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! [If I cc-ed you, you are author of one of patches below. Please take a look.] > Responses should be made by Fri, 02 Dec 2022 18:05:05 +0000. > Anything received after that time might be too late. I hope to make it :-). I > Pawel Laszczak > usb: cdnsp: Device side header file for CDNSP driver >=20 > Pawel Laszczak > usb: cdns3: Add support for DRD CDNSP These two together are 1500+ lines, and are marked as Stable-dep-of: 9d5333c93134 ("usb: cdns3: host: fix endless superspeed hub port reset") . But we don't have that one in 5.10 tree. Likely we should not have these either. > Maxim Levitsky > KVM: x86: emulator: update the emulation mode after rsm No. The patch does not do anything. Mainline commit this referenced changed the return value, this changes just a comment. Wrong backport? > Samuel Thibault > speakup: Generate speakupmap.h automatically Ok, so this one rewrites some header generation and is buggy. 500+ lines. > =C4=90o=C3=A0n Tr=E1=BA=A7n C=C3=B4ng Danh > speakup: replace utils' u_char with unsigned char With this patch fixing it. The rewrite is marked as stable depedncency of the fix, but fix would not be needed if we did not apply the rewrite. We should not have these two in stable. Best regards, Pavel --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --bpIs/ozp+cN40TDf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCY4nmNQAKCRAw5/Bqldv6 8slCAJ9szYXOohy0lnupI0Mkyz6PA/P5VQCeJJG/B7MCigs9ur+cypbg+M7O2us= =EERt -----END PGP SIGNATURE----- --bpIs/ozp+cN40TDf--