From: Borislav Petkov <bp@alien8.de>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Smita Koralahalli Channabasappa
<smita.koralahallichannabasappa@amd.com>,
Wei Huang <wei.huang2@amd.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
patches@lists.linux.dev
Subject: Re: [PATCH v2 0/6] PPIN (Protected Processor Inventory Number) updates
Date: Mon, 31 Jan 2022 19:18:46 +0100 [thread overview]
Message-ID: <YfgoBgwgfoiKkPa9@zn.tnic> (raw)
In-Reply-To: <YfgbCFNeNEkypCmC@agluck-desk2.amr.corp.intel.com>
On Mon, Jan 31, 2022 at 09:23:20AM -0800, Luck, Tony wrote:
> I'm worried that some future thing might reverse that and have
> a "package" id for each die in a multi-die package which still
> appears as a single node. That would distort the meaning of "package",
> so it isn't supposed to happen. But if it did, Linux would be stuck
> just reporting one of the "package" ids.
Hmm, so we write that we don't really care about the physical socket in
software:
Documentation/x86/topology.rst:
"The kernel does not care about the concept of physical sockets because
a socket has no relevance to software. It's an electromechanical
component. In the past a socket always contained a single package
(see below), but with the advent of Multi Chip Modules (MCM) a socket
can hold more than one package. So there might be still references to
sockets in the code, but they are of historical nature and should be
cleaned up."
and the PPIN is a physical socket property. So there's no proper way for
us to tie to anything that represents the physical socket.
So, the use case you're imagining would be, what?
The FRU code glue would go:
"I got an MCE on CPU X...
Lemme see which PPIN is it:
# cat /sys/devices/system/cpu/cpuX/topology/ppin
BLA
ah ok, lemme report it:
You just had an MCE on CPU X, socket BLA"
Something like that?
But that FRU glue software would have to run as root so that it reads
the ppin sysfs file.
But we don't want to expose that processor serial number to !root users
so we're forcing the people to run the FRU thing as root.
This feels like this guy here:
https://c.tenor.com/fDZOE4okO3EAAAAC/homer-simpsons.gif
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-01-31 18:18 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 22:54 [PATCH 0/5] PPIN (Protected Processor Inventory Number) updates Tony Luck
2022-01-07 22:54 ` [PATCH 1/5] x86/ras: Merge Intel and AMD ppin_init() functions Tony Luck
2022-01-18 20:02 ` Borislav Petkov
2022-01-18 21:03 ` Luck, Tony
2022-01-18 21:15 ` Borislav Petkov
2022-01-07 22:54 ` [PATCH 2/5] x86/ras: X86_FEATURE_INTEL_PPIN finally has a CPUID bit Tony Luck
2022-01-20 13:32 ` Borislav Petkov
2022-01-07 22:54 ` [PATCH 3/5] x86/ras: Read/save PPIN MSR during initialization Tony Luck
2022-01-07 22:54 ` [PATCH 4/5] x86/sysfs: Add format parameter to macro defining "show" functions for proc Tony Luck
2022-01-20 13:32 ` Borislav Petkov
2022-01-07 22:54 ` [PATCH 5/5] x86/sysfs: Add PPIN in sysfs under cpu topology Tony Luck
2022-01-20 13:35 ` Borislav Petkov
2022-01-20 18:01 ` Luck, Tony
2022-01-20 22:48 ` Borislav Petkov
2022-01-21 17:47 ` [PATCH v2 0/6] PPIN (Protected Processor Inventory Number) updates Tony Luck
2022-01-21 17:47 ` [PATCH v2 1/6] x86/cpu: Add Xeon Icelake-D to list of CPUs that support PPIN Tony Luck
2022-01-21 17:47 ` [PATCH v2 2/6] x86/cpu: Merge Intel and AMD ppin_init() functions Tony Luck
2022-01-27 10:22 ` Borislav Petkov
2022-01-27 16:52 ` Luck, Tony
2022-01-21 17:47 ` [PATCH v2 3/6] x86/cpu: X86_FEATURE_INTEL_PPIN finally has a CPUID bit Tony Luck
2022-01-21 17:47 ` [PATCH v2 4/6] x86/cpu: Read/save PPIN MSR during initialization Tony Luck
2022-01-21 17:47 ` [PATCH v2 5/6] topology/sysfs: Add format parameter to macro defining "show" functions for proc Tony Luck
2022-01-31 11:34 ` Greg Kroah-Hartman
2022-01-21 17:47 ` [PATCH v2 6/6] topology/sysfs: Add PPIN in sysfs under cpu topology Tony Luck
2022-01-31 11:35 ` Greg Kroah-Hartman
2022-01-31 12:31 ` [PATCH v2 0/6] PPIN (Protected Processor Inventory Number) updates Borislav Petkov
2022-01-31 17:23 ` Luck, Tony
2022-01-31 18:18 ` Borislav Petkov [this message]
2022-01-31 18:49 ` Luck, Tony
2022-01-31 19:10 ` Borislav Petkov
2022-01-31 19:29 ` Luck, Tony
2022-01-31 21:58 ` Borislav Petkov
2022-01-31 22:03 ` Luck, Tony
2022-04-06 22:01 ` [PATCH] topology/sysfs: Hide PPIN on systems that do not support it Tony Luck
2022-04-25 22:46 ` Andrew Morton
2022-04-25 22:56 ` Luck, Tony
2022-01-31 23:01 ` [PATCH v3 0/5] PPIN (Protected Processor Inventory Number) updates Tony Luck
2022-01-31 23:01 ` [PATCH v3 1/5] x86/cpu: Merge Intel and AMD ppin_init() functions Tony Luck
2022-01-31 23:01 ` [PATCH v3 2/5] x86/cpu: X86_FEATURE_INTEL_PPIN finally has a CPUID bit Tony Luck
2022-01-31 23:01 ` [PATCH v3 3/5] x86/cpu: Read/save PPIN MSR during initialization Tony Luck
2022-01-31 23:01 ` [PATCH v3 4/5] topology/sysfs: Add format parameter to macro defining "show" functions for proc Tony Luck
2022-01-31 23:01 ` [PATCH v3 5/5] topology/sysfs: Add PPIN in sysfs under cpu topology Tony Luck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfgoBgwgfoiKkPa9@zn.tnic \
--to=bp@alien8.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=smita.koralahallichannabasappa@amd.com \
--cc=thomas.lendacky@amd.com \
--cc=tony.luck@intel.com \
--cc=wei.huang2@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox