From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C654620 for ; Fri, 6 May 2022 03:40:29 +0000 (UTC) Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-ed8a3962f8so6104855fac.4 for ; Thu, 05 May 2022 20:40:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WNNx5SqqknTge4y9/eUvRrcsh9m9RTE+BK27SVwwwhs=; b=Y3oK9ZklCqUyV2UCcurb2SZie0KVUZBoED2gV1ZMI54pHlaObR+Yu0zT/4B4URslXU L6G/3lv1KbX/2evOvCIeoR+ixzyEP7ORlBdMS+PejkXygXxDWjojZ4QdbvqK5khV4Rg+ aXl6hBUofLH6/lhsMPnD+Gt3DCuNIGLHpSNROar9lyMsILkTt10qVoPg0fRQ0Hf0/KrI Lj322x0AfrbEWjvlMqlNrdgw7jX0QnytRFVMrU9EEqlKnocZzr8VhMqvFztq1OGJQhvk wfcTyWXHicx0+w5PgU+0YCbmio7sD6DwE8qEznkr0GpxszA/CS1dyVzU3Q/FoAIlePWV 74/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WNNx5SqqknTge4y9/eUvRrcsh9m9RTE+BK27SVwwwhs=; b=WC/A60/AszvBfikyzDTIlt+l50FvuW1ICoSXUtBB5ac4KSubUAAXmfsQ61RgRLLtVZ Y9dEj5fYKQDuQxeuloSYcFBn0tQj8ac9+M+P+Hm3k0sIQt12e3HqqkrqLiqNCbwIe+SZ N7iPvHr3mGnP2w/yq0sQgeo5WHmWFF2qFJpuuDN/Zw2pcSWocFObLMAxiTswYE4J5b35 84uEPhLhQbDXeMfEFThRLbDox21HKMYtUQw72d6pVPjL6Sz2sfevtiZpxBJluBCKruSk iGdJ9UVUXB9MF/BgXClRPwDy2NeD5+MMY8isbkz3m0eEGBb10x9scovsTSS+dhfm9TK5 t8oQ== X-Gm-Message-State: AOAM532FbVKL2M10nfDCMmKAqvkSkBiyeN8W3lwvGj8ace0Fkd7ZT7iD QkYeFmYVDRo4Q/B+CuPcrNNGEg== X-Google-Smtp-Source: ABdhPJydCEUimIJyazQBa8BRPeEcgTzNUlC4nBe5TecKYIwIBr2ZbEo9p+gDmXN3dQu5R6BUoL3UXg== X-Received: by 2002:a05:6870:f5a3:b0:e1:944b:6450 with SMTP id eh35-20020a056870f5a300b000e1944b6450mr526370oab.254.1651808428175; Thu, 05 May 2022 20:40:28 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id p22-20020a056870831600b000eb0e40b4b8sm1260245oae.48.2022.05.05.20.40.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 20:40:27 -0700 (PDT) Date: Thu, 5 May 2022 22:40:22 -0500 From: Bjorn Andersson To: Stephen Boyd Cc: Andy Gross , linux-kernel@vger.kernel.org, patches@lists.linux.dev, linux-arm-msm@vger.kernel.org, Benson Leung , Guenter Roeck , Douglas Anderson , Hsin-Yi Wang , "Joseph S. Barrera III" Subject: Re: [PATCH] arm64: dts: qcom: sc7180-trogdor: Remove cros-ec keyboard from detachables Message-ID: References: <20220426225748.324759-1-swboyd@chromium.org> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220426225748.324759-1-swboyd@chromium.org> On Tue 26 Apr 17:57 CDT 2022, Stephen Boyd wrote: > Trogdor devices that have a detachable keyboard still have a > non-detachable keyboard input device present because we include the > cros-ec-keyboard.dtsi snippet in the top-level sc7180-trogdor.dtsi file > that every variant board includes. We do this because the > keyboard-controller node also provides some buttons like the power > button and volume buttons. Unfortunately, this means we register a > keyboard input device that doesn't do anything on boards with a > detachable keyboard. Let's delete the rows/columns properties of the > device node to indicate that there isn't a matrix keyboard on these > boards. > As this seems to directly relate to the final design of each device, would it make sense to push out the &keyboard_controller from trogdor.dtsi? Or do you think it would be too much duplication for it to be worth it? Regards, Bjorn > Cc: Benson Leung > Cc: Guenter Roeck > Cc: Douglas Anderson > Cc: Hsin-Yi Wang > Cc: "Joseph S. Barrera III" > Signed-off-by: Stephen Boyd > --- > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 5 +++++ > arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar.dtsi | 5 +++++ > 2 files changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi > index c81805ef2250..4173623cc241 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi > @@ -119,6 +119,11 @@ &i2c9 { > status = "disabled"; > }; > > +&keyboard_controller { > + /delete-property/keypad,num-rows; > + /delete-property/keypad,num-columns; > +}; > + > &panel { > compatible = "boe,nv110wtm-n61"; > }; > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar.dtsi > index bff2b556cc75..7205062e88b4 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar.dtsi > @@ -121,6 +121,11 @@ &camcc { > status = "okay"; > }; > > +&keyboard_controller { > + /delete-property/keypad,num-rows; > + /delete-property/keypad,num-columns; > +}; > + > &panel { > compatible = "samsung,atna33xc20"; > enable-gpios = <&tlmm 12 GPIO_ACTIVE_HIGH>; > -- > https://chromeos.dev >