From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06C103237 for ; Thu, 2 Jun 2022 21:08:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75723C385A5; Thu, 2 Jun 2022 21:08:45 +0000 (UTC) Date: Thu, 2 Jun 2022 22:08:41 +0100 From: Catalin Marinas To: "Jason A. Donenfeld" Cc: Stephen Boyd , Will Deacon , Dominik Brodowski , Ard Biesheuvel , linux-arm-kernel , LKML , Douglas Anderson , Hsin-Yi Wang , Steven Rostedt , patches@lists.linux.dev Subject: Re: [PATCH] arm64: Initialize jump labels before setup_machine_fdt() Message-ID: References: <20220602022109.780348-1-swboyd@chromium.org> <165419885870.2681883.10934677413962491141.b4-ty@arm.com> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Jun 02, 2022 at 10:18:04PM +0200, Jason A. Donenfeld wrote: > On Thu, Jun 2, 2022 at 9:46 PM Catalin Marinas wrote: > > On Thu, Jun 02, 2022 at 09:42:49PM +0200, Jason A. Donenfeld wrote: > > > On Thu, Jun 2, 2022 at 9:41 PM Catalin Marinas wrote: > > > > On Wed, 1 Jun 2022 19:21:09 -0700, Stephen Boyd wrote: > > > > > A static key warning splat appears during early boot on arm64 systems > > > > > that credit randomness from devicetrees that contain an "rng-seed" > > > > > property. This is because setup_machine_fdt() is called before > > > > > jump_label_init() during setup_arch(). Let's swap the order of these two > > > > > calls so that jump labels are initialized before the devicetree is > > > > > unflattened and the rng seed is credited. > > > > > > > > > > [...] > > > > > > > > Applied to arm64 (for-next/core), thanks! > > > > > > > > [1/1] arm64: Initialize jump labels before setup_machine_fdt() > > > > https://git.kernel.org/arm64/c/73e2d827a501 > > > > > > I'm not sure precisely what your for-next tag corresponds to, but just > > > FYI, this should probably go into 5.19 asap and be marked for stable@. > > > > The for-next/core branch should go in 5.19-rc1 (I'll send a pull request > > tomorrow). There's no need to cc stable since the fixed commit just went > > in (unless you mean something else by "marked for stable"). > > It is actually in stable, so please do CC. Otherwise I'll just forward manually. Ah, I didn't know this (the fixed commit doesn't have a cc stable either). So please forward it manually once Linus pulls it. Thanks. -- Catalin