Re: [PATCH 11/11] proc_sysctl: deprecate register_sysctl_paths()

Luis Chamberlain
2023-03-10T07:01:31Z

On Thu, Mar 09, 2023 at 08:17:07PM -0800, Eric Biggers wrote:
> On Thu, Mar 02, 2023 at 12:28:26PM -0800, Luis Chamberlain wrote:
> > diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h
> > index 780690dc08cd..e8459fc56b50 100644
> > --- a/include/linux/sysctl.h
> > +++ b/include/linux/sysctl.h
> > @@ -221,13 +221,8 @@ extern void retire_sysctl_set(struct ctl_table_set *set);
> > struct ctl_table_header *__register_sysctl_table(
> > struct ctl_table_set *set,
> > const char *path, struct ctl_table *table);
> > -struct ctl_table_header *__register_sysctl_paths(
> > - struct ctl_table_set *set,
> > - const struct ctl_path *path, struct ctl_table *table);
> > struct ctl_table_header *register_sysctl(const char *path, struct ctl_table *table);
> > struct ctl_table_header *register_sysctl_table(struct ctl_table * table);
> > -struct ctl_table_header *register_sysctl_paths(const struct ctl_path *path,
> > - struct ctl_table *table);
> >
> > void unregister_sysctl_table(struct ctl_table_header * table);
> >
> > @@ -277,12 +272,6 @@ static inline struct ctl_table_header *register_sysctl_mount_point(const char *p
> > return NULL;
> > }
> >
> > -static inline struct ctl_table_header *register_sysctl_paths(
> > - const struct ctl_path *path, struct ctl_table *table)
> > -{
> > - return NULL;
> > -}
> > -
>
> Seems that this patch should be titled "remove register_sysctl_paths()", not
> "deprecate register_sysctl_paths()"?

Good call! Will adjust.

Luis