From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B3C17B
	for <patches@lists.linux.dev>; Wed,  8 Mar 2023 07:17:23 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F6F8C433EF;
	Wed,  8 Mar 2023 07:17:22 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1678259842;
	bh=CZselh7PmGt1Cjg2uKRyDoGl1nckGX+iIhB7iqEUQvI=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=Qjaf7ZyL6bh96TbYo2TPOtm4E0TM6BHai0mkfFMcEFlnqOeKyHQfjvBSB/5JDzhfZ
	 oOQIesprZ22dV7gpMbMjLHdIcYTa+gBfpa6+ZdjKI34JjKKpQwKCMgpwvzdzcU8V1r
	 NC9kLVXnUamkqPTSKEBcybZ/2Dt33sklri9slZwI=
Date: Wed, 8 Mar 2023 08:17:20 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: stable@vger.kernel.org, patches@lists.linux.dev,
	Jan Kara <jack@suse.cz>, Theodore Tso <tytso@mit.edu>,
	linux-ext4@vger.kernel.org
Subject: Re: [PATCH 6.1 788/885] ext4: Fix possible corruption when moving a
 directory
Message-ID: <ZAg2gAJSYJDAMYMi@kroah.com>
References: <20230307170001.594919529@linuxfoundation.org>
 <20230307170036.133148515@linuxfoundation.org>
 <ZAePHuuAGo7I1VOc@gmail.com>
Precedence: bulk
X-Mailing-List: patches@lists.linux.dev
List-Id: <patches.lists.linux.dev>
List-Subscribe: <mailto:patches+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:patches+unsubscribe@lists.linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZAePHuuAGo7I1VOc@gmail.com>

On Tue, Mar 07, 2023 at 07:23:10PM +0000, Eric Biggers wrote:
> On Tue, Mar 07, 2023 at 06:02:02PM +0100, Greg Kroah-Hartman wrote:
> > From: Jan Kara <jack@suse.cz>
> > 
> > commit 0813299c586b175d7edb25f56412c54b812d0379 upstream.
> > 
> > When we are renaming a directory to a different directory, we need to
> > update '..' entry in the moved directory. However nothing prevents moved
> > directory from being modified and even converted from the inline format
> > to the normal format. When such race happens the rename code gets
> > confused and we crash. Fix the problem by locking the moved directory.
> > 
> > CC: stable@vger.kernel.org
> > Fixes: 32f7f22c0b52 ("ext4: let ext4_rename handle inline dir")
> > Signed-off-by: Jan Kara <jack@suse.cz>
> > Link: https://lore.kernel.org/r/20230126112221.11866-1-jack@suse.cz
> > Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> This commit has a reported regression
> (https://lore.kernel.org/linux-ext4/5efbe1b9-ad8b-4a4f-b422-24824d2b775c@kili.mountain),
> so probably it should not be backported quite yet.

Thanks, I've dropped it from everywhere now.  Please let us know when
it's safe to add back to the tree.

greg k-h