From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0185C3B2BE; Wed, 20 Sep 2023 16:55:56 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 209A121E17; Wed, 20 Sep 2023 16:55:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1695228953; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YRuJsY73C8doQ4cNf1LjL+UhEmqmPUGsnMHO5Imx8so=; b=dKI2cRhasOtnaSBCgHjLyUopF0KNuF+cPl+ufz4nGgCod/Sl8Ub2LjKkQ0FAvxJdjnvDmg loN3fdV7iY3W0HfKtQ7/3pa0ZqYapkZuE1Akp8EzbDWK39Heez0rwJ3Xg9iHYJwzuTCz4H 64/c3qT/xH5HCj7WJ3OK6gSwbOE1Hek= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E8EDA1333E; Wed, 20 Sep 2023 16:55:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KbyzNBgkC2V7dQAAMHmgww (envelope-from ); Wed, 20 Sep 2023 16:55:52 +0000 Date: Wed, 20 Sep 2023 18:55:52 +0200 From: Michal Hocko To: Shakeel Butt Cc: Jeremi Piotrowski , Johannes Weiner , Roman Gushchin , Muchun Song , Greg Kroah-Hartman , stable@vger.kernel.org, patches@lists.linux.dev, Tejun Heo , Andrew Morton , linux-kernel@vger.kernel.org, regressions@lists.linux.dev, mathieu.tortuyaux@gmail.com Subject: Re: [REGRESSION] Re: [PATCH 6.1 033/219] memcg: drop kmem.limit_in_bytes Message-ID: References: <20230917191040.964416434@linuxfoundation.org> <20230917191042.204185566@linuxfoundation.org> <20230920081101.GA12096@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <101987a1-b1ab-429d-af03-b6bdf6216474@linux.microsoft.com> <4eb47d6a-b127-4aad-af30-896c3b9505b4@linux.microsoft.com> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed 20-09-23 08:32:42, Shakeel Butt wrote: > Also I don't think reverting 58056f77502f would give any benefit. Not reverting 58056f77502f would re-introduce the regression in some non-patched versions of Docker runtimes which cannot handle ENOTSUPP. So I think we need to revert both or none of them. I would prefer the later (option 1) as the fix is trivial but I do understand headache of chasing all those outdated deployments or vendor code forks. -- Michal Hocko SUSE Labs