From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16BD23FB3E for ; Tue, 3 Oct 2023 23:35:23 +0000 (UTC) Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-68fb85afef4so1260282b3a.1 for ; Tue, 03 Oct 2023 16:35:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696376123; x=1696980923; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UJD24QbXAixuWuUpvUYY/DJkjTh/y9ZMHAxjDwAuOCg=; b=Z1XV+WDiZmrBbe6H9bE9NaBzKTj6ZMjAbL/8JfGfk4Fd1yclTuya5lDy450LVDHyFj EXCI5Lo9PDpwujfsGeVgaTplzZBCezHnfwGH7ONUY5cUwaPZTXMVNLOlgG6Sj17lS1tG +Aqosn0NLkBOKVhWm/o2QEnmWznImutLDLRHjpnaOWGJh3fPy+JcxGKix9tYinbDFhNm b4L00SxLsch0U3W+QVI789iZ5SDAg5IAxpxae130dCVCkispJ4zlNqnU8OYfPzHqeaJQ LlYJrIT6U6f4jMeCkRXl9AQNPu7gqc7bJ01WkEFs7RxhwCcxnG9rSgwWAVUkRUFO+nJ8 ZQkA== X-Gm-Message-State: AOJu0Yxqmt1r/9lVc+/P/P/kk7GjzidHDRqRJkOyfHxuEvJc+Z6FJKRq Ue66QrzSHUTxFV30SvLxHdY= X-Google-Smtp-Source: AGHT+IFygOHV2/FvdD4qmBhjkUVrn/Kq2uyKGkQqrsQf3OvfZZd939O7TMH4i4YP0wgmh5TMOwkkxg== X-Received: by 2002:a05:6a00:852:b0:68f:efc2:ba3d with SMTP id q18-20020a056a00085200b0068fefc2ba3dmr1215971pfk.33.1696376123288; Tue, 03 Oct 2023 16:35:23 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([20.69.120.36]) by smtp.gmail.com with ESMTPSA id w16-20020a639350000000b0057d0a8e634dsm1948102pgm.48.2023.10.03.16.35.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 16:35:22 -0700 (PDT) Date: Tue, 3 Oct 2023 23:35:21 +0000 From: Wei Liu To: Greg KH Cc: Wei Liu , Nuno Das Neves , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, patches@lists.linux.dev, mikelley@microsoft.com, kys@microsoft.com, haiyangz@microsoft.com, decui@microsoft.com, apais@linux.microsoft.com, Tianyu.Lan@microsoft.com, ssengar@linux.microsoft.com, mukeshrathor@microsoft.com, stanislav.kinsburskiy@gmail.com, jinankjain@linux.microsoft.com, vkuznets@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, will@kernel.org, catalin.marinas@arm.com Subject: Re: [PATCH v4 15/15] Drivers: hv: Add modules to expose /dev/mshv to VMMs running on Hyper-V Message-ID: References: <1696010501-24584-1-git-send-email-nunodasneves@linux.microsoft.com> <1696010501-24584-16-git-send-email-nunodasneves@linux.microsoft.com> <2023093004-evoke-snowbird-363b@gregkh> <2023093002-bonfire-petty-c3ca@gregkh> <2023100130-profusely-landside-0f97@gregkh> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2023100130-profusely-landside-0f97@gregkh> On Sun, Oct 01, 2023 at 08:20:37AM +0200, Greg KH wrote: > On Sat, Sep 30, 2023 at 09:13:07PM +0000, Wei Liu wrote: > > On Sat, Sep 30, 2023 at 08:31:13PM +0200, Greg KH wrote: > > > On Sat, Sep 30, 2023 at 06:11:19PM +0000, Wei Liu wrote: > > > > On Sat, Sep 30, 2023 at 08:11:37AM +0200, Greg KH wrote: > > > > > On Fri, Sep 29, 2023 at 11:01:41AM -0700, Nuno Das Neves wrote: > > > > > > --- /dev/null > > > > > > +++ b/include/uapi/linux/mshv.h > > > > > > @@ -0,0 +1,306 @@ > > > > > > +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ > > > > > > > > > > Much better. > > > > > > > > > > > +#ifndef _UAPI_LINUX_MSHV_H > > > > > > +#define _UAPI_LINUX_MSHV_H > > > > > > + > > > > > > +/* > > > > > > + * Userspace interface for /dev/mshv > > > > > > + * Microsoft Hypervisor root partition APIs > > > > > > + * NOTE: This API is not yet stable! > > > > > > > > > > Sorry, that will not work for obvious reasons. > > > > > > > > This can be removed. For practical purposes, the API has been stable for > > > > the past three years. > > > > > > Then who wrote this text? > > > > I don't think this matter, does it? This patch series had been rewritten > > so many times internally to conform to upstream standard it is very > > difficult to track down who wrote this and when. > > The point is someone wrote this for a good reason so figuring out why > that was done would be good for you all to do as maybe it is true! > > > If you have concrete concerns about removing the text, please let me > > know. > > You need to verify that the comment is not true before removing it, > otherwise you all will have a very hard time in the future when things > change... I understand your point. Thanks, I will make sure to do that. :-) Thanks, Wei. > > thanks, > > greg k-h