From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7A8F70030 for ; Wed, 28 Feb 2024 21:35:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709156140; cv=none; b=QPfCnDlC9csqiMDt7UwFuo4nhRvosz03kbiyfe7SdHzNbsO22Xbnujd3KYGkhB46ridQDJ5poK51Ic2wa8g2gG//VNFZtpp+ZNdecaZuswr5ldi+OmIXC6ypCoup+MvUFLuQxev1QWOj75pukmXzH2F5NkGBc1gc8JbYv34wlnU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709156140; c=relaxed/simple; bh=bo+1raElk9CFzZGK1rXURbBjbxmJF3gx1clws/DrATo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XWuUgUUh/5ShXBAcXfdbuL+2lJmPu4umpwEAYISH3Ynjbm1msUW/UoH8wURMGNfHVTLphs0PfrUN2evxPpyBTj9JehBxUZ/Vk+xdmRefNOKOhrZR4O9ZLrGAoQxRVF13wSGNAucSCX+fJwxlfTj8moCPQ1gEuzGDNu33EyId368= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=CBbEtVVn; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="CBbEtVVn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709156139; x=1740692139; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=bo+1raElk9CFzZGK1rXURbBjbxmJF3gx1clws/DrATo=; b=CBbEtVVn/wtRypYTe6AUM1Wxn8CEr6T6a5CeubpnrqabFFmSDvWLtCdN WXR8MwH3DkwIfOG6Ca/Do2I5Zd6PSC5wgdwBA+pRvChXQmr31HPg/krpR yQLsYSvfYK83+sjzKz4mBBhpHM5Yabzw9sGa5h38ZbNx0jWLnh2pdGUYO YaqKsw1n3MN98JZGYAnptGOiQUVf7GgEkJeYgr1h+vEtKVlhh1N5j9III fmqAXgLX2V7mny+k2BycR0tS5QPrdBtfTnxRPBGDdzFtEwGeFuuW+YnU+ jfgIdwenP/tZz67Carvu/EVDghFcAASvtibZiR0WQ3Ky+Lwbmz7QJ9/dC w==; X-IronPort-AV: E=McAfee;i="6600,9927,10998"; a="7371008" X-IronPort-AV: E=Sophos;i="6.06,191,1705392000"; d="scan'208";a="7371008" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2024 13:35:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10998"; a="913961905" X-IronPort-AV: E=Sophos;i="6.06,191,1705392000"; d="scan'208";a="913961905" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2024 13:35:35 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rfRaO-00000008VbH-138y; Wed, 28 Feb 2024 23:35:32 +0200 Date: Wed, 28 Feb 2024 23:35:31 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Stephen Boyd , Linus Walleij , linux-kernel@vger.kernel.org, patches@lists.linux.dev, linux-gpio@vger.kernel.org, Dmitry Torokhov Subject: Re: [PATCH v2] gpiolib: Pass consumer device through to core in devm_fwnode_gpiod_get_index() Message-ID: References: <20240223065254.3795204-1-swboyd@chromium.org> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Feb 28, 2024 at 10:28:07PM +0100, Bartosz Golaszewski wrote: > On Wed, Feb 28, 2024 at 7:57 PM Andy Shevchenko > wrote: > > On Thu, Feb 22, 2024 at 10:52:53PM -0800, Stephen Boyd wrote: > > > This devm API takes a consumer device as an argument to setup the devm > > > action, but throws it away when calling further into gpiolib. This leads > > > to odd debug messages like this: > > > > > > (NULL device *): using DT '/gpio-keys/switch-pen-insert' for '(null)' GPIO lookup > > > > > > Let's pass the consumer device down, by directly calling what > > > fwnode_gpiod_get_index() calls but pass the device used for devm. This > > > changes the message to look like this instead: > > > > > > gpio-keys gpio-keys: using DT '/gpio-keys/switch-pen-insert' for '(null)' GPIO lookup > > > > > > Note that callers of fwnode_gpiod_get_index() will still see the NULL > > > device pointer debug message, but there's not much we can do about that > > > because the API doesn't take a struct device. > > > > Have you seen this? > > https://lore.kernel.org/r/20231019173457.2445119-1-andriy.shevchenko@linux.intel.com > > Clearly yes as I queued the first one in that series. The rest did not > make its way upstream for whatever reason. What is your point? You > want to respin it? It was a reply to Stephen. :-) -- With Best Regards, Andy Shevchenko