From: Luis Chamberlain <mcgrof@kernel.org>
To: Dave Chinner <david@fromorbit.com>
Cc: fstests@vger.kernel.org, anand.jain@oracle.com,
aalbersh@redhat.com, djwong@kernel.org,
linux-fsdevel@vger.kernel.org, kdevops@lists.linux.dev,
patches@lists.linux.dev
Subject: Re: [PATCH 3/3] check: add --print-start-done to enhance watchdogs
Date: Wed, 21 Feb 2024 08:46:39 -0800 [thread overview]
Message-ID: <ZdYo7zjD_lDlOdia@bombadil.infradead.org> (raw)
In-Reply-To: <ZdLOKCYnM3XybqQp@dread.disaster.area>
On Mon, Feb 19, 2024 at 02:42:32PM +1100, Dave Chinner wrote:
> On Fri, Feb 16, 2024 at 10:18:59AM -0800, Luis Chamberlain wrote:
> > fstests specific watchdogs want to know when the full test suite will
> > start and end. Right now the kernel ring buffer can get augmented but we
> > can't know for sure if it was due to a test or some odd hardware issue
> > after fstests ran. This is specially true for systems left running tests in
> > loops in automation where we are not running things ourselves but rather just
> > get access to kernel logs, or for filesystem runner watdogs such as the one
> > in kdevops [0]. It is also often not easy to determine for sure based on
> > just logs when fstests check really has completed unless we have a
> > matching log of who spawned that test runner. Although we could keep track of
> > this ourselves by an annotation locally on the test runner, it is useful to
> > have independent tools which are not attached to the process which spawned
> > check to just peak into a system and verify the system's progress with
> > fstests by just using the kernel log. Keeping this in the test target kernel
> > ring buffer enables these use cases.
> >
> > This is useful for example for filesyste checker specific watchdogs like the
> > one in kdevops so that the watchdog knows when to start hunting for crashes
> > based just on the kernel ring buffer, and so it also knows when the show is
> > over.
>
> Why can't the runner that requires timing information in the
> kernel log just emit a message to the kernel log before it
> runs check and again immediately after completion of the check
> script?
That's exactly what is done today, it just seemed to me that since this
has been useful to a test runner now for years, it might make sense to
generalize this.
Luis
prev parent reply other threads:[~2024-02-21 16:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 18:18 [PATCH fstests 0/3] few enhancements Luis Chamberlain
2024-02-16 18:18 ` [PATCH 1/3] tests: augment soak test group Luis Chamberlain
2024-02-16 18:18 ` [PATCH 2/3] check: add support for --list-group-tests Luis Chamberlain
2024-02-19 3:38 ` Dave Chinner
2024-02-21 16:45 ` Luis Chamberlain
2024-02-25 16:08 ` Zorro Lang
2024-02-16 18:18 ` [PATCH 3/3] check: add --print-start-done to enhance watchdogs Luis Chamberlain
2024-02-19 3:42 ` Dave Chinner
2024-02-21 16:46 ` Luis Chamberlain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdYo7zjD_lDlOdia@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=aalbersh@redhat.com \
--cc=anand.jain@oracle.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=kdevops@lists.linux.dev \
--cc=linux-fsdevel@vger.kernel.org \
--cc=patches@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).