From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Aleksa Sarai <cyphar@cyphar.com>
Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev,
tglx@linutronix.de, linux-crypto@vger.kernel.org,
linux-api@vger.kernel.org, x86@kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
Carlos O'Donell <carlos@redhat.com>,
Florian Weimer <fweimer@redhat.com>,
Arnd Bergmann <arnd@arndb.de>, Jann Horn <jannh@google.com>,
Christian Brauner <brauner@kernel.org>,
David Hildenbrand <dhildenb@redhat.com>
Subject: Re: [PATCH v18 2/5] random: add vgetrandom_alloc() syscall
Date: Thu, 20 Jun 2024 14:18:17 +0200 [thread overview]
Message-ID: <ZnQeCRjgNXEAQjEo@zx2c4.com> (raw)
In-Reply-To: <20240620.020423-puny.wheat.mobile.arm-1wWnJHwWYyAl@cyphar.com>
Hey Aleksa,
On Wed, Jun 19, 2024 at 07:13:26PM -0700, Aleksa Sarai wrote:
> Then again, I guess since libc is planned to be the primary user,
> creating a new syscall in a decade if necessary is probably not that big
> of an issue.
I'm not sure going the whole big struct thing is really necessary, and
for an additional reason: this is only meant to be used with the vDSO
function, which is also coupled with the kernel. It doesn't return
information that's made to be used (or allowed to be used) anywhere
else. So both the vdso code and the syscall code are part of the same
basic thing that will evolve together. So I'm not convinced extensible
struct really makes sense for this, as neat as it is.
If there's wide consensus that it's desirable, in contrast to what I'm
saying, I'm not vehemently opposed to it and could do it, but it just
seems like massive overkill and not at all necessary. Things are
intentionally as simple and straightforward as can be.
Jason
next prev parent reply other threads:[~2024-06-20 12:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 0:53 [PATCH v18 0/5] implement getrandom() in vDSO Jason A. Donenfeld
2024-06-20 0:53 ` [PATCH v18 1/5] mm: add VM_DROPPABLE for designating always lazily freeable mappings Jason A. Donenfeld
2024-06-20 0:53 ` [PATCH v18 2/5] random: add vgetrandom_alloc() syscall Jason A. Donenfeld
2024-06-20 2:13 ` Aleksa Sarai
2024-06-20 12:18 ` Jason A. Donenfeld [this message]
2024-06-28 13:56 ` Thomas Gleixner
2024-06-28 14:09 ` Jason A. Donenfeld
2024-06-28 14:11 ` Jason A. Donenfeld
2024-07-01 11:53 ` Jason A. Donenfeld
2024-07-01 13:59 ` Jason A. Donenfeld
2024-06-20 0:53 ` [PATCH v18 3/5] arch: allocate vgetrandom_alloc() syscall number Jason A. Donenfeld
2024-06-20 0:53 ` [PATCH v18 4/5] random: introduce generic vDSO getrandom() implementation Jason A. Donenfeld
2024-06-28 13:57 ` Thomas Gleixner
2024-06-20 0:53 ` [PATCH v18 5/5] x86: vdso: Wire up getrandom() vDSO implementation Jason A. Donenfeld
2024-06-28 13:57 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnQeCRjgNXEAQjEo@zx2c4.com \
--to=jason@zx2c4.com \
--cc=adhemerval.zanella@linaro.org \
--cc=arnd@arndb.de \
--cc=brauner@kernel.org \
--cc=carlos@redhat.com \
--cc=cyphar@cyphar.com \
--cc=dhildenb@redhat.com \
--cc=fweimer@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jannh@google.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox