From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.8bytes.org (mail.8bytes.org [85.214.250.239]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0F95F18C929; Thu, 12 Sep 2024 07:20:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=85.214.250.239 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726125645; cv=none; b=QfXL/bVa4GdNum0w+S7e1iURAHk7RO5WKN3PZx1eAsgO2oPtoaEuQveUwrSAXNGVM7fby2pIL1KiVV1kmMz3M6V9NmwV+WRSvLd4aw83HZc2zltHYt2PZYqe+IKBlleOudUXA7HADO1+kHbVwQUVOEoeWbSXtZquhrl5SZ9EHB8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726125645; c=relaxed/simple; bh=b9U5eANp9GKWrkzxfXMblKUuLn8vJkNE9dbwlUT+x4U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jRFMhwY3uaN2ZXImtpiRDBiKGSI7MfxT4vjzqnsmd+ZxRuj6rUtX42hz26HsAQzz3tGYx1aT9S4VUsxZ8BszkYueRkK4y+vLKfvGqYI++aV1XrI0S/xmXLXjmewPluySWkR55WmD0Zdl/l83yQK0bF2sbivFsKYiDkGQCUKInsY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=8bytes.org; spf=pass smtp.mailfrom=8bytes.org; dkim=pass (2048-bit key) header.d=8bytes.org header.i=@8bytes.org header.b=Du9swgIG; arc=none smtp.client-ip=85.214.250.239 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=8bytes.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=8bytes.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=8bytes.org header.i=@8bytes.org header.b="Du9swgIG" Received: from 8bytes.org (p4ffe1f47.dip0.t-ipconnect.de [79.254.31.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.8bytes.org (Postfix) with ESMTPSA id 2F905289812; Thu, 12 Sep 2024 09:20:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=8bytes.org; s=default; t=1726125640; bh=b9U5eANp9GKWrkzxfXMblKUuLn8vJkNE9dbwlUT+x4U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Du9swgIGhvI5ohoThxzN4NYeuUHubhBseZP5GgQg5GDWtcRZ2w90CNPvirtmdlsqV zdh492LxMSzw12B+MYhi/WdIkLGw1L2iGLSEUC1UQ/oddBld1L6iLQPCllXeUv76ju NO0VaK0NbashSkTHYwtgoROguHJpxNV4rVkaod9siWK6AlK3Huu7ehrpznM+m8Scie DjhoWquaZumI+9Xx/ApjBH/vFPDpv1ujwrLrbTC6Ryhp6onRPO7uUvSDbWCnQihOFR RwopL0U+2u8fCeUyF6xSBBRNOuuhGsGkGdQCJUgCoX0MOz6S/vaXRXB5XqMXAZxO+b LRFw1veEJpx6g== Date: Thu, 12 Sep 2024 09:20:38 +0200 From: Joerg Roedel To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Robin Murphy , Suravee Suthikulpanit , Will Deacon , Eliav Bar-ilan , Joerg Roedel , patches@lists.linux.dev, stable@vger.kernel.org, Vasant Hegde Subject: Re: [PATCH rc] iommu/amd: Fix argument order in amd_iommu_dev_flush_pasid_all() Message-ID: References: <0-v1-fc6bc37d8208+250b-amd_pasid_flush_jgg@nvidia.com> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0-v1-fc6bc37d8208+250b-amd_pasid_flush_jgg@nvidia.com> On Tue, Sep 10, 2024 at 04:44:16PM -0300, Jason Gunthorpe wrote: > From: Eliav Bar-ilan > > An incorrect argument order calling amd_iommu_dev_flush_pasid_pages() > causes improper flushing of the IOMMU, leaving the old value of GCR3 from > a previous process attached to the same PASID. > > The function has the signature: > > void amd_iommu_dev_flush_pasid_pages(struct iommu_dev_data *dev_data, > ioasid_t pasid, u64 address, size_t size) > > Correct the argument order. > > Cc: stable@vger.kernel.org > Fixes: 474bf01ed9f0 ("iommu/amd: Add support for device based TLB invalidation") > Signed-off-by: Eliav Bar-ilan > Signed-off-by: Jason Gunthorpe > --- > drivers/iommu/amd/iommu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks.