From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2074.outbound.protection.outlook.com [40.107.244.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3ACC7188583; Fri, 25 Oct 2024 16:17:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.244.74 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729873075; cv=fail; b=tLHPAOH4fgx7qopP6QBtEFI7naVKgjkcA/noZlw2+eKFqPnSie1t8pB0zdyRd5v4sTKtM6UhIhEU46zu12t46L+6llho3kg8CrN6i0hNy+d/Of8fzOg/xrZji1HY9Up4c/H5mJoqThpLyNTyUpl6VJJ+vT+zbcX57PwZT9bNzAw= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729873075; c=relaxed/simple; bh=D4nPz8CXAIq/qr+R2p3XUhOSskekpJ/0oKYizpBuFno=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VQM5mSj523eVgqP1nK0FOB9AmkCxn264x5WJVh6FCYxpjQgRYmJKhSjMucDETfjnv/h8rYYT+2W2lImaOwlEe7ZIvkWjeiNrGIPo9d0/n12GSHAjZdeW7BhK2fEie4kYJI7pAuFO+p9ZpxuLm5aKV5jettfeyIOhf+nFYlV14DY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=nVVB3evh; arc=fail smtp.client-ip=40.107.244.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="nVVB3evh" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pnrwobu/AgTxAg534ITKfJCpEZ7ypV7fppg4/dqQmVQoTvqzyLa7eXh1uLaBmI1Z2gDvGFjVNy2ZM0xCKGbluvokwLmJs+l8x4p0Fa6JdEGStdkqwcID2kSB5Mx5j5m/m1J+qwRyr12IBZjG/HYXWiuxmC98imKe8cMblc2Y881dAnJ0CbZVBBllcCws/bfjND53XbpAU2zik1GmTu8We9BmDpm5jDVWm4opkVlB/v8DCOZDsQnpXyDkZjQKwVRwPIIKU7c5YXFeb8/XlY62JnGjLFF1ulxI9P/ST4dFogO07sz/J/HIARtTmXi0GSOjqFpI/pzoTAdY1NaiczwTLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tHNdCPpM2O+butzQDqs8QZNVpkjUU3guD1lgMZTy2j8=; b=lA1wb6MS/cDRtT8njZv0T35wAQQYEM8k64x+xqDhiMcoF1Z+oRTdvugdypHokZPZQWM6QtF9f3ARCdV4XjB7v+d8k70aDcuDm1tlIUHT6Ry5C/TR0njuSSUHdrtsByJ1Lj0KumYmDoxpPlM0Uep3ZQSSrBM8dAQGACh0Kfy3K8bfzYOYZZgCG9OkdUkCEqJ8wpncq2qIHafTTnEptckEBZmFDnG9sba544eH23yR93vH3Fb+GySUuRkzBMkF+UCacilkA+NiOCAq6ttJdCFOOEMm7gI8EhkKmhr3CipoF0KwKaLp2FGWi+ER6md3D3G6xARnQb20oO0XJTK9iha99A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tHNdCPpM2O+butzQDqs8QZNVpkjUU3guD1lgMZTy2j8=; b=nVVB3evhr8V86Uonfxdg1mJ+sJjjjGMQxNPzTT2IBhnXhN1ee3AWILe1MZ0EQjjsjvitAvxDCsjmdjhGuQNR3N686MLsROkKVxbYaHhsOJdUZh6VMd7bPh3JznHoV9W6UMmziiialZck4e4QaJOTkh0vhCrzxKUbZtO3M2WuDeqfxuT4FKf+JyZD+EXpo9HYiv8yDzWeuFirpvsuHP6zWtv0WJDr7+2hL/KUf3Erxq7uvTFWqXkBUQGXMhVnvkogV8YJjVv54ngGpRRWTZ1NfIENwn5CdKUcZi0jqECOnsQkx5E9pknDIopZhlqU0yCzHvZ+q2xfMG8HPNJMBXQrmA== Received: from BN9PR03CA0630.namprd03.prod.outlook.com (2603:10b6:408:106::35) by IA0PR12MB7532.namprd12.prod.outlook.com (2603:10b6:208:43e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.19; Fri, 25 Oct 2024 16:17:48 +0000 Received: from BL02EPF00029928.namprd02.prod.outlook.com (2603:10b6:408:106:cafe::9a) by BN9PR03CA0630.outlook.office365.com (2603:10b6:408:106::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.21 via Frontend Transport; Fri, 25 Oct 2024 16:17:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL02EPF00029928.mail.protection.outlook.com (10.167.249.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.14 via Frontend Transport; Fri, 25 Oct 2024 16:17:48 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 25 Oct 2024 09:17:35 -0700 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Fri, 25 Oct 2024 09:17:34 -0700 Received: from Asurada-Nvidia (10.127.8.9) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Fri, 25 Oct 2024 09:17:33 -0700 Date: Fri, 25 Oct 2024 09:17:32 -0700 From: Nicolin Chen To: "Tian, Kevin" CC: "jgg@nvidia.com" , "will@kernel.org" , "joro@8bytes.org" , "suravee.suthikulpanit@amd.com" , "robin.murphy@arm.com" , "dwmw2@infradead.org" , "baolu.lu@linux.intel.com" , "shuah@kernel.org" , "linux-kernel@vger.kernel.org" , "iommu@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , "linux-kselftest@vger.kernel.org" , "eric.auger@redhat.com" , "jean-philippe@linaro.org" , "mdf@kernel.org" , "mshavit@google.com" , "shameerali.kolothum.thodi@huawei.com" , "smostafa@google.com" , "Liu, Yi L" , "aik@amd.com" , "zhangfei.gao@linaro.org" , "patches@lists.linux.dev" Subject: Re: [PATCH v4 04/11] iommufd/viommu: Add IOMMU_VIOMMU_ALLOC ioctl Message-ID: References: <9da2cf334a182ced4d4ffa578b87889e9c0856f3.1729553811.git.nicolinc@nvidia.com> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00029928:EE_|IA0PR12MB7532:EE_ X-MS-Office365-Filtering-Correlation-Id: a702fcb1-6767-4945-60a2-08dcf510913a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|7416014|1800799024|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?/28XlbTX0m12q3bilvEr6gxiqdxZw0qjR6ZinRhmCuHA48Vwms7MfVSEhkUV?= =?us-ascii?Q?Gwz+tAQfFljbAa9Cz8d5HebIxxjhSdOxHcZYwVd7k4jHgFoo48owhqz/RpCM?= =?us-ascii?Q?+VJJzC5uf8H8u7RtmwvrOSRdOicGGGWWFMs0+WbWZ+sIVSkqickgdrMwMbEh?= =?us-ascii?Q?Yh5umXQ4nXs70bHCinUS3KJtBRVHp7g795/HXQJHquNZ2G9JdmNW74UlTLnp?= =?us-ascii?Q?qAVA89x8AgHvbvb8YTbwbZfLcw4yGjjGA9/jnr//AVz1KKBrAmR5eh3SXFLS?= =?us-ascii?Q?cN4KoVYIsWXka9AKuzFK1/1tbBe19wd5IDE0ZZ6Cg78ZNk509xm4uv8ho2Dh?= =?us-ascii?Q?wJu9+mzIme/VznXixVIzipkDqfWThoRStbX43JMr7MX+F0mAYYSy092PWRvg?= =?us-ascii?Q?1o37aQ0j0zOI9K1ZqUIcnh9XEwGYmqN3U5lPu3AwQE8SsePKLKuZJoiP+Ph7?= =?us-ascii?Q?SDh9hsX+GjT003BQKTyj7EXuDpSfWU4+wGkBLayq6pp/edyPRzdXT2X2n/Lm?= =?us-ascii?Q?qi7/SaOjRg4QEfxCPaLZ+LYm9GxcamjpITE5/pjKc6CJrZR429ucIEIK6rqB?= =?us-ascii?Q?s+cVtgq0VHNsQv5KodS7okPmzXeSoRu/te+2lKFM11c/+NNpeeV6223BUJcH?= =?us-ascii?Q?gRXN0N9ORCaFN/U9azv3r9ftnI0xhozhTF0IqHGYUnquW0jNGjlqouQjU621?= =?us-ascii?Q?7mIT7We110H6fWozPNCXsyuvSrWHvmNE5+HITH5G7yQJMBNCu3LI+QtFoqQn?= =?us-ascii?Q?k3zHQkJ/jgf1hlsWKXN1bkO6NtfTWKL5hqu3fbdF4/4hAXZslsL6eyhCSlLq?= =?us-ascii?Q?7KVJAggQzvVJDRP39gqShnDQC4gL0vOQl66j27r9JLO9cg2UdftDmtOETs+1?= =?us-ascii?Q?w7F0NiO47uJCkmkkKXLvxiWUADoUo98gazekbCj0MtVfZP3Gv1bJ0dH/9Pb3?= =?us-ascii?Q?/I9CyC6qZW19vMogwdKIcc01ka8d8/bEaUpuyhlLKgFWye0WJVZmDPvtjm2s?= =?us-ascii?Q?vej9mcqsO5crnvTNKbf6KjgLT61s8UJvArmC9wFJXVpTMFySKP1u6fqHkbxA?= =?us-ascii?Q?H1YycZcJN4kP3/rHwwl1IHTbaREKOo4Dk+/0zZcZ8tvL71yF1rruhTpSUZ8h?= =?us-ascii?Q?hQFsJAjqOZ0M2z0BopsH8kloiRefrdCPExu3UllNb/s4DzeMAWs1jNlYNUCg?= =?us-ascii?Q?du/vS2xrATqGyj8RhtNJA7lx7pQqS6Z7J6ICeY8QYRdaTHPXI4tqSUs6U+1P?= =?us-ascii?Q?tuSGnW1Mtar53XVE7pPntXJXDFrAmFt1I5l6Srg60Um2KcSQLByx13O43wsr?= =?us-ascii?Q?61tcGSeC/Ozazbxqmlasig8PZv5LoqgPfZ3DVwAN5HFwacoPZm2937U0cash?= =?us-ascii?Q?ceL/Tc62Y7CszPof+4BILJhkaYFtrKqhNeFtO4KKpkWVflEmNQ=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(36860700013)(7416014)(1800799024)(82310400026)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2024 16:17:48.2540 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a702fcb1-6767-4945-60a2-08dcf510913a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00029928.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7532 On Fri, Oct 25, 2024 at 09:05:58AM +0000, Tian, Kevin wrote: > > From: Nicolin Chen > > Sent: Tuesday, October 22, 2024 8:19 AM > > + > > + viommu->type = cmd->type; > > + viommu->ictx = ucmd->ictx; > > + viommu->hwpt = hwpt_paging; > > + /* Assume physical IOMMUs are unpluggable (the most likely case) > > */ > > + viommu->iommu_dev = __iommu_get_iommu_dev(idev->dev); > > + > > so what would happen if this assumption breaks? I had a very verbose comments previously that Alexey suggested to optimize away.. Perhaps I should add back the part that mentions adding a refcount for pluggable ones.. Nicolin