From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BF0EEEAA for ; Fri, 27 Sep 2024 04:39:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727411980; cv=none; b=LPxJwnTbG+Z6QEjiLDMIycXWmSpNAPy15hnsT8MtvFkbhMOxBbuGA9OU2f+/0bi76y3/RWr4bPrrYLeNpOVA/IwzcEVJx3R55bUb/JdXmlLoFDVnnHY7vOsDJUVPAoREDozRV58uvEIqKEWAVdnfiAzU/Fx3DCNoL+I6/Ww0h6w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727411980; c=relaxed/simple; bh=fnuMouiKEyLaGvP0fibwaDVaQx4o0ggHSL2sDNMPTE8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AHB89PaGpE3i4UoxcbpFO1ZAcuC49pwBg7YrzSwAEW3gMi3Y93PZPhhWzCkP2ITTNTqp2fjTQBD4171cjsQarLLU2nngRBiSrnn8NO4i+6GcCCGzwLCbEmzoLCb9oY9GoIyGu1IMMoTIEi78KXMes2W56I9Xnlluf0nv4o/vN58= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Fvm8emga; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Fvm8emga" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-7163489149eso1378563a12.1 for ; Thu, 26 Sep 2024 21:39:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727411978; x=1728016778; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=WkeWKlYqDtXSyz5lb3aYllnaQqnV6uJYVg8fzlxg5tg=; b=Fvm8emgafFPmalZ7QXLD8eNhP/vMxXUjecadniMHt3pimBTnsl3oFR9pd9RKfQwAML BBaQGV1LBmPqAII3dVG5EekiB26ascY6TMFXDAaYWx0sTPxyJbxL/fa/sZQrtuakO2iU IUiAXV7fL8j3gFYvOooCvShIBDuHqV1P33/H21Ht4F97lxdPun27A7Qc3LK3MHF/AuIR sRb81CAjCoZ0FoX2hnk7YmBaNpbOz2mUQTmUtDqmTBS5vko4qQP4lJK+gcqkZJlYDsQ6 icvJbXU530DaI7SLin5D+XOaNkIar//MdvNfpuqSATg0TPPBZmQkB6igszh/sNPpjiyd 7YTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727411978; x=1728016778; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WkeWKlYqDtXSyz5lb3aYllnaQqnV6uJYVg8fzlxg5tg=; b=od82tADRXNO0PS+HcpxbUmcX8wr1Rb+gsm3ZcAeZACtewuX3grEDApQRKo8KJa/Mpk IKGFK0YaCCa39uqs/JJOB8CvTIIjZW/UItVayxxd4KPpfwEklzS8xzFKOgV+MQBi5VJp ebG5xRIjxLyUrGq8LUxtuuGO/DDq1Eedi1hfFtHRc/ltdA/D9LUQPP2gLtQjKjxFPcmI SP90Det1hG5G12vak77tWfY+2I6ZMFKHYK+VptRie9CuWnDvNPrH0Xxzt3M2z5KgK8ED ugiEIjYPlecNFJ8fpB34Y8qCp2Cp7MokNP3T/dUxrIJWU/LqHV2S7TkZl93/pnjh8udb LeCQ== X-Forwarded-Encrypted: i=1; AJvYcCVyhWrEBSx39gB1bKLgyToM5JdTeHtBeseLwQPLzQ+0VUx+6sGQ3M/X+3hB4dSR4fnOwsMLyO1H@lists.linux.dev X-Gm-Message-State: AOJu0YyeWr+pwQfeaMyRz9QHH7hFIERRlGnIZKvSaK/gC9cV90e+u3hW czBuzaULD3cwK29dYRn4SltZMQhUD/hqN5K5Rgz7lFU6og6rgs+o X-Google-Smtp-Source: AGHT+IEfM+rRMxnYnAc6tMRBBhgU2qe67B99fXVKBiUZ3r0r2t2KmJEVITgi/OZS2CHi1py9nNGxkg== X-Received: by 2002:a05:6a21:3405:b0:1d2:bb49:908b with SMTP id adf61e73a8af0-1d4fa67b980mr2948871637.18.1727411978276; Thu, 26 Sep 2024 21:39:38 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7e6db60e3fasm721443a12.78.2024.09.26.21.39.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Sep 2024 21:39:37 -0700 (PDT) Sender: Guenter Roeck Date: Thu, 26 Sep 2024 21:39:36 -0700 From: Guenter Roeck To: Stephen Boyd Cc: Michael Turquette , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, patches@lists.linux.dev, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, devicetree@vger.kernel.org, Brendan Higgins , David Gow , Rae Moar , Greg Kroah-Hartman , "Rafael J . Wysocki" , Rob Herring , Saravana Kannan , Daniel Latypov , Christian Marangi , Krzysztof Kozlowski , Conor Dooley , Maxime Ripard , Geert Uytterhoeven Subject: Re: [PATCH v8 8/8] clk: Add KUnit tests for clks registered with struct clk_parent_data Message-ID: References: <20240718210513.3801024-1-sboyd@kernel.org> <20240718210513.3801024-9-sboyd@kernel.org> <6cd337fb-38f0-41cb-b942-5844b84433db@roeck-us.net> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6cd337fb-38f0-41cb-b942-5844b84433db@roeck-us.net> On Thu, Sep 26, 2024 at 09:14:11PM -0700, Guenter Roeck wrote: > Hi Stephen, > > On Thu, Jul 18, 2024 at 02:05:07PM -0700, Stephen Boyd wrote: > > Test that clks registered with 'struct clk_parent_data' work as > > intended and can find their parents. > > > > When testing this on arm64, I see the error below. The error is only > seen if I boot through efi, i.e., with "-bios QEMU_EFI-aarch64.fd" > qemu parameter. > > Any idea what might cause the problem ? > I noticed that the new overlay tests fail as well, also with "path '/' not found". [Maybe] answering my own question: I think the problem may be that there is no devicetree file and thus no devicetree root when booting through efi (in other words, of_root is NULL). Would it make sense to skip the tests in that case ? Thanks, Guenter > Thanks, > Guenter > > --- > [ 20.464809] KTAP version 1 > [ 20.464865] # Subtest: clk_register_clk_parent_data_of > [ 20.464936] # module: clk_test > [ 20.464979] 1..1 > [ 20.465098] KTAP version 1 > [ 20.465208] # Subtest: clk_register_clk_parent_data_of_test > [ 20.468964] OF: overlay: find target, node: /fragment@0, path '/' not found > [ 20.469558] OF: overlay: init_overlay_changeset() failed, ret = -22 > [ 20.470177] # clk_register_clk_parent_data_of_test: ASSERTION FAILED at drivers/clk/clk_test.c:2760 > [ 20.470177] Expected 0 == ({ extern uint8_t __dtbo_kunit_clk_parent_data_test_begin[]; extern uint8_t __dtbo_kunit_clk_parent_data_test_end[]; __of_overlay_apply_kunit((test), __dtbo_kunit_clk_parent_data_test_begin, __dtbo_kunit_clk_parent_data_test_end); }), but > [ 20.470177] ({ extern uint8_t __dtbo_kunit_clk_parent_data_test_begin[]; extern uint8_t __dtbo_kunit_clk_parent_data_test_end[]; __of_overlay_apply_kunit((test), __dtbo_kunit_clk_parent_data_test_begin, __dtbo_kunit_clk_parent_data_test_end); }) == -22 (0xffffffffffffffea) > [ 20.471793] not ok 1 clk_parent_data_of_index_test > [ 20.474095] OF: overlay: find target, node: /fragment@0, path '/' not found > [ 20.474373] OF: overlay: init_overlay_changeset() failed, ret = -22 > [ 20.474737] # clk_register_clk_parent_data_of_test: ASSERTION FAILED at drivers/clk/clk_test.c:2760 > [ 20.474737] Expected 0 == ({ extern uint8_t __dtbo_kunit_clk_parent_data_test_begin[]; extern uint8_t __dtbo_kunit_clk_parent_data_test_end[]; __of_overlay_apply_kunit((test), __dtbo_kunit_clk_parent_data_test_begin, __dtbo_kunit_clk_parent_data_test_end); }), but > [ 20.474737] ({ extern uint8_t __dtbo_kunit_clk_parent_data_test_begin[]; extern uint8_t __dtbo_kunit_clk_parent_data_test_end[]; __of_overlay_apply_kunit((test), __dtbo_kunit_clk_parent_data_test_begin, __dtbo_kunit_clk_parent_data_test_end); }) == -22 (0xffffffffffffffea) > [ 20.477677] not ok 2 clk_parent_data_of_fwname_test > [ 20.479773] OF: overlay: find target, node: /fragment@0, path '/' not found > [ 20.479941] OF: overlay: init_overlay_changeset() failed, ret = -22 > [ 20.480160] # clk_register_clk_parent_data_of_test: ASSERTION FAILED at drivers/clk/clk_test.c:2760 > [ 20.480160] Expected 0 == ({ extern uint8_t __dtbo_kunit_clk_parent_data_test_begin[]; extern uint8_t __dtbo_kunit_clk_parent_data_test_end[]; __of_overlay_apply_kunit((test), __dtbo_kunit_clk_parent_data_test_begin, __dtbo_kunit_clk_parent_data_test_end); }), but > [ 20.480160] ({ extern uint8_t __dtbo_kunit_clk_parent_data_test_begin[]; extern uint8_t __dtbo_kunit_clk_parent_data_test_end[]; __of_overlay_apply_kunit((test), __dtbo_kunit_clk_parent_data_test_begin, __dtbo_kunit_clk_parent_data_test_end); }) == -22 (0xffffffffffffffea) > [ 20.481513] not ok 3 clk_parent_data_of_name_test > [ 20.483711] OF: overlay: find target, node: /fragment@0, path '/' not found > [ 20.483878] OF: overlay: init_overlay_changeset() failed, ret = -22 > [ 20.484100] # clk_register_clk_parent_data_of_test: ASSERTION FAILED at drivers/clk/clk_test.c:2760 > [ 20.484100] Expected 0 == ({ extern uint8_t __dtbo_kunit_clk_parent_data_test_begin[]; extern uint8_t __dtbo_kunit_clk_parent_data_test_end[]; __of_overlay_apply_kunit((test), __dtbo_kunit_clk_parent_data_test_begin, __dtbo_kunit_clk_parent_data_test_end); }), but > [ 20.484100] ({ extern uint8_t __dtbo_kunit_clk_parent_data_test_begin[]; extern uint8_t __dtbo_kunit_clk_parent_data_test_end[]; __of_overlay_apply_kunit((test), __dtbo_kunit_clk_parent_data_test_begin, __dtbo_kunit_clk_parent_data_test_end); }) == -22 (0xffffffffffffffea) > [ 20.485444] not ok 4 clk_parent_data_of_fwname_name_test > [ 20.487432] OF: overlay: find target, node: /fragment@0, path '/' not found > [ 20.487600] OF: overlay: init_overlay_changeset() failed, ret = -22 > [ 20.487841] # clk_register_clk_parent_data_of_test: ASSERTION FAILED at drivers/clk/clk_test.c:2760 > [ 20.487841] Expected 0 == ({ extern uint8_t __dtbo_kunit_clk_parent_data_test_begin[]; extern uint8_t __dtbo_kunit_clk_parent_data_test_end[]; __of_overlay_apply_kunit((test), __dtbo_kunit_clk_parent_data_test_begin, __dtbo_kunit_clk_parent_data_test_end); }), but > [ 20.487841] ({ extern uint8_t __dtbo_kunit_clk_parent_data_test_begin[]; extern uint8_t __dtbo_kunit_clk_parent_data_test_end[]; __of_overlay_apply_kunit((test), __dtbo_kunit_clk_parent_data_test_begin, __dtbo_kunit_clk_parent_data_test_end); }) == -22 (0xffffffffffffffea) > [ 20.489207] not ok 5 clk_parent_data_of_index_name_priority_test > [ 20.490998] OF: overlay: find target, node: /fragment@0, path '/' not found > [ 20.491504] OF: overlay: init_overlay_changeset() failed, ret = -22 > [ 20.491725] # clk_register_clk_parent_data_of_test: ASSERTION FAILED at drivers/clk/clk_test.c:2760 > [ 20.491725] Expected 0 == ({ extern uint8_t __dtbo_kunit_clk_parent_data_test_begin[]; extern uint8_t __dtbo_kunit_clk_parent_data_test_end[]; __of_overlay_apply_kunit((test), __dtbo_kunit_clk_parent_data_test_begin, __dtbo_kunit_clk_parent_data_test_end); }), but > [ 20.491725] ({ extern uint8_t __dtbo_kunit_clk_parent_data_test_begin[]; extern uint8_t __dtbo_kunit_clk_parent_data_test_end[]; __of_overlay_apply_kunit((test), __dtbo_kunit_clk_parent_data_test_begin, __dtbo_kunit_clk_parent_data_test_end); }) == -22 (0xffffffffffffffea) > [ 20.493053] not ok 6 clk_parent_data_of_index_fwname_name_priority_test > [ 20.493583] # clk_register_clk_parent_data_of_test: pass:0 fail:6 skip:0 total:6 > [ 20.493701] not ok 1 clk_register_clk_parent_data_of_test > [ 20.493822] # clk_register_clk_parent_data_of: pass:0 fail:1 skip:0 total:1 > [ 20.493920] # Totals: pass:0 fail:6 skip:0 total:6 > [ 20.494032] not ok 49 clk_register_clk_parent_data_of