From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
<linux-hardening@vger.kernel.org>, <llvm@lists.linux.dev>,
<patches@lists.linux.dev>
Subject: Re: [PATCH] hardening: Require clang 20.1.0 for __counted_by
Date: Mon, 11 Aug 2025 16:21:32 +0200 [thread overview]
Message-ID: <a9c64598-41e9-4ec8-8ec1-add5a5f903b4@intel.com> (raw)
In-Reply-To: <20250807-fix-counted_by-clang-19-v1-1-902c86c1d515@kernel.org>
From: Nathan Chancellor <nathan@kernel.org>
Date: Thu, 07 Aug 2025 14:36:28 -0700
> After an innocuous change in -next that modified a structure that
> contains __counted_by, clang-19 start crashing when building certain
> files in drivers/gpu/drm/xe. When assertions are enabled, the more
> descriptive failure is:
>
> clang: clang/lib/AST/RecordLayoutBuilder.cpp:3335: const ASTRecordLayout &clang::ASTContext::getASTRecordLayout(const RecordDecl *) const: Assertion `D && "Cannot get layout of forward declarations!"' failed.
>
> According to a reverse bisect, a tangential change to the LLVM IR
> generation phase of clang during the LLVM 20 development cycle [1]
> resolves this problem. Bump the version of clang that enables
> CONFIG_CC_HAS_COUNTED_BY to 20.1.0 to ensure that this issue cannot be
> hit.
Any chance for this to go to the next 19.x (if it's planned at all)?
I always use the latest HEAD from llvm-project, but 19 is still widely
used across distros etc =\
>
> Link: https://github.com/llvm/llvm-project/commit/160fb1121cdf703c3ef5e61fb26c5659eb581489 [1]
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
> Should this be marked for stable? If this makes 6.17 final, I think we
> are fine for mainline and newer but I wonder if a patch that adds
> __counted_by to a structure would ever be backported and expose this
> problem there.
Thanks,
Olek
next prev parent reply other threads:[~2025-08-11 14:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 21:36 [PATCH] hardening: Require clang 20.1.0 for __counted_by Nathan Chancellor
2025-08-07 22:12 ` Justin Stitt
2025-08-11 14:21 ` Alexander Lobakin [this message]
2025-08-11 21:09 ` Nathan Chancellor
2025-08-12 16:28 ` Alexander Lobakin
2025-08-12 21:23 ` Nathan Chancellor
2025-08-25 13:25 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9c64598-41e9-4ec8-8ec1-add5a5f903b4@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=gustavoars@kernel.org \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=patches@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).