From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E4C528F526 for ; Mon, 28 Apr 2025 17:28:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745861340; cv=none; b=LId8X2KiNsxHAVzlbQ5akTeQ/qas0/+mWXC6x6YVCjuoJ6GODpw4Z03PgnR17bBxqa9ywJUwJpgx/ya5BWC5yaAjQjUkW3o4VzBTpoZA8gklguL8l1fWiVrM8isjT7u0OJE0HGpxPli+kzTh0J81HresO3YaFbT+z7ECMv2e5OE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745861340; c=relaxed/simple; bh=hvj8x3HVmp9P+1p1D0eDo1pbK3RjBLaMP05027S3Y0o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Kt3hQcQ57pAdPi8fQVnWBVhLY/pjVw8ou5hNHIndXdbIs9RXAjXOHk9HEgWTm3XSim0TVLMwcVHEIaBanS52fn5/Z4varY8xMHPT28gR2+8YAf555e/EGSId2YP62pA5ot1XN4wq0/Iqx1mp/ilFMmyOvTzi7/mTxPnfKrKHQ4g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=zaBN/XtW; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="zaBN/XtW" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2240aad70f2so15575ad.0 for ; Mon, 28 Apr 2025 10:28:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1745861338; x=1746466138; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=l0r7+wCllJmaKxCe01hHV/d2aOrZfvhrAsuNMyHCgYc=; b=zaBN/XtWQQ8O2zKJUMkuAhCYqOxBjopEQdXBG6lnc+ENsRWmHlR/sf0/TRDLKCbB9U gZm0MDLzOBHlkSQsRpILV9Kpv26xYRljtWQTD6Dgs/rMD0A+4PZ0csBDN5BcGUqWLYty 29iQpsKQPsH7r3xl3XFjG74r+oOeo2o26gXseLgI9uhC8atdli3lVFxWFnM73OKEwD/U Gz+B7XLpRSzJZJmEY/WlkYVgeMhI43p5GL5SoiHeDprcx+f+bkfGfxgLKylSlf+Uzcsf R/N6v545gWu+vlG6E39xnYWqmIR5qlQYYCAE4pyhsKgPZQH5Nw/RANDII2TNT46tdvL9 k6HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745861338; x=1746466138; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=l0r7+wCllJmaKxCe01hHV/d2aOrZfvhrAsuNMyHCgYc=; b=RbHAygvv8Ex5NA3yGey/o7FunH5jT+APSztHb+kJFEIyOUoPgawOPXrt0IefUTrNJW bzMsd/L2sg22D1AAx7mclnRd9kF5smjLCCKgsleJVOYAvGJZAHvCRbSzAAMUKyTexPbt d/DXSzZgIBF1OpLcbFzzp5TQ/Ve6UkdMUljwUyyvrPYGgFSlDcyk47jhUtv3g5QRYWJY osgkG5Sfbg3ec4eW73kNfanpqnjLJZVFm36oydV8te1JpbrS0uvvO1ip77UrVEvZrQa8 qoh2cbVvE+ULxgv8N3AjerDLWrnzXpKx3GD/HuhZNFcfBev3DXxxS1AeEL3ET8OGbWj4 vV6Q== X-Forwarded-Encrypted: i=1; AJvYcCUxYMPKUXvT6U2mlKzmdHbLsA1qmw6YZj+jyfJLm1F0BE6ZtdOPjAnF4xrEFprltY6sDEp06CJ9@lists.linux.dev X-Gm-Message-State: AOJu0YwCo0Y8SAg/TYdSDHN4BL8Cb/zLz0jFJJOEPJ7VWrq8EgGF7GVp Ypkzb7Vd4/kDdPsldszDgrdkXuKBKiG5aYyu3Kpbr59h/6wDtBVC5at75QSgOg== X-Gm-Gg: ASbGncso4cEs0PJX4DiqcjngpM0pwHfOAF9s6fcgG4qAjBvbCpSTlClowLuXHqPbjoh Hs0sWpa+RxXrXFXEVPoCnLqGWNwBlTh39uLX9k4okPCWmmr9zvOLnWMzzEq321yiR5iNkwMRjkm uvNGK9UF2Er9XrXDa3Fns/XV+AHrlgUCk2Z83L7MC/iLICw7gT3qOz1z3FZUZg2s6BswJWIClcg 2/mka3dmFwfLPdk3LYc6RcuDIpO7jOFZvbMzIGmhZhZ2LMbiUH2lA0DYLwEs3ascrtNvbv7yF6v S+0+TefrmBdAg+inVAq4UUb1yUsndjpjG5F8WrfmJVwdop73swRp9aT/CDPs1DC6PykAFWlF X-Google-Smtp-Source: AGHT+IFvvbXqVLW7M7K4eTP2s1tq5nZj/xJsE94cw7osWMiH1XhKOhdmN98bqT0YcPcDS66bSCITtg== X-Received: by 2002:a17:902:ea01:b0:21f:2ded:bfa0 with SMTP id d9443c01a7336-22de586f035mr708455ad.25.1745861337961; Mon, 28 Apr 2025 10:28:57 -0700 (PDT) Received: from google.com (2.210.143.34.bc.googleusercontent.com. [34.143.210.2]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-309ef061bccsm9296497a91.18.2025.04.28.10.28.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 10:28:57 -0700 (PDT) Date: Mon, 28 Apr 2025 17:28:46 +0000 From: Pranjal Shrivastava To: Nicolin Chen Cc: Baolu Lu , jgg@nvidia.com, kevin.tian@intel.com, corbet@lwn.net, will@kernel.org, bagasdotme@gmail.com, robin.murphy@arm.com, joro@8bytes.org, thierry.reding@gmail.com, vdumpa@nvidia.com, jonathanh@nvidia.com, shuah@kernel.org, jsnitsel@redhat.com, nathan@kernel.org, peterz@infradead.org, yi.l.liu@intel.com, mshavit@google.com, zhangzekun11@huawei.com, iommu@lists.linux.dev, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-kselftest@vger.kernel.org, patches@lists.linux.dev, mochs@nvidia.com, alok.a.tiwari@oracle.com, vasant.hegde@amd.com Subject: Re: [PATCH v2 02/22] iommu: Pass in a driver-level user data structure to viommu_alloc op Message-ID: References: Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Apr 28, 2025 at 10:19:21AM -0700, Nicolin Chen wrote: > On Sun, Apr 27, 2025 at 02:31:54PM +0800, Baolu Lu wrote: > > On 4/26/25 13:57, Nicolin Chen wrote: > > > The new type of vIOMMU for tegra241-cmdqv needs to pass in a driver-level > > > data structure from user space via iommufd, so add a user_data to the op. > > > > > > Reviewed-by: Jason Gunthorpe > > > Signed-off-by: Nicolin Chen > > > > It would be better to add some words explaining what kind of user data > > can be passed when allocating a vIOMMU object and the reason why this > > might be necessary. > > > > Reviewed-by: Lu Baolu > > Sure. Will do something like this: > > The new type of vIOMMU for tegra241-cmdqv allows user space VM to use one > of its virtual command queue HW resources exclusively. This requires user > space to mmap the corresponding MMIO page from kernel space for direct HW > control. > > To forward the mmap info (vm_pgoff and size), iommufd should add a driver > specific data structure to the IOMMUFD_CMD_VIOMMU_ALLOC ioctl, for driver > to output the info (during the allocation) back to user space. > > Similar to the existing ioctls and their IOMMU handlers, add a user_data > to viommu_alloc op to bridge between iommufd and drivers. > Ack, with this change (addressing Lu's nit). Reviewed-by: Pranjal Shrivastava > Thanks > Nicolin