From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DD1F282EE for ; Mon, 16 Jun 2025 22:43:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750113813; cv=none; b=folExBYyvEdW6P1rlvlMt57Qu+Q666mXcdAfaCt5W7BnnONlhVix32dVg2/X7yZgDnAG1bLwD9Un0kYyMQ0EKuMD7OrFKBIz7C4fK6SuBERTL8rYvog3ra4CDCcclxI/bPHqHlK40/G/Y7JKY3f9XaF6hkZQenRrL4FB5htCGDU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750113813; c=relaxed/simple; bh=9VAhz6xNRMl911jOxUf9NXCD/sddwJ16lYh5+w/2mdk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hpUCiEJuMWBzS6ju5sweIZ6Q3lgoWEGjb/OVMwAKl+Qe5Syj0XEsg2X/6vmrv0NyYDoyHWf8lg7fyf919klYKKvMB8VoVZjSkGZK9PpGWDECh2/DyhsKPdmtuUN5wqKbt5w2SkAofeXkxrnMMZaE2OV6oOg5GK51zFK6/i2Z43w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=dC1AlO/3; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="dC1AlO/3" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-235e389599fso79965ad.0 for ; Mon, 16 Jun 2025 15:43:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1750113811; x=1750718611; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ymL8Mqhb7MuXq62tfegfyenrSBgHaY6RdOOoY9Vdrxo=; b=dC1AlO/3d0VDekh7LnporVabJQ/dC58Uf6QB7wxFQKB63t/ZHcxDcyE8VTDsTpPG3L YILla8k1CIvgCvPkiQQDviM2wY2gdv8pqq5xve2+zsACRjHkPMsSbYo7mrufmMLuIjUu U6KukieaMgaOgMDcMaeLMRhWjZLg1IC0W7eJacndFJbiFFQOoEodNplmQVoxuuoiZgVv PO8C7m18NZgg3XyxYR1EdYfG+XIetZUWTNiyWuWOrQnghG46aURgD4ik3H56N01N4cEV bZJ93X95I2NtiyYJbEOusCHx2U5+XpfX/+wkL4FZxOsXZYsvrFdo1KiPtGwsOZg3Ghob EBVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750113811; x=1750718611; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ymL8Mqhb7MuXq62tfegfyenrSBgHaY6RdOOoY9Vdrxo=; b=w0ox1wmRSeA3cqT9w9uU979XKc2n3R7Wu19GTBvHTKQKc0efKBZAFdw/mrYXoV4Y71 xM09JyReR//Yuqfdw+L5+iZfaPa20p7YLcJzinRRu5gLDAYeCb3Nl2YbQa3JXR2Y7cFe U/2J/nyW58MZ0J6nxdu/s+lT0u9bUEDB6hMmpescpGI2ljGydQsys3ZOtwF5DcUYZjCv VvjmlvyiNcZon5/mcpI7Vj/QoyfNzHdByWaKhfjKPjuSiY+ysC8TsSZJN+1OKg9lQBui hKuXDhuTKoK8+4g2HYGiJ04m13fY3nG3vCUIT4DOJSWoZ1TYK2/nklgsUTeDbekhnBGv z4zQ== X-Forwarded-Encrypted: i=1; AJvYcCWPYC+hoXvubLtalcyAIr+aqYdpuCoEHgVWPxweWJ8FngxiAVhG3L29V09MQgRQFEOE6RLBi9ow@lists.linux.dev X-Gm-Message-State: AOJu0YxYND2JncjYDu376nr/dD2rGr0VJzxCKGoxs7mlzR5eRmKfPbEO QYP66wKPFs0yG7VG6G4kB+Xn2czK69oaDWtZB8koENCjNE7v2wUfGa0NJj22CrnpBw== X-Gm-Gg: ASbGncv/s5ir50F0+opHL7ZxPItZ/tXFG1HUfPtT0Apbom3lvCC1bE+AHWFU80li/p2 VPMOoqNNltj9n//90Ppqaa38uNAQhTPMqzYSNrzwy0OdsG6/N7XJPOr926VU603G+DUAhMPFb23 7tPzHy6fCBwQtdWnojOl5056930DFtiQBaeYiMkoblQ5naIEajbbCA4l24RPblQBzpFxBS9vRjp vi0OMhjJsp2dT13QNX4IIA+toBkMbVFRyc4SoQutd17IRVGQKvZLVmwb2qzJDTPnR/WKuI8s0mz 8KSAk0XdJvuCrar1nHzPgoteMoQh6D/MxiPloA1HO4d/KxoWKx7IDdTc4SguHfpvlSQOZAxR8U7 zjlXSrnjG2AA4GGtzYAX/ X-Google-Smtp-Source: AGHT+IEkufL7OuATbKkyQmUkhfoeOlW/ZVbGbDv9YqSYwYKyZQFbECA2k6ko4G5Q+boO/eTGgvXo1g== X-Received: by 2002:a17:902:d2c6:b0:234:a469:62ef with SMTP id d9443c01a7336-2366eda3363mr5460125ad.3.1750113811264; Mon, 16 Jun 2025 15:43:31 -0700 (PDT) Received: from google.com (232.98.126.34.bc.googleusercontent.com. [34.126.98.232]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-748900829f7sm7357692b3a.87.2025.06.16.15.43.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 15:43:30 -0700 (PDT) Date: Mon, 16 Jun 2025 22:43:22 +0000 From: Pranjal Shrivastava To: Nicolin Chen Cc: jgg@nvidia.com, kevin.tian@intel.com, will@kernel.org, robin.murphy@arm.com, joro@8bytes.org, yi.l.liu@intel.com, peterz@infradead.org, jsnitsel@redhat.com, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, patches@lists.linux.dev, baolu.lu@linux.intel.com Subject: Re: [PATCH v2 10/14] iommu/arm-smmu-v3: Replace arm_vsmmu_alloc with arm_vsmmu_init Message-ID: References: <64e4b4c33acd26e1bd676e077be80e00fb63f17c.1749882255.git.nicolinc@nvidia.com> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <64e4b4c33acd26e1bd676e077be80e00fb63f17c.1749882255.git.nicolinc@nvidia.com> On Fri, Jun 13, 2025 at 11:35:22PM -0700, Nicolin Chen wrote: > To ease the for-driver iommufd APIs, get_viommu_size and viommu_init ops > are introduced. > > Sanitize the inputs and report the size of struct arm_vsmmu on success, in > arm_smmu_get_viommu_size(). > > Place the type sanity at the last, becase there will be soon an impl level > get_viommu_size op, which will require the same sanity tests prior. It can > simply insert a piece of code in front of the IOMMU_VIOMMU_TYPE_ARM_SMMUV3 > sanity. > That's what I was wondering, so we plan to replace the impl->vsmmu_alloc op as well? > The core will ensure the viommu_type is set to the core vIOMMU object, and > pass in the same dev pointer, so arm_vsmmu_init() won't need to repeat the > same sanity tests but to simply init the arm_vsmmu struct. > > Remove the arm_vsmmu_alloc, completing the replacement. > > Signed-off-by: Nicolin Chen > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 11 +++-- > .../arm/arm-smmu-v3/arm-smmu-v3-iommufd.c | 46 ++++++++++--------- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 3 +- > 3 files changed, 32 insertions(+), 28 deletions(-) > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h > index ea41d790463e..bb39af84e6b0 100644 > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h > @@ -1034,18 +1034,19 @@ struct arm_vsmmu { > > #if IS_ENABLED(CONFIG_ARM_SMMU_V3_IOMMUFD) > void *arm_smmu_hw_info(struct device *dev, u32 *length, u32 *type); > -struct iommufd_viommu *arm_vsmmu_alloc(struct device *dev, > - struct iommu_domain *parent, > - struct iommufd_ctx *ictx, > - unsigned int viommu_type); > +size_t arm_smmu_get_viommu_size(struct device *dev, > + enum iommu_viommu_type viommu_type); > +int arm_vsmmu_init(struct iommufd_viommu *viommu, > + struct iommu_domain *parent_domain); > int arm_smmu_attach_prepare_vmaster(struct arm_smmu_attach_state *state, > struct arm_smmu_nested_domain *nested_domain); > void arm_smmu_attach_commit_vmaster(struct arm_smmu_attach_state *state); > void arm_smmu_master_clear_vmaster(struct arm_smmu_master *master); > int arm_vmaster_report_event(struct arm_smmu_vmaster *vmaster, u64 *evt); > #else > +#define arm_smmu_get_viommu_size NULL > #define arm_smmu_hw_info NULL > -#define arm_vsmmu_alloc NULL > +#define arm_vsmmu_init NULL > > static inline int > arm_smmu_attach_prepare_vmaster(struct arm_smmu_attach_state *state, > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-iommufd.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-iommufd.c > index e4fd8d522af8..9f59c95a254c 100644 > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-iommufd.c > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-iommufd.c > @@ -382,25 +382,14 @@ static const struct iommufd_viommu_ops arm_vsmmu_ops = { > .cache_invalidate = arm_vsmmu_cache_invalidate, > }; > > -struct iommufd_viommu *arm_vsmmu_alloc(struct device *dev, > - struct iommu_domain *parent, > - struct iommufd_ctx *ictx, > - unsigned int viommu_type) > +size_t arm_smmu_get_viommu_size(struct device *dev, > + enum iommu_viommu_type viommu_type) > { > - struct arm_smmu_device *smmu = > - iommu_get_iommu_dev(dev, struct arm_smmu_device, iommu); > struct arm_smmu_master *master = dev_iommu_priv_get(dev); > - struct arm_smmu_domain *s2_parent = to_smmu_domain(parent); > - struct arm_vsmmu *vsmmu; > - > - if (viommu_type != IOMMU_VIOMMU_TYPE_ARM_SMMUV3) > - return ERR_PTR(-EOPNOTSUPP); > + struct arm_smmu_device *smmu = master->smmu; > > if (!(smmu->features & ARM_SMMU_FEAT_NESTING)) > - return ERR_PTR(-EOPNOTSUPP); > - > - if (s2_parent->smmu != master->smmu) > - return ERR_PTR(-EINVAL); > + return 0; > > /* > * FORCE_SYNC is not set with FEAT_NESTING. Some study of the exact HW > @@ -408,7 +397,7 @@ struct iommufd_viommu *arm_vsmmu_alloc(struct device *dev, > * any change to remove this. > */ > if (WARN_ON(smmu->options & ARM_SMMU_OPT_CMDQ_FORCE_SYNC)) > - return ERR_PTR(-EOPNOTSUPP); > + return 0; > > /* > * Must support some way to prevent the VM from bypassing the cache > @@ -420,19 +409,32 @@ struct iommufd_viommu *arm_vsmmu_alloc(struct device *dev, > */ > if (!arm_smmu_master_canwbs(master) && > !(smmu->features & ARM_SMMU_FEAT_S2FWB)) > - return ERR_PTR(-EOPNOTSUPP); > + return 0; > > - vsmmu = iommufd_viommu_alloc(ictx, struct arm_vsmmu, core, > - &arm_vsmmu_ops); > - if (IS_ERR(vsmmu)) > - return ERR_CAST(vsmmu); > + if (viommu_type != IOMMU_VIOMMU_TYPE_ARM_SMMUV3) > + return 0; > + > + return VIOMMU_STRUCT_SIZE(struct arm_vsmmu, core); > +} > + > +int arm_vsmmu_init(struct iommufd_viommu *viommu, > + struct iommu_domain *parent_domain) > +{ > + struct arm_vsmmu *vsmmu = container_of(viommu, struct arm_vsmmu, core); > + struct arm_smmu_device *smmu = > + container_of(viommu->iommu_dev, struct arm_smmu_device, iommu); > + struct arm_smmu_domain *s2_parent = to_smmu_domain(parent_domain); > + > + if (s2_parent->smmu != smmu) > + return -EINVAL; > > vsmmu->smmu = smmu; > vsmmu->s2_parent = s2_parent; > /* FIXME Move VMID allocation from the S2 domain allocation to here */ > vsmmu->vmid = s2_parent->s2_cfg.vmid; > > - return &vsmmu->core; > + viommu->ops = &arm_vsmmu_ops; > + return 0; > } Seems much better now that the driver doesn't need to callback to the core for allocating viommu. One quick question though I see we've removed the following too: if (master->smmu->impl_ops &&master->smmu->impl_ops->vsmmu_alloc) vsmmu = master->smmu->impl_ops->vsmmu_alloc( master->smmu, s2_parent, ictx, viommu_type, user_data); Not sure why don't I see that in the diffs.. do we plan to split this into an impl-specific size and init too? > > int arm_vmaster_report_event(struct arm_smmu_vmaster *vmaster, u64 *evt) > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > index 10cc6dc26b7b..181d07bc1a9d 100644 > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > @@ -3688,7 +3688,8 @@ static struct iommu_ops arm_smmu_ops = { > .get_resv_regions = arm_smmu_get_resv_regions, > .page_response = arm_smmu_page_response, > .def_domain_type = arm_smmu_def_domain_type, > - .viommu_alloc = arm_vsmmu_alloc, > + .get_viommu_size = arm_smmu_get_viommu_size, > + .viommu_init = arm_vsmmu_init, > .user_pasid_table = 1, > .pgsize_bitmap = -1UL, /* Restricted during device attach */ > .owner = THIS_MODULE, > -- > 2.43.0 > With that, Reviewed-by: Pranjal Shrivastava