* [PATCH] rust: maple_tree: fix intra-doc link
@ 2025-09-10 14:02 Miguel Ojeda
2025-09-12 8:07 ` Alice Ryhl
2025-09-21 9:27 ` Miguel Ojeda
0 siblings, 2 replies; 3+ messages in thread
From: Miguel Ojeda @ 2025-09-10 14:02 UTC (permalink / raw)
To: Liam R . Howlett, Miguel Ojeda, Alex Gaynor
Cc: Alice Ryhl, Andrew Ballance, maple-tree, linux-mm, Boqun Feng,
Gary Guo, Björn Roy Baron, Benno Lossin, Andreas Hindborg,
Trevor Gross, Danilo Krummrich, rust-for-linux, linux-kernel,
patches
A couple `Occupied` intra-doc links are broken:
error: unresolved link to `Occupied`
--> rust/kernel/maple_tree.rs:96:46
|
96 | /// return an [`InsertError`] with the [`Occupied`] kind. It may also fail if memory
| ^^^^^^^^ no item named `Occupied` in scope
|
= help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
= note: `-D rustdoc::broken-intra-doc-links` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(rustdoc::broken_intra_doc_links)]`
error: unresolved link to `Occupied`
--> rust/kernel/maple_tree.rs:135:36
|
135 | /// [`InsertError`] with the [`Occupied`] kind. It may also fail if memory allocation fails
| ^^^^^^^^ no item named `Occupied` in scope
|
= help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
Thus fix them.
Fixes: 7f51d867d2ed ("rust: maple_tree: add MapleTree")
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
---
Andrew: as usual, please feel free to rebase if that is what you
normally do, of course. This was in next-20250910. Thanks!
rust/kernel/maple_tree.rs | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/rust/kernel/maple_tree.rs b/rust/kernel/maple_tree.rs
index 31b6c13d08ef..e72eec56bf57 100644
--- a/rust/kernel/maple_tree.rs
+++ b/rust/kernel/maple_tree.rs
@@ -93,8 +93,7 @@ pub fn new() -> impl PinInit<Self> {
/// # Errors
///
/// If the maple tree already contains a range using the given index, then this call will
- /// return an [`InsertError`] with the [`Occupied`] kind. It may also fail if memory
- /// allocation fails.
+ /// return an [`InsertErrorKind::Occupied`]. It may also fail if memory allocation fails.
///
/// # Examples
///
@@ -132,8 +131,8 @@ pub fn insert(&self, index: usize, value: T, gfp: Flags) -> Result<(), InsertErr
/// # Errors
///
/// If the maple tree already contains an overlapping range, then this call will return an
- /// [`InsertError`] with the [`Occupied`] kind. It may also fail if memory allocation fails
- /// or if the requested range is invalid (e.g. empty).
+ /// [`InsertErrorKind::Occupied`]. It may also fail if memory allocation fails or if the
+ /// requested range is invalid (e.g. empty).
///
/// # Examples
///
base-commit: a3bff28df80b33386863823262550491155e896b
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rust: maple_tree: fix intra-doc link
2025-09-10 14:02 [PATCH] rust: maple_tree: fix intra-doc link Miguel Ojeda
@ 2025-09-12 8:07 ` Alice Ryhl
2025-09-21 9:27 ` Miguel Ojeda
1 sibling, 0 replies; 3+ messages in thread
From: Alice Ryhl @ 2025-09-12 8:07 UTC (permalink / raw)
To: Miguel Ojeda
Cc: Liam R . Howlett, Alex Gaynor, Andrew Ballance, maple-tree,
linux-mm, Boqun Feng, Gary Guo, Björn Roy Baron,
Benno Lossin, Andreas Hindborg, Trevor Gross, Danilo Krummrich,
rust-for-linux, linux-kernel, patches
On Wed, Sep 10, 2025 at 04:02:12PM +0200, Miguel Ojeda wrote:
> A couple `Occupied` intra-doc links are broken:
>
> error: unresolved link to `Occupied`
> --> rust/kernel/maple_tree.rs:96:46
> |
> 96 | /// return an [`InsertError`] with the [`Occupied`] kind. It may also fail if memory
> | ^^^^^^^^ no item named `Occupied` in scope
> |
> = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
> = note: `-D rustdoc::broken-intra-doc-links` implied by `-D warnings`
> = help: to override `-D warnings` add `#[allow(rustdoc::broken_intra_doc_links)]`
>
> error: unresolved link to `Occupied`
> --> rust/kernel/maple_tree.rs:135:36
> |
> 135 | /// [`InsertError`] with the [`Occupied`] kind. It may also fail if memory allocation fails
> | ^^^^^^^^ no item named `Occupied` in scope
> |
> = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
>
> Thus fix them.
>
> Fixes: 7f51d867d2ed ("rust: maple_tree: add MapleTree")
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rust: maple_tree: fix intra-doc link
2025-09-10 14:02 [PATCH] rust: maple_tree: fix intra-doc link Miguel Ojeda
2025-09-12 8:07 ` Alice Ryhl
@ 2025-09-21 9:27 ` Miguel Ojeda
1 sibling, 0 replies; 3+ messages in thread
From: Miguel Ojeda @ 2025-09-21 9:27 UTC (permalink / raw)
To: Miguel Ojeda, Andrew Morton
Cc: Liam R . Howlett, Alex Gaynor, Alice Ryhl, Andrew Ballance,
maple-tree, linux-mm, Boqun Feng, Gary Guo, Björn Roy Baron,
Benno Lossin, Andreas Hindborg, Trevor Gross, Danilo Krummrich,
rust-for-linux, linux-kernel, patches
On Wed, Sep 10, 2025 at 4:02 PM Miguel Ojeda <ojeda@kernel.org> wrote:
>
> Andrew: as usual, please feel free to rebase if that is what you
> normally do, of course. This was in next-20250910. Thanks!
(Somehow I didn't Cc akpm -- doing it now.)
Could this be picked up? It blocks generation of docs for linux-next. Thanks!
By the way, there was a rebase -- the tag should now be:
Fixes: 6a25c101c7a2 ("rust: maple_tree: add MapleTree")
Cheers,
Miguel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-21 9:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-10 14:02 [PATCH] rust: maple_tree: fix intra-doc link Miguel Ojeda
2025-09-12 8:07 ` Alice Ryhl
2025-09-21 9:27 ` Miguel Ojeda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).