public inbox for patches@lists.linux.dev
 help / color / mirror / Atom feed
From: "Luck, Tony" <tony.luck@intel.com>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: Fenghua Yu <fenghuay@nvidia.com>,
	Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
	Peter Newman <peternewman@google.com>,
	James Morse <james.morse@arm.com>,
	Babu Moger <babu.moger@amd.com>,
	"Drew Fustini" <dfustini@baylibre.com>,
	Dave Martin <Dave.Martin@arm.com>, Chen Yu <yu.c.chen@intel.com>,
	David E Box <david.e.box@intel.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>, <patches@lists.linux.dev>
Subject: Re: [PATCH v4 5/7] x86/resctrl: Resolve PMT and TPMI symbols at runtime
Date: Tue, 7 Apr 2026 13:33:08 -0700	[thread overview]
Message-ID: <adVqBP2JIWaT777T@agluck-desk3> (raw)
In-Reply-To: <2d1cb9b7-2f75-48c3-88d3-3c2419298e5d@intel.com>

On Tue, Apr 07, 2026 at 11:40:49AM -0700, Reinette Chatre wrote:
> Hi Tony,
> 
> On 4/7/26 11:13 AM, Luck, Tony wrote:
> ...
> > Adding a "resctrl" line to /etc/fstab attempts the mount at 39.667. Three
> > seconds too early. No PMT events are found, and code in this V4 version
> > of the patch series marks the system as AET_NOT_PRESENT and will never
> > look again :-(
> > 
> > I can drop the AET_NOT_PRESENT state so that a retry will succeed. I don't
> > see another fix other than to document this limitation.
> > 
> > Workarounds are:
> > 1) Change the CONFIG to build pmt_telemetry into the kernel (where we
> >    are today, but haven't heard from Linux distros like Red Hat, SUSE etc.
> >    on whether this is acceptable.)
> > 2) Delay mounting the resctrl file system.
> 
> As I mentioned in https://lore.kernel.org/lkml/e85cd466-2202-4b40-82ed-91e421d8e073@intel.com/
> I find (2) to be a poor user interface since it (a) requires user space to
> somehow know that the system supports AET and then (b) either delay for some
> indeterminate time or repetitively (for some indeterminate count) remount resctrl
> to obtain needed features. 
> 
> Considering all the complications, could you please provide the motivation
> for this series? I should have checked for this first. The cover letter does not
> contain this information.

Reinette,

I'm concerned that AET will not be available in Linux distros. The beta for
Ubuntu 26.04 is available. I downloaded the iso and booted. It has the v7.0
kernel, so AET is in the source. But checking the config I see:

   ubuntu@ubuntu:/boot$ grep VSEC config-7.0.0-10-generic
   CONFIG_INTEL_VSEC=m
   ubuntu@ubuntu:/boot$ grep INTEL_PMT config-7.0.0-10-generic
   CONFIG_INTEL_PMT_CLASS=m
   CONFIG_INTEL_PMT_TELEMETRY=m
   CONFIG_INTEL_PMT_CRASHLOG=m
   CONFIG_INTEL_PMT_DISCOVERY=m
   ubuntu@ubuntu:/boot$ grep AET config-7.0.0-10-generic
   ubuntu@ubuntu:/boot$

The default for most distributions is to build as much as possible as
modules. So I expect to see the same when Fedora, Red Hat, SUSE.

Even our internal intel-next daily builds are configuring modules (I did
get them to switch the relevant modules to built-in for one release cycle.
But they feel they should match what is done in production systems, so
they have switched back.

-Tony

  reply	other threads:[~2026-04-07 20:33 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-30 21:43 [PATCH v4 0/7] Allow AET to use PMT/TPMI as loadable modules Tony Luck
2026-03-30 21:43 ` [PATCH v4 1/7] platform/x86/intel/pmt: Export PMT enumeration functions as GPL Tony Luck
2026-04-04  0:00   ` Reinette Chatre
2026-04-06 18:07     ` David Box
2026-04-08  5:07   ` Christoph Hellwig
2026-04-08 17:01     ` Luck, Tony
2026-04-09  5:41       ` Christoph Hellwig
2026-03-30 21:43 ` [PATCH v4 2/7] x86/resctrl: Drop setting of event_group::force_off when insufficient RMIDs Tony Luck
2026-04-04  0:01   ` Reinette Chatre
2026-03-30 21:43 ` [PATCH v4 3/7] fs/resctrl: Add interface to disable a monitor event Tony Luck
2026-04-04  0:03   ` Reinette Chatre
2026-04-06 18:35     ` Luck, Tony
2026-04-06 21:13       ` Reinette Chatre
2026-04-07 18:40         ` Luck, Tony
2026-04-07 23:10           ` Reinette Chatre
2026-03-30 21:43 ` [PATCH v4 4/7] fs,x86/resctrl: Add architecture hooks for every mount/unmount Tony Luck
2026-04-04  0:52   ` Reinette Chatre
2026-04-06 20:35     ` Luck, Tony
2026-04-06 21:16       ` Reinette Chatre
2026-04-09 20:35         ` Luck, Tony
2026-04-10 15:16           ` Reinette Chatre
2026-04-10 18:59             ` Luck, Tony
2026-04-10 21:21               ` Reinette Chatre
2026-04-10 23:03                 ` Luck, Tony
2026-03-30 21:43 ` [PATCH v4 5/7] x86/resctrl: Resolve PMT and TPMI symbols at runtime Tony Luck
2026-04-04  0:56   ` Reinette Chatre
2026-04-07 18:13     ` Luck, Tony
2026-04-07 18:40       ` Reinette Chatre
2026-04-07 20:33         ` Luck, Tony [this message]
2026-03-30 21:43 ` [PATCH v4 6/7] x86/resctrl: Delete intel_aet_exit() Tony Luck
2026-03-30 21:43 ` [PATCH v4 7/7] x86/resctrl: Downgrade dependency of AET on INTEL_PMT Tony Luck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adVqBP2JIWaT777T@agluck-desk3 \
    --to=tony.luck@intel.com \
    --cc=Dave.Martin@arm.com \
    --cc=babu.moger@amd.com \
    --cc=david.e.box@intel.com \
    --cc=dfustini@baylibre.com \
    --cc=fenghuay@nvidia.com \
    --cc=james.morse@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maciej.wieczor-retman@intel.com \
    --cc=patches@lists.linux.dev \
    --cc=peternewman@google.com \
    --cc=reinette.chatre@intel.com \
    --cc=x86@kernel.org \
    --cc=yu.c.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox