From: Christoph Hellwig <hch@infradead.org>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Fenghua Yu <fenghuay@nvidia.com>,
"Chatre, Reinette" <reinette.chatre@intel.com>,
"Wieczor-Retman, Maciej" <maciej.wieczor-retman@intel.com>,
Peter Newman <peternewman@google.com>,
James Morse <james.morse@arm.com>,
Babu Moger <babu.moger@amd.com>,
Drew Fustini <dfustini@baylibre.com>,
Dave Martin <Dave.Martin@arm.com>,
"Chen, Yu C" <yu.c.chen@intel.com>,
"Box, David E" <david.e.box@intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"patches@lists.linux.dev" <patches@lists.linux.dev>
Subject: Re: [PATCH v4 1/7] platform/x86/intel/pmt: Export PMT enumeration functions as GPL
Date: Wed, 8 Apr 2026 22:41:25 -0700 [thread overview]
Message-ID: <adc8BWwX2xZOlO3_@infradead.org> (raw)
In-Reply-To: <SJ1PR11MB6083ECB77F9AC85C2E8F94F0FC5B2@SJ1PR11MB6083.namprd11.prod.outlook.com>
On Wed, Apr 08, 2026 at 05:01:54PM +0000, Luck, Tony wrote:
> >> The symbol_get() function requires that objects be GPL licensed.
> >
> > Please don't add new uses of symbol_get, as we've been slowly trying
> > to kill it off. If you have bidirectional dependencies just add an
> > registration module in the middle to resolve it.
>
> In my case I have "resctrl" (which is built-in, and likely to stay that way) that
> needs functions from the "pmt_discovery" module to enumerate which
> event counters are present.
>
> Should I add EXPORT_SYMBOL_GPL(some registration function) to resctrl
>
> and have the pmt_discovery code call that to provide pointers to resctrl?
Yes, if your dependency only goes one-way against the normal flow,
that's by far the easiest. Bonus point for bounding that registration
on an object fitting the natural scope through OF/fwnode/acpi_dev or
whatever fits here.
next prev parent reply other threads:[~2026-04-09 5:41 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 21:43 [PATCH v4 0/7] Allow AET to use PMT/TPMI as loadable modules Tony Luck
2026-03-30 21:43 ` [PATCH v4 1/7] platform/x86/intel/pmt: Export PMT enumeration functions as GPL Tony Luck
2026-04-04 0:00 ` Reinette Chatre
2026-04-06 18:07 ` David Box
2026-04-08 5:07 ` Christoph Hellwig
2026-04-08 17:01 ` Luck, Tony
2026-04-09 5:41 ` Christoph Hellwig [this message]
2026-03-30 21:43 ` [PATCH v4 2/7] x86/resctrl: Drop setting of event_group::force_off when insufficient RMIDs Tony Luck
2026-04-04 0:01 ` Reinette Chatre
2026-03-30 21:43 ` [PATCH v4 3/7] fs/resctrl: Add interface to disable a monitor event Tony Luck
2026-04-04 0:03 ` Reinette Chatre
2026-04-06 18:35 ` Luck, Tony
2026-04-06 21:13 ` Reinette Chatre
2026-04-07 18:40 ` Luck, Tony
2026-04-07 23:10 ` Reinette Chatre
2026-03-30 21:43 ` [PATCH v4 4/7] fs,x86/resctrl: Add architecture hooks for every mount/unmount Tony Luck
2026-04-04 0:52 ` Reinette Chatre
2026-04-06 20:35 ` Luck, Tony
2026-04-06 21:16 ` Reinette Chatre
2026-04-09 20:35 ` Luck, Tony
2026-04-10 15:16 ` Reinette Chatre
2026-04-10 18:59 ` Luck, Tony
2026-04-10 21:21 ` Reinette Chatre
2026-04-10 23:03 ` Luck, Tony
2026-03-30 21:43 ` [PATCH v4 5/7] x86/resctrl: Resolve PMT and TPMI symbols at runtime Tony Luck
2026-04-04 0:56 ` Reinette Chatre
2026-04-07 18:13 ` Luck, Tony
2026-04-07 18:40 ` Reinette Chatre
2026-04-07 20:33 ` Luck, Tony
2026-03-30 21:43 ` [PATCH v4 6/7] x86/resctrl: Delete intel_aet_exit() Tony Luck
2026-03-30 21:43 ` [PATCH v4 7/7] x86/resctrl: Downgrade dependency of AET on INTEL_PMT Tony Luck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adc8BWwX2xZOlO3_@infradead.org \
--to=hch@infradead.org \
--cc=Dave.Martin@arm.com \
--cc=babu.moger@amd.com \
--cc=david.e.box@intel.com \
--cc=dfustini@baylibre.com \
--cc=fenghuay@nvidia.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=patches@lists.linux.dev \
--cc=peternewman@google.com \
--cc=reinette.chatre@intel.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox