From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 074093254B3 for ; Sun, 10 May 2026 19:00:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778439607; cv=none; b=Rik5I2Bq5+HfynhWr1w95KuA61VdMFiaxiDDg/kZSTb2u53IZstI817Z+pLOC0huKWwLYSEDG6JKIcRtgR/EeNiKSHZ1QUdZ0jPVR7Fjez+GK7+dPh8jdGJP0mpY1dfW8Ng3aFeMsWOS0DFtyyhcZW4WhTl691Q+f9W/f3AiyrM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778439607; c=relaxed/simple; bh=Bvc212FwGt0vxmNS1oiSrfkzUZX2D+Zt999xDLx+UQQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Li+4p7NrAtC2dhZG49mGgFGYbkyFuPG7noxkuFbNBUiIstUHjbUTmyF/+QRDvENd6oksvOqZHNTx06lBDejR0SkImqmClMSfklymyu4NpYYSsX29Dl4sk79BRjno5PdNXKArndH8a9Ip0Odx+EjcMkiJWtqnwJQDfmN9aATAaNE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=N6MDlr4j; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="N6MDlr4j" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2ba3b9bcf69so165ad.0 for ; Sun, 10 May 2026 12:00:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778439605; x=1779044405; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bMsfc8Zbf8JIkTQeMv/NJIxXAe3vZVoXdywLBqyZ2Qs=; b=N6MDlr4jkGBKZUFnFNMZoWq85jJbqoiUuaLXYkyg433Riuf77QzCI0cL0KdwzTVrHp 4+GpIjeyqvQ+83xml//9iL157IO+Hv+30S+p//ioiRQw2RZMC+0KAEre3G6N85EsR3Id FMY6XfpOAeYHEvscpt9MrYBAwa/1EJp5b4pL7Xk5ho1aCHJtU50pjnFt44AhSeF9I0Ki iKK1Sfqp3+Y+9/GLd8+0PEyNVsmHh7AF6OVgmQHlMvc2ZvpJTfiNE5vT3yXSCPHumMwO sud5ZazCsOEJVtEDDKCEUT8xecEdlZQkjmvQx8od9K5wgwF3ZXeDH/3r3S68pTiDRMmy +q9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778439605; x=1779044405; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bMsfc8Zbf8JIkTQeMv/NJIxXAe3vZVoXdywLBqyZ2Qs=; b=fzX8Y+uNIGS8T3wXzw2LcCybXNpNx1skKevphtZ+fLMMjjQbMqQd2oQuapkYhVh7an LD5eSbgftEoJzG96wfBt5fPUc9tfbKsN7tpMcjsFqnQAorrlpHP0Tyy5HYdMHbsJOKXn sn8fsx4d53xF1Xt/PByertR2YxVaBGxYJzoQVWZZUNfy77gI0ywI1hZNmQnwzykRuEfR kazQiL7we/TLDIbMvK9RumlUwTMH62AsZ1Ni+SXksN2Buq8QIph1OT8KFLkT8mLFjt/r p39aXHbSmuFmCpsM7tzY8Js1XL9I7sxZvkn4jyL4/TyzVD6JP6vr48jnmetSENn3WNGN TQDQ== X-Forwarded-Encrypted: i=1; AFNElJ/6e4pq1p/mQUoOWICALFpLw6FI3+0FJJFh8ln3EU3hKng9csugTIZmv1ng4Wqs8HMj67WYbhym@lists.linux.dev X-Gm-Message-State: AOJu0YwQce1KWlxGNtru5smzVrDNUyY8YtFqQT/y7F2jNacSGTp3gG42 wlH6PwTylN1gowCvBISmxVts3vAzu9fW/XJFuzang+ieAKp/P5UpX7v8RrAHEGUN6g== X-Gm-Gg: Acq92OGOvOAiMZdZvH/hl1yVmTHur3tf5vfWm+iGyUv+5veur8z4xaUbpW94ak9/lxZ oNGoa1QHOcJC6bMuhZaxPqDzJE/GMqkgfnefZUn7ZGDyrUtVp76A0TYOeFmCF9FD1Mqw1prC8wY UnJfsTTXdvFMqrqzJSQILKlNtIiOnl+MCQxg0qXCTk/QaW3THD9i5tJ9B293wVB/N2XaqBHMRFD ZKOiYiO+tc6Ts6BLh0aEQ1tak7rg5+SDtxcFyT4ctKEGCmhc4FkWKZMa6uA0LEnBLlf/afEtlPP DRRqGse+FvSVYjYLPe6JUyYBLH2GOyqES37uEDjB7AtOLdyql4FUQORtsl+QBEAtxKGg63pXzfa oaSxQs5jQR88bV8xsclVp3RjppX7CFDFagZCghUzXhkE1FiQH+hb41yA2SUraO+lq4a8H5KiIUX IOKpgTosZwqbrMRWrbHAEvrKLxe9GMDH16lG8638PY5I2Nuzwk8dAzt/CQWebA0JV02Rus X-Received: by 2002:a17:903:8ce:b0:2b4:641a:6b7c with SMTP id d9443c01a7336-2bc7868490cmr2499495ad.13.1778439604484; Sun, 10 May 2026 12:00:04 -0700 (PDT) Received: from google.com (44.234.124.34.bc.googleusercontent.com. [34.124.234.44]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-839685a8125sm18060689b3a.61.2026.05.10.12.00.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 May 2026 12:00:03 -0700 (PDT) Date: Sun, 10 May 2026 18:59:57 +0000 From: Pranjal Shrivastava To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Jonathan Hunter , Joerg Roedel , linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, Robin Murphy , Thierry Reding , Krishna Reddy , Will Deacon , David Matlack , Pasha Tatashin , patches@lists.linux.dev, Samiullah Khawaja , Mostafa Saleh Subject: Re: [PATCH 6/9] iommu/arm-smmu-v3: Directly encode simple commands Message-ID: References: <0-v1-b7dc0a0d4aa0+3723d-smmu_no_cmdq_ent_jgg@nvidia.com> <6-v1-b7dc0a0d4aa0+3723d-smmu_no_cmdq_ent_jgg@nvidia.com> <20260508173736.GH9254@nvidia.com> <20260508233629.GI9254@nvidia.com> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260508233629.GI9254@nvidia.com> On Fri, May 08, 2026 at 08:36:29PM -0300, Jason Gunthorpe wrote: > On Fri, May 08, 2026 at 08:09:33PM +0000, Pranjal Shrivastava wrote: > > > > > +static void arm_smmu_cmdq_batch_add_cmd_p(struct arm_smmu_device *smmu, > > > > > + struct arm_smmu_cmdq_batch *cmds, > > > > > + struct arm_smmu_cmd *cmd) > > > > > > > > Nit: Same here, why not __arm_smmu_cmdq_batch_add_cmd? I understand > > > > that _p just means we'll aceept ptr.. but the name's kinda wonky. > > > > > > Which becomes a fairly widly used public entry point, so I didn't want > > > to have the __ > > > > > > Though there is no external user of arm_smmu_cmdq_issue_cmd_p() > > > > > > > It's just that we're calling "arm_smmu_cmdq_batch_add_cmd_p" at one > > place and using `arm_smmu_make_cmd_` at the other. It makes > > one think what's "_p" in issue_cmd, only to realize "_p: pointer variant > > > > I guess I didn't like the new _p ones but I guess it's fine. Happy to > > leave it at your discretion. > > I don't much care for the _p (and yes it means pointer variation) but > do like it better than __ and failed to come up with another idea :) > Yea, I can't come up with much either (without __ or _p), maybe we could leave this as is.. The only alternatives in my mind are arm_smmu_cmdq_issue_cmd_ptr() which is similar. Thanks, Praan