From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 690F742E000 for ; Wed, 13 May 2026 17:48:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778694518; cv=none; b=Lad/A2sAJr86k0rSN+ekbZ1EcvxrMcpYspb0ZC5wneupa2TzHHDCDVVxwwf8+hgbqrvMqzCHWpERX8B+2GDJbr/TebQXOTWel5NDcW5jvDOcXoJxxYW3HQf1eSgHXvEoMe6dPaHos+G7lLxPfUjY1iY0HOTKkUa8Hq8VsVatOSI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778694518; c=relaxed/simple; bh=4XTXWoeBGoxsSNoPRmhV9IH/BD3AGgF+Q6dkrFYVktM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mtcSSiZZSsgWB+0CKG5d6zcevL4RvZOFo31mX/4E0qI84fHlxxmVPdizEGNMBAKcj417ZjFeNBZiNlsnWg8V4K1oBH5peXVk8uDwet+nVx+SOC3Sy9BGT9Fs/432OtS3YTrIcSfS3H7tkXogJkaeiLfiqSrMETh3FrTOT26cMTY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=XAYW4sVk; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XAYW4sVk" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2ba180a022dso4435ad.1 for ; Wed, 13 May 2026 10:48:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778694517; x=1779299317; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oxDXIXDykFSIYFprkEjbA73LH9dL5dkUsPQlXSJlaIw=; b=XAYW4sVkyLWRgY/z0hqZ0Vg8iExp420jSuPuT8ydjgrpgibcskLQfhz5tua1XAEW7c wYqzdwFwrGUjwH7Idb6rSNLIi6Vem/nWv4w8z/eR7yDD9lkuH9MXJozTisUdtI7duUSj NCSmit4xzDrd8nR5sKzRGPFtv5cqUkH9Y+KSGbK0hLIl2oACtjjxaCeeTbPPGauXWUzU evkGRBQMWWGliC2TzBWoZcztKwz75oxv/rkaK6pbGZMf48DyDXSXwBcIXTS0vRsCLvWY 2U1VRjUn0sKgASuJOmVWng6iAF9674QXAXbeVntH3pL0au5pyihNQ+GjvQsq+7yW1DIu zr5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778694517; x=1779299317; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oxDXIXDykFSIYFprkEjbA73LH9dL5dkUsPQlXSJlaIw=; b=AQLKT8/dGOuMJPSJBw4ZkM/WTQe5YMBY00mpRE03HGzZIUnYD3qNS+tnGH6Gt9ZaEt /7YdgixNy9wsMioZrK51O5RxYvhd4+4QzfxbwR11KrCJtaodJSPgUjo15eF5yvrZwe8g kpa57e6Oyg5Rg2PZ6xJLdZ9rUs24sLeHsCekBoUaP7AyQ2Rmw2jJrreJFgHuu3T0SIrh b1w2GqUDkiu9e8u0x/IefhQVJSQ0VqpdOuoqpMFf2jboj3D1KC8jzNo3emrPjNhmnjmk WbRI61x5zv8za3JMt7TGPw8Z1hGBeY8k9QA4w/ZDJxlz+dLpIrf6PZG/rxj6WIvhreZi W2HA== X-Forwarded-Encrypted: i=1; AFNElJ+KvPFfWBf4VtqTj/ZUgzmacUKSyV9J7vPWfP9wgtez6Bsv3Kht2FRRoaZhkgoSQG8TgRyR/pQD@lists.linux.dev X-Gm-Message-State: AOJu0Yw+nlzuJZp6KWYNtU79KAemMw4FTK4t8Iol1/gJwC5l436fzI+B FYETCS4/vE3i4UQMOxo0Ask2cTdH8BrjCSZoqvPvtPofE58sMrl1DhqDTHQvF22SuQ== X-Gm-Gg: Acq92OGHfp5ZCY+MM5KXtvsEtlKsPwH1w4tKOP+6WtaMNxcHuFcGhR8IItipbmF1mUz X7znqIEzlJ3fqtqPzKGtriK5I4CXd6h+9wYc0Q5ajevT+DcTS7sj8IRoBB2wwUUgTijD39I5nOo lYnY7kNm0BNSs6DY+XNzOn36/3pa0i0UOUh4GGXHOG6rz4TemlAhTKytydIp/uYCWJxLaQAsiPk 4hX0qh9jMo2+eoFVXBlKyfI1vhLGXL/9brfamCnSqVFkYTRPcHBAnkkY+5WaImyHx+n+NTAFmSS IY5LEak1PkAnZFHVs/M0Cm6oePulCeJZ9NftrM9Mfe662CWxPLICeik5G5mwkngsXD/PyBKz1xm L41ID6YfwUUVj0h/dOExPXlOunl1R8+lQymL/QdB9pqqfhYM+gHPcO/4CQeUN5LrYSKo6siGL0p mS0bCBeepZggLA+1wnVhruoOVQN3xRDqyeR0QyzvfHmhlm082F+GaPVWQa5eRpFSWMjsD0 X-Received: by 2002:a17:903:2a8d:b0:2ba:67f6:643a with SMTP id d9443c01a7336-2bd568fd5d4mr144045ad.11.1778694516241; Wed, 13 May 2026 10:48:36 -0700 (PDT) Received: from google.com (44.234.124.34.bc.googleusercontent.com. [34.124.234.44]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1e35ebesm178951275ad.43.2026.05.13.10.48.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 10:48:35 -0700 (PDT) Date: Wed, 13 May 2026 17:48:29 +0000 From: Pranjal Shrivastava To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Joerg Roedel , Robin Murphy , Will Deacon , Alejandro Jimenez , Lu Baolu , Joerg Roedel , Josua Mayer , Kevin Tian , Pasha Tatashin , patches@lists.linux.dev, Samiullah Khawaja , Mostafa Saleh , stable@vger.kernel.org Subject: Re: [PATCH rc 4/5] iommupt: Check for missing PAGE_SIZE in the pgsize_bitmap Message-ID: References: <0-v1-44b2fef88b25+d3-iommupt_map_rc_jgg@nvidia.com> <4-v1-44b2fef88b25+d3-iommupt_map_rc_jgg@nvidia.com> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4-v1-44b2fef88b25+d3-iommupt_map_rc_jgg@nvidia.com> On Tue, May 12, 2026 at 01:46:16PM -0300, Jason Gunthorpe wrote: > Sashiko pointed out that the driver could drop PAGE_SIZE from the > pgsize_bitmap. That is technically allowed but nothing does it, and > such an iommu_domain would not be used with the DMA API today. > > Still, it is against the design and it is trivial to fix up. Lift > the PT_WARN_ON to the if branch and just skip the fast path. > > Fixes: dcd6a011a8d5 ("iommupt: Add map_pages op") > Signed-off-by: Jason Gunthorpe Reviewed-by: Pranjal Shrivastava Thanks