Re: [RFC PATCH v1 08/11] PCI/TSM: Bind CTLV attestation to connected and locked contexts

[Jiri Pirko <jiri@resnulli.us>]

Wed, Oct 28, 2026 at 04:26:15PM +0100, aneesh.kumar@kernel.org wrote:

[..]

>+int ctlv_attestation_pci_state_get_action(void *priv, struct ctlv_op_ctx *ctx,
>+		const struct ctlv_cursor *request, struct ctlv_cursor *reply)
>+{
>+	struct pci_tsm_attestation *pa = priv;
>+	struct pci_dev *pdev = pa->pdev;
>+	struct pci_tsm *tsm = pdev->tsm;
>+	bool accepted = device_cc_accepted(&pdev->dev);
>+	bool ok = !pci_attestation_reply(pa, reply);
>+
>+	if (tsm && tsm->dsm_dev == pdev) {
>+		struct pci_tsm_pf0 *pf0 = container_of(tsm, struct pci_tsm_pf0, base_tsm);
>+
>+		accepted = pf0->stream_connected;
>+	}
>+
>+	ok &= ctlv_attestation_pci_pci_connected_put(reply, tsm && tsm->dsm_dev);
>+	ok &= ctlv_attestation_pci_pci_locked_put(reply, tsm && !tsm->dsm_dev);
>+	ok &= ctlv_attestation_pci_pci_accepted_put(reply, accepted);
>+
>+	if (tsm) {
>+		ok &= ctlv_attestation_pci_pci_tsm_id_put(reply, tsm->tsm_dev->id);
>+		if (tsm->dsm_dev)
>+			ok &= ctlv_attestation_pci_pci_dsm_put(reply, pci_name(tsm->dsm_dev));
>+	}


I had in mind SPDM_GET for DISCOVERED/AUTHENTICATED and the selected
authentication slot, with guest TDISP state coming from
DEVSEC_STATE_GET. Instance lifetime already follows connect/lock and
disconnect/unlock.

Could we use those state models instead of adding another PCI-specific
connected/locked/accepted model? Also, pci.generation appears to be the
common device-generation under another attribute name, not a separate
counter, odd.

[..]