Re: [PATCH v4 07/31] x86,fs/resctrl: Improve domain type checking

[Reinette Chatre <reinette.chatre@intel.com>]

Hi Tony,

On 4/28/25 5:33 PM, Tony Luck wrote:
>  
> +static inline bool check_domain_header(struct rdt_domain_hdr *hdr,
> +				       enum resctrl_domain_type type,
> +				       enum resctrl_res_level rid)
> +{
> +	return !!WARN_ON_ONCE(hdr->type != type || hdr->rid != rid);
> +}
> +

Please name the function to make the resulting code easier to read.  With
a name like "check_domain_header()" it is not obvious what a return of "true"
or "false" means. In this implementation "true" means that the header is
*invalid* so a "pass" of this check means that the header is invalid? This
sounds very confusing to me.

Names like "domain_header_valid()", or "domain_header_is_valid()" makes
the resulting code much easier to understand. Please do make it a goal
to make this work easy to understand, this series is complex.

Reinette