From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 2.mo576.mail-out.ovh.net (2.mo576.mail-out.ovh.net [178.33.251.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE0F415AE5 for ; Wed, 20 Sep 2023 12:59:29 +0000 (UTC) Received: from director9.ghost.mail-out.ovh.net (unknown [10.109.156.142]) by mo576.mail-out.ovh.net (Postfix) with ESMTP id C605021DB3 for ; Wed, 20 Sep 2023 12:49:15 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-m5sqf (unknown [10.110.115.217]) by director9.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 6BC341FE99; Wed, 20 Sep 2023 12:49:15 +0000 (UTC) Received: from RCM-web7.webmail.mail.ovh.net ([151.80.29.19]) by ghost-submission-6684bf9d7b-m5sqf with ESMTPSA id jf4+GEvqCmUMvwAAR9gfLA (envelope-from ); Wed, 20 Sep 2023 12:49:15 +0000 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Wed, 20 Sep 2023 14:49:15 +0200 From: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= To: Greg Kroah-Hartman Cc: stable@vger.kernel.org, patches@lists.linux.dev, Florian Fainelli , Sasha Levin Subject: Re: [PATCH 4.14 055/186] ARM: dts: BCM53573: Use updated "spi-gpio" binding properties In-Reply-To: <20230920112838.896837720@linuxfoundation.org> References: <20230920112836.799946261@linuxfoundation.org> <20230920112838.896837720@linuxfoundation.org> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: rafal@milecki.pl X-Originating-IP: 31.11.218.106 X-Webmail-UserID: rafal@milecki.pl Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 16882587628948400954 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedviedrudekfedgheeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepggffhffvvefujghffgfkgihitgfgsehtkehjtddtreejnecuhfhrohhmpeftrghfrghlucfoihhlvggtkhhiuceorhgrfhgrlhesmhhilhgvtghkihdrphhlqeenucggtffrrghtthgvrhhnpefghfeuiefhiedttedtheefhfeifeffveekvdegteetkeetjedtiedvvdfhgfffffenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecukfhppeduvdejrddtrddtrddupdefuddruddurddvudekrddutdeipdduhedurdektddrvdelrdduleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepoehrrghfrghlsehmihhlvggtkhhirdhplheqpdhnsggprhgtphhtthhopedupdhrtghpthhtohepphgrthgthhgvsheslhhishhtshdrlhhinhhugidruggvvhdpoffvtefjohhsthepmhhoheejiedpmhhouggvpehsmhhtphhouhht On 2023-09-20 13:29, Greg Kroah-Hartman wrote: > 4.14-stable review patch. If anyone has any objections, please let me > know. I already replied to the queuing e-mail but it was missed I guess. This patch should not get backported to the 4.14 due its dependencies. See below for more details. -------- Original Message -------- Subject: Re: Patch "ARM: dts: BCM53573: Use updated "spi-gpio" binding properties" has been added to the 4.14-stable tree Date: 2023-09-11 09:04 From: Rafał Miłecki To: Sasha Levin Cc: stable-commits@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley On 2023-09-09 01:47, Sasha Levin wrote: > This is a note to let you know that I've just added the patch titled > > ARM: dts: BCM53573: Use updated "spi-gpio" binding properties > > to the 4.14-stable tree which can be found at: > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > The filename of the patch is: > arm-dts-bcm53573-use-updated-spi-gpio-binding-proper.patch > and it can be found in the queue-4.14 subdirectory. > > If you, or anyone else, feels it should not be added to the stable > tree, > please let know about it. The new binding became part of Linux release 4.17-rc1 as a result of commits: 77a060533c04 ("spi: spi-gpio: Augment device tree bindings") 9b00bc7b901f ("spi: spi-gpio: Rewrite to use GPIO descriptors") Kernels older than 4.17-rc1 don't support new binding. This patch should NOT be backported to the 4.14. > commit 71f59fe710054f186fa145ba6134a95400585601 > Author: Rafał Miłecki > Date: Fri Jul 7 13:40:04 2023 +0200 > > ARM: dts: BCM53573: Use updated "spi-gpio" binding properties > > [ Upstream commit 2c0fd6b3d0778ceab40205315ccef74568490f17 ] > > Switch away from deprecated properties. > > This fixes: > arch/arm/boot/dts/broadcom/bcm947189acdbmr.dtb: spi: gpio-sck: > False schema does not allow [[3, 21, 0]] > From schema: > Documentation/devicetree/bindings/spi/spi-gpio.yaml > arch/arm/boot/dts/broadcom/bcm947189acdbmr.dtb: spi: gpio-miso: > False schema does not allow [[3, 22, 0]] > From schema: > Documentation/devicetree/bindings/spi/spi-gpio.yaml > arch/arm/boot/dts/broadcom/bcm947189acdbmr.dtb: spi: gpio-mosi: > False schema does not allow [[3, 23, 0]] > From schema: > Documentation/devicetree/bindings/spi/spi-gpio.yaml > arch/arm/boot/dts/broadcom/bcm947189acdbmr.dtb: spi: 'sck-gpios' > is a required property > From schema: > Documentation/devicetree/bindings/spi/spi-gpio.yaml > arch/arm/boot/dts/broadcom/bcm947189acdbmr.dtb: spi: Unevaluated > properties are not allowed ('gpio-miso', 'gpio-mosi', 'gpio-sck' were > unexpected) > From schema: > Documentation/devicetree/bindings/spi/spi-gpio.yaml > > Signed-off-by: Rafał Miłecki > Link: > https://lore.kernel.org/r/20230707114004.2740-4-zajec5@gmail.com > Signed-off-by: Florian Fainelli > Signed-off-by: Sasha Levin > > diff --git a/arch/arm/boot/dts/bcm947189acdbmr.dts > b/arch/arm/boot/dts/bcm947189acdbmr.dts > index ef263412fea51..02c916bedd281 100644 > --- a/arch/arm/boot/dts/bcm947189acdbmr.dts > +++ b/arch/arm/boot/dts/bcm947189acdbmr.dts > @@ -61,9 +61,9 @@ wps { > spi { > compatible = "spi-gpio"; > num-chipselects = <1>; > - gpio-sck = <&chipcommon 21 0>; > - gpio-miso = <&chipcommon 22 0>; > - gpio-mosi = <&chipcommon 23 0>; > + sck-gpios = <&chipcommon 21 0>; > + miso-gpios = <&chipcommon 22 0>; > + mosi-gpios = <&chipcommon 23 0>; > cs-gpios = <&chipcommon 24 0>; > #address-cells = <1>; > #size-cells = <0>; -- Rafał Miłecki