Re: [PATCH v7 18/31] x86/resctrl: Count valid telemetry aggregators per package

[Reinette Chatre <reinette.chatre@intel.com>]

Hi Tony,

On 7/11/25 4:53 PM, Tony Luck wrote:
> There may be multiple telemetry aggregators per package, each enumerated
> by a telemetry region structure in the feature group.
> 
> Scan the array of telemetry region structures and count how many are
> in each package in preparation to allocate structures to save the MMIO
> addresses for each in a convenient format for use when reading event
> counters.
> 
> Sanity check that the telemetry region structures have a valid
> package_id and that the size they report for the MMIO space is as

package_id -> package id

> large as expected from the XML description of the registers in
> the region.

The above two paragraphs seem to describe the actual flow backwards:
first is mentions that telemetry regions are counted (above implies that
all telemetry regions are counted, valid as well as invalid) and then how
to actually determine if a telemetry region is valid?
It will be less confusing to first describe how it is determined that a
telemetry region is valid and then it will be easier to explain that only
*valid* telemetry regions are counted?

> 
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---

Patch looks good.

Reinette