From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BFB728EA for ; Sat, 28 Sep 2024 00:08:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727482102; cv=none; b=oryDYetetuBxKVLwvfU1Nx8MaSb36KOM85bARvs3SChciamQFUzVfTO91enH8q593NjVIt8aycM1EuJJXONIV7R2oZ6mmXqsYZcfSEYOXoYT8yF6aK2r4KNvK2M2aMumP7Ki/4Oco615vZD1NzfC1uRERE9ahjwTAFLDQt7kaJg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727482102; c=relaxed/simple; bh=NZnaE/ubMUfBRZsNm92p9tvoV2sRkyx7S3yVGMv5jWQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=b7ZTffK91fDVCym/nY3E6UDc51BKhldYUL54K2alNUpocirjy3dIOKtiFPeSXtY8UI9zYlpWHK+DQnMQrEZ+tz8EpJgrvScOa7ERJF1Zp9MT7zjXYcbEBbblYj0BGGO9WtEAKMje99E7qaRrWMN7++hHhiBTPpY+xKj7KqxRMAE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MvDzy+3L; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MvDzy+3L" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-2e0d9b70455so766292a91.3 for ; Fri, 27 Sep 2024 17:08:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727482100; x=1728086900; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=x7Vj/jgke7ZDdOraXr0s4OljmEZuP6o5TRXDU6+8auE=; b=MvDzy+3LeCX8prfFnxkzstssfA6+tfd3xFTmk2js+e++4HguykaFb9DQbPUzrO56VR 0yMQCEZtpEF+vx08PkwwsNGRyquItienGgcoSSkOZroFspConf947C+t+VzbI+8xq1p0 XLEXLER9eOGxgFt6VpEdxeQ3rVCJbhr7IdCVr1amryBhHu9SGGnELCDKGP9JCMuyWDm4 zYBfltDX4MSakzFzxqOueSlpOlt5K2oKofgdOV5l8/qsSkYx0xL3oeSgAiJkBTZEqeb6 fFKJH5dlX2O867M1GYUqi9CuSGANHEBbKOwAC50okaIsxbRNx5DCSPeV0v/14/A+xSKg vuzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727482100; x=1728086900; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=x7Vj/jgke7ZDdOraXr0s4OljmEZuP6o5TRXDU6+8auE=; b=tqhTMenvWmIGONGIeLQSAbyQqDe9Bzx2UvczhGWiDxqjgEuzDkj5t8MnEBDe6wqwh4 2FEcopfK5xcF5ZgPCdbLtuO5mjpywKHqfN65yr4ssArlWQqsBVEOH21KTpEgMhrR3HdP 5t7r54P7JbwWNE5za1zVTsPYQI7PZ6Npx2n+ZPLoQjjkZzCv7qthqoX50Ec4LgmxsMOC 3QDWbyywujSLXmCNnRXCzRjb+93nrgNkb2lMACctV75MDwmuvISeGL98vzqYUtuZf7vG Uu6EyRaA7+LdwXiT6vlUqa0DyKqiLeUh0pJ/cFeYrnQdcKchkhFyzl7sbfShdN7ncLJH 1Fxw== X-Forwarded-Encrypted: i=1; AJvYcCW9aBEx3dkhYsu9XcbLKHzK61dlDSpLjWdpvUAchWHf4lpOWJoWMqrJNxiFYdJScsDTDO1/TUoL@lists.linux.dev X-Gm-Message-State: AOJu0YwUHEA6auEw6ZMwEzeC5Bx+TybkZmKHY5qHNfN7+vc/yDpgzZbv WmwabHh+3xPWX2DkNECrTNcO7a5NPEOIStwFLUMyacoXdSsC7UiW X-Google-Smtp-Source: AGHT+IH7qIuCcUe+n3Xpq0o4FDMm584GmXn4Kf/d6i5fSfeQjnkm13+WvWkEluAAjqSI+hTTk0yH3g== X-Received: by 2002:a17:90a:a010:b0:2e0:d7cf:12a4 with SMTP id 98e67ed59e1d1-2e0d7cf1401mr3183501a91.2.1727482099569; Fri, 27 Sep 2024 17:08:19 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e06e16fefesm6306762a91.6.2024.09.27.17.08.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Sep 2024 17:08:18 -0700 (PDT) Sender: Guenter Roeck Message-ID: Date: Fri, 27 Sep 2024 17:08:15 -0700 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 8/8] clk: Add KUnit tests for clks registered with struct clk_parent_data To: Shuah Khan , Stephen Boyd Cc: Michael Turquette , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, patches@lists.linux.dev, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, devicetree@vger.kernel.org, Brendan Higgins , David Gow , Rae Moar , Greg Kroah-Hartman , "Rafael J . Wysocki" , Rob Herring , Saravana Kannan , Daniel Latypov , Christian Marangi , Krzysztof Kozlowski , Conor Dooley , Maxime Ripard , Geert Uytterhoeven References: <20240718210513.3801024-1-sboyd@kernel.org> <20240718210513.3801024-9-sboyd@kernel.org> <6cd337fb-38f0-41cb-b942-5844b84433db@roeck-us.net> <6f5a5b5f-71a7-4ed3-8cb3-d930bbce599b@linuxfoundation.org> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: <6f5a5b5f-71a7-4ed3-8cb3-d930bbce599b@linuxfoundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 9/27/24 13:45, Shuah Khan wrote: > On 9/27/24 10:19, Guenter Roeck wrote: >> Copying devicetree maintainers. >> >> On Thu, Sep 26, 2024 at 09:39:38PM -0700, Guenter Roeck wrote: >>> On Thu, Sep 26, 2024 at 09:14:11PM -0700, Guenter Roeck wrote: >>>> Hi Stephen, >>>> >>>> On Thu, Jul 18, 2024 at 02:05:07PM -0700, Stephen Boyd wrote: >>>>> Test that clks registered with 'struct clk_parent_data' work as >>>>> intended and can find their parents. >>>>> >>>> >>>> When testing this on arm64, I see the error below. The error is only >>>> seen if I boot through efi, i.e., with "-bios QEMU_EFI-aarch64.fd" >>>> qemu parameter. >>>> >>>> Any idea what might cause the problem ? >>>> >>> I noticed that the new overlay tests fail as well, also with "path '/' not >>> found". >>> >>> [Maybe] answering my own question: I think the problem may be that there >>> is no devicetree file and thus no devicetree root when booting through >>> efi (in other words, of_root is NULL). Would it make sense to skip the >>> tests in that case ? >>> >> >> The problem is that of_root is not initialized in arm64 boots if ACPI >> is enabled. >> >>  From arch/arm64/kernel/setup.c:setup_arch(): >> >>     if (acpi_disabled) >>         unflatten_device_tree();        // initializes of_root >> >> ACPI is enabled if the system boots from EFI. This also affects >> CONFIG_OF_KUNIT_TEST, which explicitly checks if of_root exists and >> fails the test if it doesn't. >> >> I think those tests need to add a check for this condition, or affected >> machines won't be able to run those unit tests. The obvious solution would >> be to check if of_root is set, but then the associated test case in >> CONFIG_OF_KUNIT_TEST would not make sense. >> >> Any suggestions ? >> > > Would it work if these tests check if acpi_disabled and skip if it isn't > disabled? It might be low overhead condition to check from these tests. > > acpi_disabled is exported: > > arch/arm64/kernel/acpi.c:EXPORT_SYMBOL(acpi_disabled); > arch/loongarch/kernel/acpi.c:EXPORT_SYMBOL(acpi_disabled); > arch/riscv/kernel/acpi.c:EXPORT_SYMBOL(acpi_disabled); > arch/x86/kernel/acpi/boot.c:EXPORT_SYMBOL(acpi_disabled); > I don't think that would work. Looking through the use of acpi_init, I don't think that of_root is always NULL when acpi_init is false; that just happens to be the case on arm64 when booting through efi. However, even arm64 has the following code. if (acpi_disabled) psci_dt_init(); else psci_acpi_init(); While psci_dt_init() doesn't set of_root, it does try to do a devicetree match. So there must be some other condition where acpi_disabled is set but of_root is set anyway. I just have not found that code path. Guenter