From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Nathan Chancellor <nathan@kernel.org>, dmitry.baryshkov@linaro.org
Cc: heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org,
linux@roeck-us.net, neil.armstrong@linaro.org,
linux-usb@vger.kernel.org, dri-devel@lists.freedesktop.org,
patches@lists.linux.dev, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 3/3] drm/bridge: Return NULL instead of plain 0 in drm_dp_hpd_bridge_register() stub
Date: Tue, 5 Dec 2023 23:04:31 +0100 [thread overview]
Message-ID: <bc0bbe57-1739-4338-abfb-bd7011dc904b@linaro.org> (raw)
In-Reply-To: <20231205-drm_aux_bridge-fixes-v1-3-d242a0ae9df4@kernel.org>
On 05/12/2023 21:13, Nathan Chancellor wrote:
> sparse complains:
>
> drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c: note: in included file:
> include/drm/bridge/aux-bridge.h:29:16: sparse: sparse: Using plain integer as NULL pointer
>
> Return NULL to clear up the warning.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202312060025.BdeqZrWx-lkp@intel.com/
> Fixes: e560518a6c2e ("drm/bridge: implement generic DP HPD bridge")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
> include/drm/bridge/aux-bridge.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/bridge/aux-bridge.h b/include/drm/bridge/aux-bridge.h
> index 66249ff0858e..c4c423e97f06 100644
> --- a/include/drm/bridge/aux-bridge.h
> +++ b/include/drm/bridge/aux-bridge.h
> @@ -26,7 +26,7 @@ void drm_aux_hpd_bridge_notify(struct device *dev, enum drm_connector_status sta
> static inline struct device *drm_dp_hpd_bridge_register(struct device *parent,
> struct device_node *np)
> {
> - return 0;
> + return NULL;
> }
>
> static inline void drm_aux_hpd_bridge_notify(struct device *dev, enum drm_connector_status status)
>
Nice
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
next prev parent reply other threads:[~2023-12-05 22:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 20:13 [PATCH 0/3] A few fixes for transparent bridge support Nathan Chancellor
2023-12-05 20:13 ` [PATCH 1/3] usb: typec: nb7vpq904m: Only select DRM_AUX_BRIDGE with OF Nathan Chancellor
2023-12-05 20:58 ` Guenter Roeck
2023-12-06 7:16 ` Dmitry Baryshkov
2023-12-07 9:02 ` Heikki Krogerus
2023-12-05 20:13 ` [PATCH 2/3] usb: typec: qcom-pmic-typec: Only select DRM_AUX_HPD_BRIDGE " Nathan Chancellor
2023-12-05 20:58 ` Guenter Roeck
2023-12-05 22:03 ` Bryan O'Donoghue
2023-12-07 9:11 ` Heikki Krogerus
2023-12-05 20:13 ` [PATCH 3/3] drm/bridge: Return NULL instead of plain 0 in drm_dp_hpd_bridge_register() stub Nathan Chancellor
2023-12-05 20:59 ` Guenter Roeck
2023-12-05 22:04 ` Bryan O'Donoghue [this message]
2023-12-07 10:33 ` [PATCH 0/3] A few fixes for transparent bridge support Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc0bbe57-1739-4338-abfb-bd7011dc904b@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkp@intel.com \
--cc=nathan@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=patches@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox