Re: [PATCH] f2fs: Fix format specifier in sanity_check_inode()

[Chao Yu <chao@kernel.org>]

On 1/20/25 20:59, Nathan Chancellor wrote:
> When building for 32-bit platforms, for which 'size_t' is 'unsigned int',
> there is a warning due to an incorrect format specifier:
> 
>    fs/f2fs/inode.c:320:6: error: format specifies type 'unsigned long' but the argument has type 'unsigned int' [-Werror,-Wformat]
>      318 |                 f2fs_warn(sbi, "%s: inode (ino=%lx) has corrupted i_inline_xattr_size: %d, min: %lu, max: %lu",
>          |                                                                                                 ~~~
>          |                                                                                                 %u
>      319 |                           __func__, inode->i_ino, fi->i_inline_xattr_size,
>      320 |                           MIN_INLINE_XATTR_SIZE, MAX_INLINE_XATTR_SIZE);
>          |                           ^~~~~~~~~~~~~~~~~~~~~
>    fs/f2fs/f2fs.h:1855:46: note: expanded from macro 'f2fs_warn'
>     1855 |         f2fs_printk(sbi, false, KERN_WARNING fmt, ##__VA_ARGS__)
>          |                                              ~~~    ^~~~~~~~~~~
>    fs/f2fs/xattr.h:86:31: note: expanded from macro 'MIN_INLINE_XATTR_SIZE'
>       86 | #define MIN_INLINE_XATTR_SIZE (sizeof(struct f2fs_xattr_header) / sizeof(__le32))
>          |                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Use the format specifier for 'size_t', '%zu', to resolve the warning.
> 
> Fixes: 5c1768b67250 ("f2fs: fix to do sanity check correctly on i_inline_xattr_size")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,